[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009/5/15 Nicolas Sylvain : > > > 2009/5/15 Zhanyong Wan (λx.x x) >> >> 2009/5/15 Nicolas Sylvain : >> > >> > >> > 2009/5/15 Zhanyong Wan (λx.x x) >> >> >> >> 2009/5/15 Nicolas Sylvain : >> >> > >> >> > >> >> > 2009/5/15 Nicolas Sylvain >> >> >> >> >> >> >> >> >> On Fri, May 15, 2009 at 12:15 P

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009/5/15 Zhanyong Wan (λx.x x) > 2009/5/15 Nicolas Sylvain : > > > > > > 2009/5/15 Zhanyong Wan (λx.x x) > >> > >> 2009/5/15 Nicolas Sylvain : > >> > > >> > > >> > 2009/5/15 Nicolas Sylvain > >> >> > >> >> > >> >> On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) > >> >> wrote: > >> >>>

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009/5/15 Zhanyong Wan (λx.x x) > 2009/5/15 Nicolas Sylvain : > > > > > > 2009/5/15 Nicolas Sylvain > >> > >> > >> On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) > >> wrote: > >>> > >>> [ +zhanyong ] > >>> I chatted with Zhanyong about both swapping out tr1::tuple, and about > >>> remov

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009/5/15 Nicolas Sylvain > > > On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) < > ajw...@chromium.org> wrote: > >> [ +zhanyong ] >> I chatted with Zhanyong about both swapping out tr1::tuple, and about >> removing the svn:external reference in the repository. >> >> The gmock actions use

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

On Fri, May 15, 2009 at 12:15 PM, Albert J. Wong (王重傑) wrote: > [ +zhanyong ] > I chatted with Zhanyong about both swapping out tr1::tuple, and about > removing the svn:external reference in the repository. > > The gmock actions use tr1:tuple as part of the public interface for > defining new acti

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

[ +zhanyong ] I chatted with Zhanyong about both swapping out tr1::tuple, and about removing the svn:external reference in the repository. The gmock actions use tr1:tuple as part of the public interface for defining new actions. Thus, changing the tuple implementation would basically mean that an

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

If this is the only reason gmock needs boost, it seems like a better idea would be to push a copy of tuple.h into gmock and submit a patch to make it more self-contained in the first place. -scott On Fri, May 15, 2009 at 11:17 AM, Albert J. Wong (王重傑) wrote: > One other idea to explore...what

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

And to correct an error I made, the feature pack is included in the SP1 so there's no reason to download an additional 320 megs :) And since we require the service pack 1 on VS2008 anyway, we can assume(_MSCVER >= 1500) means TR1 is available. So I guess it's fine to not hack out a tr1::tuple out

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

One other idea to explore...what about "reimplementing" tr1::tuple using base::Tuple? It'd be a pretty naughty hack (adding something to the tr1:: namespace), but for the limited use-case of gmock, it could be good enough? -Albert On Fri, May 15, 2009 at 11:11 AM, Marc-Antoine Ruel wrote: > [-

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

[-chromium-reviews, +chromium-dev] (take 2) >From their website, «To use Google Mock, you will need the TR1 tuple C++ library installed.» and not directly boost. Up to now, chromium source tree assumed "defined(_MSC_VER) == No TR1", which is not exa