Hi Feng, If you wouldn't mind, please give us your opinion on this question. Evan Martin says you might have already responded, but if you did we've somehow managed to misplace it :-(...
Thanks, Marshall On Wed, Sep 24, 2008 at 10:45 PM, Marshall Greenblatt < [EMAIL PROTECTED]> wrote: > Hi Evan/Feng, > > > On Wed, Sep 24, 2008 at 10:09 PM, <[EMAIL PROTECTED]> wrote: > >> I just remembered some of this code might not work. Feng, do you >> remember changing this code? (It was in May 2008.) >> >> >> http://codereview.chromium.org/3175/diff/7/211 >> File webkit/glue/cpp_bound_class.cc (right): >> >> http://codereview.chromium.org/3175/diff/7/211#newcode157 >> Line 157: return (methods_.find(ident) != methods_.end() || >> fallback_callback_.get()); >> Hmm, I remember this causing problems in some bit of code. I wonder if >> I could find it... ah, yes. The commit message was (from Feng): >> "The fix [to not test fallback_callback] in cpp_bound_class.cc is a >> bonus. I talked to evanm that the check in incorrect. It does not work >> properly with NPObject binding code." > > > Without the proposed change to CppBoundClass::HasMethod() the fallback > callback will never actually be called, because HasMethod() must return true > before Invoke() will be executed. I did wonder, though, why the comments > didn't match the actual code :-). In current sources, the fallback callback > is only used in three places: > > webkit\glue\cpp_binding_example.cc(25): > BindFallbackMethod(&CppBindingExample::fallbackMethod); > webkit\glue\cpp_bound_class_unittest.cc(26): BindFallbackMethod(state ? > webkit\tools\test_shell\layout_test_controller.cc(118): > BindFallbackMethod(&LayoutTestController::fallbackMethod); > > So, for the chrome browser project, "fallback_callback_.get()" should > always be NULL. Is there something else outside of the chromium repository > that we need to be concerned about? > > >> >> >> http://codereview.chromium.org/3175 >> > > Regards, > Marshall > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
