On Tue, Nov 3, 2009 at 7:30 AM, Anton Muhin ant...@chromium.org wrote:
So the question: how could I check that I won't (notably) regress
Chromium performance with this change?
We have perf bots; you can check in and look at the effects there, and there
might even be a way to get perf results
Thanks a lot, Peter.
Yes, I am aware of those. Just wanted to run something before committing :)
I actually ran some DOM related tests. Adam (on IM) suggested to run
SunSpider, V8 and page load cyclers. I am going to do it and if
numbers are fine, then would try to commit my change.
yours,
One trick that I've regularly done when concerned about the perf impact of
a patch is to:
a) Wait till late at night pacific time, when very few checkins are landing
(often there are multi-hour gaps).
b) Land your change, and wait till the build bots all start building (about
a minute later).
Thanks, James.
So I ran SunSpider, V8 and page_cyclers. SunSpider and V8 are roughly the same.
page_cyclers trickier. First of all, I failed to run some tests on my
box (for both clean and patched builds)---all *Http tests just hang.
I hope it's missetup on my part, but hopefully not crucial.
