[chromium-dev] Re: code style verification/formatting tool

2008-12-17 Thread John Abd-El-Malek
This will be possible once Elliot cleans up the lint script so that it can be sent outside Google. On Wed, Dec 17, 2008 at 10:36 AM, Mohamed Mansour wrote: > Would be nice to make a gcl lint feature :) > gcl lint [mychangelist] before we submit it to codereview > > On Wed, Dec 17, 2008 at 1:33 P

[chromium-dev] Re: code style verification/formatting tool

2008-12-17 Thread Andrew Scherkus
Awesome! I love lint! On Wed, Dec 17, 2008 at 10:36 AM, Mohamed Mansour wrote: > Would be nice to make a gcl lint feature :) > gcl lint [mychangelist] before we submit it to codereview > > > On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel wrote: > >> >> Yep, that's simple and neat >> >> On We

[chromium-dev] Re: code style verification/formatting tool

2008-12-17 Thread Mohamed Mansour
Would be nice to make a gcl lint feature :) gcl lint [mychangelist] before we submit it to codereview On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel wrote: > > Yep, that's simple and neat > > On Wed, Dec 17, 2008 at 1:29 PM, Erik Kay wrote: > > jam++ > > Great stuff! I like how this is int

[chromium-dev] Re: code style verification/formatting tool

2008-12-17 Thread Marc-Antoine Ruel
Yep, that's simple and neat On Wed, Dec 17, 2008 at 1:29 PM, Erik Kay wrote: > jam++ > Great stuff! I like how this is integrated. It feels very natural. > Erik > > On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek wrote: >> >> Just a heads-up that I've integrated the script into our Rietvel

[chromium-dev] Re: code style verification/formatting tool

2008-12-17 Thread Erik Kay
jam++ Great stuff! I like how this is integrated. It feels very natural. Erik On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek wrote: > > Just a heads-up that I've integrated the script into our Rietveld > instance. If you use gcl, it will ping the server at a special url > after a patchs

[chromium-dev] Re: code style verification/formatting tool

2008-12-16 Thread Peter Kasting
On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek wrote: > Just a heads-up that I've integrated the script into our Rietveld > instance. This is great, thanks very much. Maybe you should send a standalone email telling people to look for this link just to be sure we don't miss it? PK --~--~

[chromium-dev] Re: code style verification/formatting tool

2008-12-16 Thread John Abd-El-Malek
On Tue, Dec 16, 2008 at 8:26 PM, Mohamed Mansour wrote: > Awesome John, will save a lot of time for those reviewers. So I assume this > is only for Google code style, webkit patches reviews will always display an > error since they have a different style. That's correct. The script doesn't catc

[chromium-dev] Re: code style verification/formatting tool

2008-12-16 Thread Mohamed Mansour
Awesome John, will save a lot of time for those reviewers. So I assume this is only for Google code style, webkit patches reviews will always display an error since they have a different style. On Tue, Dec 16, 2008 at 11:20 PM, Adam Barth wrote: > > Awesome! Thanks John. Trailing whitespace be

[chromium-dev] Re: code style verification/formatting tool

2008-12-16 Thread Adam Barth
Awesome! Thanks John. Trailing whitespace be gone! On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek wrote: > > Just a heads-up that I've integrated the script into our Rietveld > instance. If you use gcl, it will ping the server at a special url > after a patchset upload so that it can lint

[chromium-dev] Re: code style verification/formatting tool

2008-12-16 Thread John Abd-El-Malek
Just a heads-up that I've integrated the script into our Rietveld instance. If you use gcl, it will ping the server at a special url after a patchset upload so that it can lint the files in the background. When you visit the issue page, you'll see a "x errors" link under the Lint column which t

[chromium-dev] Re: code style verification/formatting tool

2008-12-05 Thread Marc-Antoine Ruel
I did an internal search and the current state is: - "Folks have been looking at open sourcing cpplint" - In its current incarnation, there is a lot of google-specific checks that needs to be factored out simply because they don't apply to external and open source projects. - Nobody actually took

[chromium-dev] Re: code style verification/formatting tool

2008-12-04 Thread Marshall Greenblatt
Ok, so, back to the original question. When can those of us external to google expect a code style tool? :-) On Thu, Dec 4, 2008 at 1:57 PM, Dean McNamee <[EMAIL PROTECTED]> wrote: > > It doesn't need to be a parser, it's just a linter. You don't really > need to understand anything about the p

[chromium-dev] Re: code style verification/formatting tool

2008-12-04 Thread Dean McNamee
It doesn't need to be a parser, it's just a linter. You don't really need to understand anything about the program to give useful warnings about style. Our biggest style violation is probably trailing whitespace, for example. On Thu, Dec 4, 2008 at 7:33 PM, Benjamin <[EMAIL PROTECTED]> wrote: >

[chromium-dev] Re: code style verification/formatting tool

2008-12-04 Thread Benjamin
You wrote a c++ parser in python? cl! I can't wait to see the source. -Benjamin Meyer On Thu, Dec 4, 2008 at 12:22 PM, Pam Greene <[EMAIL PROTECTED]> wrote: > > On Wed, Dec 3, 2008 at 8:30 PM, Benjamin <[EMAIL PROTECTED]> wrote: >> >> On Wed, Dec 3, 2008 at 3:45 PM, Marshall Greenblatt >> <

[chromium-dev] Re: code style verification/formatting tool

2008-12-04 Thread Pam Greene
On Wed, Dec 3, 2008 at 8:30 PM, Benjamin <[EMAIL PROTECTED]> wrote: > > On Wed, Dec 3, 2008 at 3:45 PM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: >> Sorry to be a pest, but has there been any progress on this? >> >> Thanks, >> Marshall >> >> On Thu, Sep 18, 2008 at 4:17 PM, Pam Greene <[EMA

[chromium-dev] Re: code style verification/formatting tool

2008-12-03 Thread Benjamin
On Wed, Dec 3, 2008 at 3:45 PM, Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > Sorry to be a pest, but has there been any progress on this? > > Thanks, > Marshall > > On Thu, Sep 18, 2008 at 4:17 PM, Pam Greene <[EMAIL PROTECTED]> wrote: >> >> On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblat

[chromium-dev] Re: code style verification/formatting tool

2008-12-03 Thread Marshall Greenblatt
Sorry to be a pest, but has there been any progress on this? Thanks, Marshall On Thu, Sep 18, 2008 at 4:17 PM, Pam Greene <[EMAIL PROTECTED]> wrote: > > On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Hi Mark/Pam, > > > > On Thu, Sep 18, 2008 at 2:48 PM, Ma

[chromium-dev] Re: code style verification/formatting tool

2008-09-18 Thread Pam Greene
On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > Hi Mark/Pam, > > On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai <[EMAIL PROTECTED]> wrote: >> >> Great question. We've been talking about open-sourcing something for >> this, but so far, we don't have anything yet.

[chromium-dev] Re: code style verification/formatting tool

2008-09-18 Thread Marshall Greenblatt
Hi Mark/Pam, On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai <[EMAIL PROTECTED]> wrote: > > Great question. We've been talking about open-sourcing something for > this, but so far, we don't have anything yet. We do have something we > use internally, but someone needs to go through it and clean u

[chromium-dev] Re: code style verification/formatting tool

2008-09-18 Thread Mark Mentovai
Marshall Greenblatt wrote: > Does a tool currently exist for verifying and/or formatting source code > based on the Google style guide? If not, has any thought been given to > developing such a tool? Marshall- Great question. We've been talking about open-sourcing something for this, but so fa

[chromium-dev] Re: code style verification/formatting tool

2008-09-18 Thread Pam Greene
I'll ask around and see if I can find one we can open-source. - Pam On Thu, Sep 18, 2008 at 7:06 AM, Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > Hi All, > > Does a tool currently exist for verifying and/or formatting source code > based on the Google style guide? If not, has any thought be