This is a work in progress, according to some recent (few days) change
lists. Someone currently goes over most of the sources and lint cleans them
in preparation for adding the lint check to the presubmit check, or
something like that.
☆PhistucK
On Tue, Nov 17, 2009 at 07:48, Peter Kasting
Does this warning help anyone, anywhere, for any reason? It's on explicitly
for the Mac and implicitly for Linux, and when you combine it with Warn As
Error and Visual Studio not auto-adding a trailing newline, it means my
patches frequently trivially fail to compile on the trybots. Easy fix,
On Mon, Nov 16, 2009 at 7:22 PM, Peter Kasting pkast...@google.com wrote:
Does this warning help anyone, anywhere, for any reason?
.h files that are missing newlines cause nasty and confusing
errors on some platforms, IIRC.
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
On Mon, Nov 16, 2009 at 7:31 PM, Peter Kasting pkast...@google.com wrote:
Yeah, and are our preprocessors actually going to do what's described in
that post? I'm sure MSVC won't. I doubt gcc on Mac/Linux will.
This was a real issue for me with gcc a few years ago (at Google, IIRC).
- Dan
--
Lint will warn you about this -- and I know that everyone runs gcl lint
changelist_name before uploading...
-Ian
2009/11/16 Dan Kegel d...@kegel.com
On Mon, Nov 16, 2009 at 7:31 PM, Peter Kasting pkast...@google.com
wrote:
Yeah, and are our preprocessors actually going to do what's
On Mon, Nov 16, 2009 at 9:07 PM, Ian Fette i...@chromium.org wrote:
Lint will warn you about this -- and I know that everyone runs gcl lint
changelist_name before uploading...
Why do I have to remember to run a separate command? Why does this not run
during presubmit?
PK
--
Chromium
