Re: [chrony-dev] [PATCH] More reliable method of reading rtc for initial trim

2014-06-02 Thread Miroslav Lichvar
On Mon, Jun 02, 2014 at 11:48:13AM +0200, Hattink, Tjalling [FINT] wrote: > > > I've been able to see this behavior by continuously reading the rtc > > > clock. > > > > Was that with the RTC_RD_TIME ioctl or were you reading CMOS directly? > > I tried to reproduce it with a program continuosly

RE: [chrony-dev] [PATCH] More reliable method of reading rtc for initial trim

2014-06-02 Thread Hattink, Tjalling [FINT]
> Isn't the following code in the kernel code (above the CMOS > operations) supposed to prevent that? > > /* >* read RTC once any update in progress is done. The update >* can take just over 2ms. We wait 20ms. There is no need to >* to poll-wait (up to 1s - eeccch)

RE: [chrony-dev] [PATCH] More reliable method of reading rtc for initial trim

2014-05-28 Thread Hattink, Tjalling [FINT]
> > When chrony reads in the linux rtc for the first time to trim the > > system clock, it only reads it once. As it is possible that the rtc > > updates itself during the read operation, the reported rtc time could > > be false. To prevent this I've added a loop that reads the rtc clock > >

Re: [chrony-dev] [PATCH] More reliable method of reading rtc for initial trim

2014-05-28 Thread Miroslav Lichvar
On Wed, May 28, 2014 at 01:23:45PM +0200, Hattink, Tjalling [FINT] wrote: > When chrony reads in the linux rtc for the first time to trim the > system clock, it only reads it once. As it is possible that the rtc > updates itself during the read operation, the reported rtc time > could be false. To