Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-13 Thread Bryan Christianson
> On 13/07/2017, at 11:10 PM, Miroslav Lichvar wrote: > > On Thu, Jul 13, 2017 at 12:18:02PM +1200, Bryan Christianson wrote: >> macOS 10.13 will implement the ntp_adjtime() system call, allowing better >> control over the system clock than is possible with the existing adjtime() >> system call.

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-13 Thread Miroslav Lichvar
On Thu, Jul 13, 2017 at 12:18:02PM +1200, Bryan Christianson wrote: > macOS 10.13 will implement the ntp_adjtime() system call, allowing better > control over the system clock than is possible with the existing adjtime() > system call. > chronyd will support both the older and newer calls, enabling

[chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-12 Thread Bryan Christianson
macOS 10.13 will implement the ntp_adjtime() system call, allowing better control over the system clock than is possible with the existing adjtime() system call. chronyd will support both the older and newer calls, enabling binary code to run without recompilation on macOS 10.9 through macOS 10.13

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-12 Thread Bryan Christianson
> On 12/07/2017, at 9:55 PM, Miroslav Lichvar wrote: > > The initialization function could look like this: > > have_ntp_adjtime = (dlsym(RTLD_NEXT, "ntp_adjtime") != NULL); > if (have_ntp_adjtime) { > buggy_adjtime = !test_adjtime(); > if (buggy_adjtime) > SYS_Timex_Initialise

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-12 Thread Miroslav Lichvar
On Wed, Jul 12, 2017 at 05:56:36PM +1200, Bryan Christianson wrote: > > On 11/07/2017, at 7:26 PM, Miroslav Lichvar wrote: > > I agree, as long as they can fix the adjtime() bug. If it's not fixed, > > it would probably be better to disable the fast-slewing feature in > > order to avoid adjtime().

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-11 Thread Bryan Christianson
> On 11/07/2017, at 7:26 PM, Miroslav Lichvar wrote: > > I agree, as long as they can fix the adjtime() bug. If it's not fixed, > it would probably be better to disable the fast-slewing feature in > order to avoid adjtime(). I'm not sure how to do this. Any hints? I'm assuming Apple will get a

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-11 Thread Bill Unruh
William G. Unruh __| Canadian Institute for| Tel: +1(604)822-3273 Physics&Astronomy _|___ Advanced Research _| Fax: +1(604)822-5324 UBC, Vancouver,BC _|_ Program in Cosmology | un...@physics.ubc.ca Canada V6T 1Z1 | and Gravity __|_ www.theory.physics.ubc.ca/ On Tue, 11 J

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-11 Thread Miroslav Lichvar
On Tue, Jul 11, 2017 at 03:21:42AM +1200, Bryan Christianson wrote: > > On 11/07/2017, at 2:49 AM, Miroslav Lichvar wrote: > > Can you please use Oxford comma? The rest of the documentation is > > using it (to the extend I understand it's supposed to be used). > > I had never heard of 'Oxford com

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-10 Thread Bryan Christianson
Hi Miroslov There is a new release of macOS 10.13 out today but as yet no fix for the adjtime() issue. > On 11/07/2017, at 2:49 AM, Miroslav Lichvar wrote: > > Is it really 5000 ppm on macOS 10.13? There is a testing program > test/kernel/adjtime, which should print the maximum slew rate. You >

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-10 Thread Bryan Christianson
> On 11/07/2017, at 2:49 AM, Miroslav Lichvar wrote: > > On Mon, Jul 10, 2017 at 08:03:19PM +1200, Bryan Christianson wrote: >> >> +With the exception of macOS 10.12 and earlier, all systems have operating >> system > > Would it better to say "all supported systems" ? OK - I'll change that.

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-10 Thread Miroslav Lichvar
On Mon, Jul 10, 2017 at 08:03:19PM +1200, Bryan Christianson wrote: > macOS 10.13 will implement the ntp_adjtime() system call, allowing better > control over the system clock than is possible with the existing adjtime() > system call. > chronyd will support both the older and newer calls, enabling

[chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-07-10 Thread Bryan Christianson
macOS 10.13 will implement the ntp_adjtime() system call, allowing better control over the system clock than is possible with the existing adjtime() system call. chronyd will support both the older and newer calls, enabling binary code to run without recompilation on macOS 10.9 through macOS 10.13

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-06-30 Thread Bryan Christianson
> On 30/06/2017, at 11:37 PM, Miroslav Lichvar wrote: > > This looks great. Thanks. > > Can you please also update documentation of the -r option and the > dumpdir, corrtimeratio, leapsecmode, rtcsync, maxdrift, and maxslewrate > directives? Where all supported systems would be listed, it now

Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-06-30 Thread Miroslav Lichvar
On Fri, Jun 30, 2017 at 07:54:59PM +1200, Bryan Christianson wrote: > macOS 10.13 will implement the ntp_adjtime() system call, allowing better > control over the system clock than is possible with the existing adjtime() > system call. > chronyd will support both the older and newer calls, enabling

[chrony-dev] [PATCH] macOS - support for ntp_adjtime()

2017-06-30 Thread Bryan Christianson
macOS 10.13 will implement the ntp_adjtime() system call, allowing better control over the system clock than is possible with the existing adjtime() system call. chronyd will support both the older and newer calls, enabling binary code to run without recompilation on macOS 10.9 through macOS 10.13