Re: [CinCVS] small fix for entering timecodes

2006-10-26 Thread Pierre Marc Dumuid
Andraž Tori wrote: Yes, this is nice. One thing though, horizontal dialogs seem a bit less disturbing to me.. if everything is vertical i get intimidated by the sheer number of things to set. So.. even with widgetgrid, things could go into width instead hight a little bit more. I agree, (It wa

Re: [CinCVS] small fix for entering timecodes

2006-10-26 Thread Andraž Tori
On Wed, 2006-10-25 at 17:40 +0930, Pierre Dumuid wrote: > > > ( See the ACTUAL RESULTS of applying the widgetgrid branch at: > http://www.pipapo.org/pipawiki/Cinelerra/Developers/pmdumuid/widgetgrid ) > > With the widget grid, all widgets are place on a grid (and possibly > sub-grids) then a

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Andraž Tori
this is not acceptable kind of patch, since it changes the behaviour of other themes. you should create a one that does what you want for you but does not intrude in others bye andraz On Wed, 2006-10-25 at 17:54 +0900, Miha Kitič wrote: > Hi again! > > I am posting a diff file now! > > All the

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Miha Kitič
Reply to mysef... Sorry, missunderstanding... I thought that anoter person is working on BlueDot right now. But I guess it's just me... Anyhow, I'll post the changes in the near future. Miha > No need for two people to do the work twice. > My blue dot is more or less functional, but there are s

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Miha Kitič
On sre, 2006-10-25 at 17:40 +0930, Pierre Dumuid wrote: > Hi Miha, > > Miha: I hope you don't mind, but this discussion should be on the list > not in person with me! Sorry, but I didn't want to put it on the list as I have not yet determined to work on a new theme. I didn't tell you, but I am t

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Miha Kitič
Hi again! I am posting a diff file now! All the best and thank you! Miha diff --git a/guicast/units.C b/guicast/units.C index 173a1f4..e58826c 100644 --- a/guicast/units.C +++ b/guicast/units.C @@ -171,7 +171,8 @@ char* Units::totext(char *text, { case TIME_SECONDS: seconds = fabs(seco

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Miha Kitič
HiAndraž! Sorry, I am not used to git, but I am working on this point now with Pierre. As a matter of fact I have managed to post something and looks like it is visible on gitk. I will try my best to learn how to use this sistem. As for the changes, they have been tested on all themes and they d

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Pierre Dumuid
Hi Miha, Miha: I hope you don't mind, but this discussion should be on the list not in person with me! Others: I've been helping miha learn a few steps in git, and helping him get involved in fixing up bluedot theme... For your bluedot theme, please start with making changes primarily to th

Re: [CinCVS] small fix for entering timecodes

2006-10-25 Thread Andraž Tori
please posst a diff not a whole file - i cannot see what you have changed. Your changes should be non-intrusive to the other code, add aditional capabilities - using for example new parameter (new timeformat) or completely new function (maybe not in this case), don't change existing ones. bye and

Re: [CinCVS] small fix for entering timecodes

2006-10-24 Thread Miha Kitič
I managed to the point when editor opens up. But it says: CG: Lines beginning with the CG: prefix are removed automatically. CG: CG: Author: MihaKitic CG: Email: [EMAIL PROTECTED](none) CG: CG: By deleting lines beginning with CG:F, the associated file CG: will be removed from the commit list. Sh

Re: [CinCVS] small fix for entering timecodes

2006-10-24 Thread Pierre Dumuid
If you have made commits then look at your branch in gitk, and identify the SHA-1 before / after your units.C change. then do: cg-diff -r A:B guicast/units.C > /tmp/myunits_change.diff or cg-diff -r B^:B where A / B are the SHA-1 for before / after as appropriate.. and send the myunits_change

Re: [CinCVS] small fix for entering timecodes

2006-10-24 Thread Miha Kitič
Help please :) I can use git, but at the moment I don't really have a clear idea on how it works. If you tell me what to do I will do it! All the best! Miha On sre, 2006-10-25 at 09:48 +0930, Pierre Dumuid wrote: > Hi Miha, > sending whole files doesn't really show what you did to the file...

Re: [CinCVS] small fix for entering timecodes

2006-10-24 Thread Pierre Dumuid
Hi Miha, sending whole files doesn't really show what you did to the file... if you are using git, could you give the output as a diff? Pierre Miha Kitič wrote: Hi Andraž! I am now working on BlueDot theme and I think I had the same issue. I made a small fix in units.C file, which I haven't sp

Re: [CinCVS] small fix for entering timecodes

2006-10-24 Thread Miha Kitič
Hi Andraž! I am now working on BlueDot theme and I think I had the same issue. I made a small fix in units.C file, which I haven't spoke about yet, because my work has not finished yet. The point is that BlueDot needs 11 digits when displaying time in order to look nice (it's because the clock's g

[CinCVS] small fix for entering timecodes

2006-10-24 Thread Andraž Tori
when entering timecodes that had more than one digit number of hours, timecodes got messed up. This directly hindered one user when working on his film project. bye andraz --- hvirtual-svn/cinelerra/assetedit.C 2006-10-13 12:05:59.0 +0200 +++ hvirtual-2.1/cinelerra/assetedit.C 2006-10-