Re: Tests, Documentation

2003-11-26 Thread graydon hoare
Dalibor Topic <[EMAIL PROTECTED]> writes: > > - tests can be added inline with a source file, or "right next > > door" in a similarly-named class or package. > > only if you want mauve to have GNU Classpath specific features. I guess my point is I'd like to lower, as far as possible, t

Re: [PATCH] Serialization #2 (set field methods)

2003-11-26 Thread Guilhem Lavaux
Sorry. Here is the patch. Guilhem. Index: java/io/ObjectInputStream.java === RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v retrieving revision 1.32 diff -u -r1.32 ObjectInputStream.java --- java/io/ObjectInpu

[PATCH] Serialization #3

2003-11-26 Thread Guilhem Lavaux
This the patch number 3. It adds a few methods to java.io.ObjectStreamField: they will become necessary for the next patches that will follow tomorrow. BTW, it fixes the behaviour of a constructor which should throw a NullPointerException according to JDK's behaviour but was not in classpath's.

Re: [PATCH] Serialization #2 (set field methods)

2003-11-26 Thread Michael Koch
On Wed, Nov 26, 2003 at 09:07:24PM +0100, Guilhem Lavaux wrote: > P.S.: Should I really write a documentation for each of the methods in > this patch ? I would think they are straightforward to understand... In > the other case I'll try to write something. The way you do it here seems okay, but

[PATCH] Serialization #2 (set field methods)

2003-11-26 Thread Guilhem Lavaux
Hi, This patch adds extra checking required by JDK's behaviour. If someone tries to assign a field which has not the required type then an InvalidClassException should be thrown. Please review it. Cheers, Guilhem. P.S.: Should I really write a documentation for each of the methods in this pat

[PATCH] Pre-submit for serialization

2003-11-26 Thread Guilhem Lavaux
Hi, I think I will have to begin the split of the serialization patch at a time or another. I'm beginning with this really simple patch for TypeSignature. It is needed so class can resolved by name using a specific class loader and not using a default class loader as it was the case with the p

Re: PixelGrabber fixes

2003-11-26 Thread Tom Tromey
> "Tom" == Thomas Fitzsimmons <[EMAIL PROTECTED]> writes: Tom> This patch completes the PixelGrabber implementation, updates its Tom> javadocs and includes a mauve test case. Excellent. Tom> OK to commit? Definitely, thanks. FYI, Mauve tests don't require approval. It's a free-for-all. T