Re: [cp-patches] [patch] fix memory image source handling in GTK peers

2005-07-26 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 21:56 -0400, Thomas Fitzsimmons wrote: @@ -372,8 +374,28 @@ if (x == 0 y == 0 width == 0 height == 0) return; -q().postEvent (new PaintEvent (awtComponent, PaintEvent.UPDATE, - new Rectangle (x, y, width,

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-26 Thread Jeroen Frijters
Mark Wielaard wrote: On Mon, 2005-07-25 at 18:17 +0200, Jeroen Frijters wrote: Is this an important scenario? I thought you long haired types didn't like binary distributions ;-) He he. Sure we don't. But if you follow the harmony effort of the cleanly shaved apache types you will have

Re: [cp-patches] FYI: Minor tweak to java.awt.List

2005-07-26 Thread Mark Wielaard
Hi, On Sat, 2005-07-23 at 18:00 +0200, Sven de Marothy wrote: This agrees with the JDK behaviour better. And my peers expect it too. (Whoops, accidentally commited a change to Component. Did that revert correctly?) No. You committed the attached. The first hunk seems to have been changed by

RE: [cp-patches] FYI: Small additional ClassLoader VMextensibility point

2005-07-26 Thread Jeroen Frijters
Mark Wielaard wrote: On Mon, 2005-07-25 at 11:43 +0200, Jeroen Frijters wrote: I committed the attached patch, that allows a VM implementer to hook Classloader.findLoadedClass. When adding new VM hooks could you please add a little note to the NEWS file. That makes it much easier for VM

Re: [cp-patches] RFC: misc NIO fixes

2005-07-26 Thread Mark Wielaard
Hi, On Sat, 2005-07-23 at 20:37 -0700, Casey Marshall wrote: Committed. I changed a few minor things, such as using Mark's suggestion to use 'madvise' to load the file into core. I can't get this to work with Jamvm on Darwin; I get a bizarre segfault when trying to create the new

Re: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Andrew Haley
Tom Tromey writes: Jeroen == Jeroen Frijters [EMAIL PROTECTED] writes: Jeroen * java/rmi/server/RMIClassLoader.java Jeroen (loadClass(String, String)): Use Class.forName() instead of Jeroen directly calling ClassLoader.loadClass(), to handle array Jeroen types

[cp-patches] FYI: Proxy - VMProxy patch

2005-07-26 Thread Jeroen Frijters
Hi, I moved to native methods in Proxy to VMProxy and moved the configuration flags that control whether the native methods are used from gnu.classpath.Configuration to VMProxy as well. Regards, Jeroen 2005-07-26 Jeroen Frijters [EMAIL PROTECTED] * NEWS: Added comment about new

Re: [cp-patches] javanet.c compile fix for IRIX

2005-07-26 Thread Christian Thalinger
On Tue, 2005-07-26 at 11:12 +0200, Mark Wielaard wrote: Hi, On Tue, 2005-07-26 at 10:20 +0200, Christian Thalinger wrote: There is an include missing (for timeval struct). #ifndef TARGET_NATIVE_NETWORK_SOCKET_SET_OPTION_SO_TIMEOUT + #include sys/time.h #include sys/types.h

Re: [cp-patches] javanet.c compile fix for IRIX

2005-07-26 Thread Mark Wielaard
Hi Christian, On Tue, 2005-07-26 at 11:29 +0200, Christian Thalinger wrote: On Tue, 2005-07-26 at 11:12 +0200, Mark Wielaard wrote: That is what the autoconf manual recommends. Does that work for you? Yes. Thanks. Committed as follows: 2005-07-26 Christian Thalinger [EMAIL PROTECTED]

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Jeroen Frijters
Andrew Haley wrote: Tom Tromey writes: Jeroen == Jeroen Frijters [EMAIL PROTECTED] writes: Jeroen* java/rmi/server/RMIClassLoader.java Jeroen(loadClass(String, String)): Use Class.forName() instead of Jeroendirectly calling ClassLoader.loadClass(), to handle array

[cp-patches] FYI: Better diagnostics for FileChannelImpl

2005-07-26 Thread Mark Wielaard
Hi, I had this patch on my disk for a long time. It helps with debugging file related errors/exceptions a lot. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * gnu/java/nio/channels/FileChannelImpl.java (description): New final field. (FileChannelImpl): Set description. (init):

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Andrew Haley
Jeroen Frijters writes: Andrew Haley wrote: Tom Tromey writes: Jeroen == Jeroen Frijters [EMAIL PROTECTED] writes: Jeroen * java/rmi/server/RMIClassLoader.java Jeroen (loadClass(String, String)): Use Class.forName() instead of Jeroen

[cp-patches] FYI: FileChannelImpl lock() and tryLock() sanity checking

2005-07-26 Thread Mark Wielaard
Hi, This moves the sanity checking of lock() and tryLock() into a shared private method checkLock() so that all argument and channel property checking is done in the same way. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * gnu/java/nio/channels/FileChannelImpl.java (lockCheck): New

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Jeroen Frijters
Andrew Haley wrote: All of this is fairly ill-specified. As usual :-( I just re-read the relevant part of the 1.5 API spec and JLS (which it refers to) and I think you can actually interpret it to prohibit loading array classes via ClassLoader.loadClass (indirectly based on the definition of

[cp-patches] FYI: Some more FileChannelImpl.c cleanups

2005-07-26 Thread Mark Wielaard
Hi, A close and select call (possibly used by available) can be interrupted. In that case we have to retry the system call. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_channels_FileChannelImpl.c (Java_gnu_java_nio_channels_FileChannelImpl_init): Mark

[cp-patches] FYI: MetalBorders.MenuItemBorder implemented

2005-07-26 Thread David Gilbert
I committed this patch: 2005-07-26 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalBorders.java: (MenuItemBorder): new inner class. Regards, Dave Gilbert Index: javax/swing/plaf/metal/MetalBorders.java

[cp-patches] DataFormat.equals() reimplemented

2005-07-26 Thread Mark Wielaard
Hi, This is a reimplementation of DateFormat.equals() following the JCL book description. While testing this I found that David already created Mauve tests for this which closely follow this description already. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * java/text/DateFormat.java

[cp-patches] FYI: MetalBorders.MenuBarBorder implemented

2005-07-26 Thread David Gilbert
I committed this patch: 2005-07-26 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalBorders.java: (MenuBarBorder): new inner class. Regards, Dave Gilbert Index: javax/swing/plaf/metal/MetalBorders.java

[cp-patches] FYI: Fixed formatting of AWTUtilities

2005-07-26 Thread Roman Kennke
As suggested by Mark, I committed the following formatting fix. 2005-07-26 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/AWTUtilities.java: Fixed formatting of this file. /Roman Index: gnu/java/awt/AWTUtilities.java

[cp-patches] FYI: Avoid recursion in java.util.Properties

2005-07-26 Thread Roman Kennke
This fix 'outsources' the functionality of the getProperty methods into a private method. This avoids infinite recursion if one of the getProperty methods is overridden in subclasses. 2005-07-26 Roman Kennke [EMAIL PROTECTED] * java/util/Properties.java

[cp-patches] FYI: basic plaf getPreferredSize() cleanups

2005-07-26 Thread Mark Wielaard
Hi, I was seeing a loop with an application using getPreferredSize() because BasicToolBarUI was calling the layoutmanager directly. It should actually just return null (as the default implementation of UIComponent does) to get the layoutmanager to calculate the preferred size. On irc Roman and I

[cp-patches] FYI: Added new borders to MetalLookAndFeel

2005-07-26 Thread Roman Kennke
I added the border that David implemented to the MetalLookAndFeel. 2005-07-26 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalLookAndFeel.java (initComponentDefaults): Added new borders for MenuBar and MenuItem. /Roman Index:

[cp-patches] FYI: fixlet for BasicButtonUI

2005-07-26 Thread Roman Kennke
2005-07-26 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicButtonUI.java (paint): Only call paintFocus if the button is actually focused. (paintFocus): The default implementation in the BasicLookAndFeel does nothing. I removed the code here. /Roman

[cp-patches] Re: DataFormat.equals() reimplemented

2005-07-26 Thread Mark Wielaard
Hi David, On Tue, 2005-07-26 at 15:22 +, David Gilbert wrote: I wasn't sure from your description exactly which test fails. Only number 10 fails. Where you set the TimeZone of the Calendar to a new one with the same rules. I can't run the tests against Classpath myself right now because

Re: [cp-patches] [patch] examples README

2005-07-26 Thread Tom Tromey
Andreas == Andreas Tobler [EMAIL PROTECTED] writes: Andreas a little patchlet for the README in the examples directory. Andreas Ok? Yes, thanks. Tom ___ Classpath-patches mailing list Classpath-patches@gnu.org

Re: [cp-patches] rmic error handling

2005-07-26 Thread Tom Tromey
Archit == Archit Shah [EMAIL PROTECTED] writes: Archit Attached is a patch to the cp-tools rmic that centralizes calls to Archit System.exit and makes handling of exceptions and error conditions more Archit uniform. Please write a ChangeLog entry and check it in. Thanks. Tom

Re: [cp-patches] FYI: Minor tweak to java.awt.List

2005-07-26 Thread Tom Tromey
(Whoops, accidentally commited a change to Component. Did that revert correctly?) Mark No. You committed the attached. I thought I'd mention a nice cvs trick for reverting a patch. (I've had to do this more times than I care to admit...) If you accidentally check in a commit to some file

[cp-patches] FYI: API fixes for Swing

2005-07-26 Thread Roman Kennke
Hi added and fixed some API comments for Swing. 2005-07-26 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractAction.java Fixed / Added API doc comments for the class description. * javax/swing/AbstractButton.java: Likewise. *

Re: [cp-patches] [patch] fix memory image source handling in GTK peers

2005-07-26 Thread Thomas Fitzsimmons
On Tue, 2005-07-26 at 07:48 +0200, Mark Wielaard wrote: I don't think you want to create a (non-daemon) Timer each and every time here. That means that on each repaint() a new Thread is created which is never destroyed and which will prevent the application to ever stop since the Timers will

[cp-patches] Patch: FYI: PR classpath/22988

2005-07-26 Thread Tom Tromey
I'm checking this in. This fixes a buglet found by FindBugs and reported as classpath/22988. Tom Index: ChangeLog from Tom Tromey [EMAIL PROTECTED] * javax/security/auth/x500/X500Principal.java (getName): Don't compare oid to String. PR classpath/22988. Index:

[cp-patches] Patch: FYI: PR classpath/22987

2005-07-26 Thread Tom Tromey
I'm checking this in. This fixes PR classpath/22987. We were comparing an OID to a String. The simplest fix seems to be to compare the OID's String representation instead. Tom Index: ChangeLog from Tom Tromey [EMAIL PROTECTED] * java/security/cert/X509CertSelector.java (match):

[cp-patches] Re: Patch: FYI: PR classpath/22988

2005-07-26 Thread Tom Tromey
Tom == Tom Tromey [EMAIL PROTECTED] writes: Tom This fixes a buglet found by FindBugs and reported as classpath/22988. Tom Index: javax/swing/text/AbstractWriter.java Tom Index: javax/swing/text/ElementIterator.java I didn't mean to include these in the patch and I didn't check them in. In

Re: [cp-patches] RFC: New JCL helper functions for RawData handling

2005-07-26 Thread Tom Tromey
Chris == Chris Burdess [EMAIL PROTECTED] writes: Chris If the libgcj way is better we should Chris use that instead since as I understand it it would save a layer of Chris indirection, but perhaps it needs VM-specific support to work? Yeah, it needs special vm treatment to work. My impression

[cp-patches] FYI: 2 BasicTableUI patches

2005-07-26 Thread Anthony Balkissoon
First one simply implements CTRL-Space action (toggle). Second one replaces calls to KeyEvent.isControlDown() and isShiftDown() with comparisons between KeyEvent.getModifiers() and InputEvent.SHIFT_MASK and CTRL_MASK. This way we ignore invalid modifiers for events without explicitly writing in

[cp-patches] Patch: FYI: Fix PR classpath/22991

2005-07-26 Thread Tom Tromey
I'm checking this in. Another fixlet suggested by FindBugs. Tom Index: ChangeLog from Tom Tromey [EMAIL PROTECTED] * gnu/java/security/provider/PKIXCertPathValidatorImpl.java (engineValidate): Fix sense of test. PR classpath/22991. Index:

[cp-patches] Patch: FYI: fix PR classpath/22992

2005-07-26 Thread Tom Tromey
I'm checking this in. Another bug found by FindBugs. The code in question is obviously useless; the sense of the test was wrong. Tom Index: ChangeLog from Tom Tromey [EMAIL PROTECTED] PR classpath/22992: * javax/security/sasl/Sasl.java (getSaslClientFactories): Fix

[cp-patches] Patch: FYI: PR classpath/22989

2005-07-26 Thread Tom Tromey
I'm checking this in. This fixes PR classpath/22989. We don't need all these overrides that do nothing, but it was simpler to fix the two bogus calls. Tom Index: ChangeLog from Tom Tromey [EMAIL PROTECTED] PR classpath/22989: * java/net/Inet4Address.java (isMCNodeLocal): Use

Re: [cp-patches] [RFA/JDWP] ArrayReferenceCommandSet.java

2005-07-26 Thread Aaron Luchko
Ok, I've committed this patch updated with a very minor doc fix thanks, Aaron --- /dev/null 2005-06-09 16:29:11.371620296 -0400 +++ gnu/classpath/jdwp/processor/ArrayReferenceCommandSet.java 2005-07-26 20:32:15.0 -0400 @@ -0,0 +1,178 @@ +/* ArrayReferenceCommandSet.java -- class to

Re: Implementation details of VMStackWalker

2005-07-26 Thread Tom Tromey
Andrew == Andrew Haley [EMAIL PROTECTED] writes: Andrew IMO trying to unify low-level stack walker code is unnecessary and Andrew leads to too many compromises; it's a merge too far. It would be preferable from a maintenance point of view if we could find a way to merge this. A fair number of

[commit-cp] classpath ./ChangeLog vm/reference/java/lang/VM...

2005-07-26 Thread Jeroen Frijters
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Jeroen Frijters [EMAIL PROTECTED] 05/07/26 06:46:20 Modified files: . : ChangeLog vm/reference/java/lang: VMClassLoader.java Log message: 2005-07-26 Jeroen

[commit-cp] classpath ./ChangeLog ./NEWS gnu/classpath/Conf...

2005-07-26 Thread Jeroen Frijters
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Jeroen Frijters [EMAIL PROTECTED] 05/07/26 09:10:31 Modified files: . : ChangeLog NEWS gnu/classpath : Configuration.java.in java/lang/reflect: Proxy.java

[commit-cp] classpath ./ChangeLog native/target/generic/tar...

2005-07-26 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/26 09:53:42 Modified files: . : ChangeLog native/target/generic: target_generic_network.h Log message: 2005-07-26

[commit-cp] classpath ./ChangeLog javax/swing/plaf/metal/Me...

2005-07-26 Thread David Gilbert
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 05/07/26 12:45:47 Modified files: . : ChangeLog javax/swing/plaf/metal: MetalBorders.java Log message: 2005-07-26 David

[commit-cp] classpath ./ChangeLog gnu/java/awt/AWTUtilities...

2005-07-26 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/26 13:53:34 Modified files: . : ChangeLog gnu/java/awt : AWTUtilities.java Log message: 2005-07-26 Roman Kennke

[commit-cp] classpath ./ChangeLog java/util/Properties.java

2005-07-26 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/26 14:25:37 Modified files: . : ChangeLog java/util : Properties.java Log message: 2005-07-26 Roman Kennke

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-07-26 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/26 14:16:43 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicScrollPaneUI.java

[commit-cp] classpath ./ChangeLog javax/swing/plaf/metal/Me...

2005-07-26 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/26 14:32:21 Modified files: . : ChangeLog javax/swing/plaf/metal: MetalLookAndFeel.java Log message: 2005-07-26 Roman

[commit-cp] classpath ./ChangeLog javax/swing/AbstractActio...

2005-07-26 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/26 15:30:54 Modified files: . : ChangeLog javax/swing: AbstractAction.java AbstractButton.java

[commit-cp] classpath ./ChangeLog gnu/java/awt/peer/gtk/Gtk...

2005-07-26 Thread Thomas Fitzsimmons
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/07/26 20:41:41 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: GtkComponentPeer.java Log message: 2005-07-26 Thomas

[commit-cp] classpath ./ChangeLog gnu/java/security/provide...

2005-07-26 Thread Tom Tromey
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Tom Tromey [EMAIL PROTECTED] 05/07/26 22:39:15 Modified files: . : ChangeLog gnu/java/security/provider: PKIXCertPathValidatorImpl.java Log message: *

[commit-cp] classpath ./ChangeLog javax/security/sasl/Sasl....

2005-07-26 Thread Tom Tromey
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Tom Tromey [EMAIL PROTECTED] 05/07/26 22:35:42 Modified files: . : ChangeLog javax/security/sasl: Sasl.java Log message: PR classpath/22992: *

[commit-cp] classpath ./ChangeLog java/net/Inet4Address.java

2005-07-26 Thread Tom Tromey
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Tom Tromey [EMAIL PROTECTED] 05/07/26 22:45:47 Modified files: . : ChangeLog java/net : Inet4Address.java Log message: PR classpath/22989: *