Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Hughes
- Original Message - CVSROOT: /sources/classpath Module name: classpath Changes by: Andrew Haley aph 12/03/29 09:32:34 Modified files: . : ChangeLog native/jni/java-io: java_io_VMConsole.c Log message: 2012-03-25 Gerald Pfeifer

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley
On 03/29/2012 03:52 PM, Andrew Hughes wrote: The CVS repository is obsolete. Current development takes place in git: I missed that. OK, I'll push the patch to git. We need at least to make the CVS read-only. Why are we using yet another VCS, anyway? We can pretty much guarantee that free

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Chris Burdess
Andrew Haley wrote: Why are we using yet another VCS, anyway? We can pretty much guarantee that free Java devs are used to Mercural and maybe Subversion, but git? Because nobody spoke up during the review period, so the first suggestion was accepted.

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley
On 03/29/2012 04:12 PM, Chris Burdess wrote: Because nobody spoke up during the review period, so the first suggestion was accepted. Yes, I'm sure that's the meta-reason, and I should have been paying more attention. :-( Andrew.

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Ivan Maidanski
Hi Andrew, It would be good to deprecate ChangeLog (used as commit log) as well. Regards. Thu, 29 Mar 2012 10:52:26 -0400 (EDT) Andrew Hughes ahug...@redhat.com: - Original Message - CVSROOT:/sources/classpath Module name:classpath Changes by: Andrew Haley aph

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Pekka Enberg
On Thu, Mar 29, 2012 at 6:07 PM, Andrew Haley a...@redhat.com wrote: Why are we using yet another VCS, anyway?  We can pretty much guarantee that free Java devs are used to Mercural and maybe Subversion, but git? FWIW, I voted for git because that's what I know. I have never used Mercurial for

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley
On 03/29/2012 04:58 PM, Ivan Maidanski wrote: It would be good to deprecate ChangeLog (used as commit log) as well. Why? I think this sentence is missing a because ... clause. Andrew.

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Ivan Maidanski
Hi Andrew, Thu, 29 Mar 2012 17:42:17 +0100 от Andrew Haley a...@redhat.com: On 03/29/2012 04:58 PM, Ivan Maidanski wrote: It would be good to deprecate ChangeLog (used as commit log) as well. Why? I think this sentence is missing a because ... clause. Sorry for not explaining you how does

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley
On 03/29/2012 06:19 PM, Ivan Maidanski wrote: Hi Andrew, Thu, 29 Mar 2012 17:42:17 +0100 от Andrew Haley a...@redhat.com: On 03/29/2012 04:58 PM, Ivan Maidanski wrote: It would be good to deprecate ChangeLog (used as commit log) as well. Why? I think this sentence is missing a because ...

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Ivan Maidanski
Hi Andrew, Thank you for the explanation. Thu, 29 Mar 2012 18:33:45 +0100 Andrew Haley a...@redhat.com: On 03/29/2012 06:19 PM, Ivan Maidanski wrote: Hi Andrew, Thu, 29 Mar 2012 17:42:17 +0100 от Andrew Haley a...@redhat.com: On 03/29/2012 04:58 PM, Ivan Maidanski wrote: It would be

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Hughes
- Original Message - On 03/29/2012 06:19 PM, Ivan Maidanski wrote: Hi Andrew, Thu, 29 Mar 2012 17:42:17 +0100 от Andrew Haley a...@redhat.com: On 03/29/2012 04:58 PM, Ivan Maidanski wrote: It would be good to deprecate ChangeLog (used as commit log) as well. Why? I think

Weirdness in native/jni/java-io/java_io_VMConsole.c

2012-03-29 Thread Andrew Haley
There's a very odd comment in this file: it clearly refers to some method in another file. But what was it for, anyway? Surely the name of a method and its signature is contained in the code. I'd just delete it. /* * Class: java_io_VMConsole * Method:echo * Signature: (Z)Z */

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley
On 03/29/2012 03:52 PM, Andrew Hughes wrote: The CVS repository is obsolete. Current development takes place in git: http://git.savannah.gnu.org/cgit/classpath.git See this thread: http://developer.classpath.org/pipermail/classpath/2012-March/003181.html -- zebedee:classpath $ git

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Pekka Enberg
On Thu, Mar 29, 2012 at 6:40 PM, Andrew Haley a...@redhat.com wrote: zebedee:classpath $ git push ssh://git.savannah.gnu.org/cgit/classpath.git/ fatal: '/cgit/classpath.git' does not appear to be a git repository fatal: The remote end hung up unexpectedly Any idea what git wants to do the

Re: Weirdness in native/jni/java-io/java_io_VMConsole.c

2012-03-29 Thread Pekka Enberg
On Thu, Mar 29, 2012 at 12:47 PM, Andrew Haley a...@redhat.com wrote: There's a very odd comment in this file: it clearly refers to some method in another file.  But what was it for, anyway?  Surely the name of a method and its signature is contained in the code.  I'd just delete it. /*  *

Re: [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Hughes
- Original Message - CVSROOT: /sources/classpath Module name: classpath Changes by: Andrew Haley aph 12/03/29 09:32:34 Modified files: . : ChangeLog native/jni/java-io: java_io_VMConsole.c Log message: 2012-03-25 Gerald Pfeifer