Re: New java.text implementation

2006-11-17 Thread Guilhem Lavaux
Hi Mario, As a remainder I have made in 2004 a comparison between ICU and java.text. I cannot find why I have at the time rejected a ICU binding (except it is a huge machinery for so little classes and that RuleBasedCollator must have a severe layer to adapt the rules to ICU's format). Here is th

Re: Signals, sockets and threads

2006-10-26 Thread Guilhem Lavaux
Edwin Steiner wrote: > On Wed, Oct 18, 2006 at 03:52:50PM +0200, Robert Schuster wrote: >> Hi all, > > Hi! > >> the title looks like fun, eh? :) > > Not really, if you spend some time with that stuff. ;) > >> In an attempt to get gnu/testlet/java/net/ServerSocket/ReturnOnClose to >> succeed >>

Re: switch to IPv6-only

2006-10-25 Thread Guilhem Lavaux
Robert Schuster wrote: > Hi, > some days ago I posted a question where I was wondering why the RI calls all > their network stuff with AF_INET6 even if the user explicitly wants to do > IPv4-only stuff. > > I think I found the reason and am here to ask for going the same route in GNU > Classpath.

Re: Sockets and the RI

2006-10-20 Thread Guilhem Lavaux
David Daney wrote: > Robert Schuster wrote: >> Hi, >> I still have trouble with the Sockets >> >> First I found out that certain Sockets which do not succeed in >> establishing a >> connection (a wanted scenario in the mauve test) do not get properly >> closed. I >> took some time until I foun

Re: Signals, sockets and threads

2006-10-20 Thread Guilhem Lavaux
Casey Marshall wrote: > Guilhem Lavaux wrote: >> Casey Marshall wrote: >>> Guilhem Lavaux wrote: >>>> In respect to this buggy interface, it is ok. :) >>>> >>> I fail to see why this is buggy. >>> >> Ok. >> >> 1) PO

Re: Signals, sockets and threads

2006-10-19 Thread Guilhem Lavaux
Casey Marshall wrote: > Guilhem Lavaux wrote: >> Hi Robert, >> >> You are using tmp_errno = errno... ret is precisely holding errno. I > > Nope. 'ret' contains the return value of 'accept', which is not the same > as 'errno'. > &g

Re: Signals, sockets and threads

2006-10-18 Thread Guilhem Lavaux
Hi Robert, You are using tmp_errno = errno... ret is precisely holding errno. I have built the native-lib so that we are always thread safe. I have not noticed that VMChannel is so native-lib agnostic. ;-) I will have to rewrite VMChannel... Probably next weeks will be devoted to this. In respect

Native layer

2006-06-06 Thread Guilhem Lavaux
Hi, I have a working native layer branch on jamvm (though I have not really counted if there was a regression I know the one from kaffe and the important ones in mauve are passing on standard linux). I will propose before the end of the week a patch against HEAD for a merge. I suggest people to ta

Re: Datetypes for native target layer functions

2006-03-27 Thread Guilhem Lavaux
Hi Torsten, Mark Wielaard wrote: >Hi Torsten, > >On Thu, 2004-08-19 at 10:45 +0200, Dr. Torsten Rupp wrote: > > >>I'm currently changing the target native layer to replace the macros by >>functions. >> >> > >Please take a look at the NATIVE-LAYER branch that Guilhem is working >on. He alre

Re: New native layer

2006-02-04 Thread Guilhem Lavaux
Hi Casey, Following my previous mail, please try this small performance test. It illustrates what I want to do and the performance "loss" that is expected. Simply unpack and run make. Cheers, Guilhem. Casey Marshall wrote: On Feb 2, 2006, at 10:27 AM, Guilhem Lavaux wrot

Re: New native layer

2006-02-04 Thread Guilhem Lavaux
Casey Marshall wrote: On Feb 2, 2006, at 10:27 AM, Guilhem Lavaux wrote: Casey Marshall wrote: On Jan 31, 2006, at 6:10 PM, David P Grove wrote: Jikes RVM also does m-to-n threading, so it's there's more than 1 VM that's whacky in this regard. The things we need to do are

Re: New native layer

2006-02-02 Thread Guilhem Lavaux
Casey Marshall wrote: On Jan 31, 2006, at 6:10 PM, David P Grove wrote: Jikes RVM also does m-to-n threading, so it's there's more than 1 VM that's whacky in this regard. The things we need to do are most likely different than what Kaffe needs to do, but having a chance to inject a VM call

Re: New native layer

2006-01-31 Thread Guilhem Lavaux
have been around for many years now: they don't really pay off enough for people to rewrite their existing code bases to them. Okay, but I brought it up since the work Guilhem Lavaux is doing sounds an awful lot like a rewrite. Although technically I think you can just run the macro proces

Re: New native layer

2006-01-28 Thread Guilhem Lavaux
Hi Mark, Mark Wielaard wrote: Hi Guilhem, On Sat, 2006-01-28 at 14:43 +0100, Guilhem Lavaux wrote: I would like to mention that I am developping/fine tuning the new native layer for classpath in a separate branch called "NATIVE-LAYER". If you have some time to give your impres

New native layer

2006-01-28 Thread Guilhem Lavaux
Hi classpath ! I would like to mention that I am developping/fine tuning the new native layer for classpath in a separate branch called "NATIVE-LAYER". If you have some time to give your impressions then fetch it and look into native/jni/native-lib, native/jni/java-io, ... the new layer itse

Re: Aicas again

2006-01-23 Thread Guilhem Lavaux
Hi Casey, I would have appreciated one comment relatively to my proposal for Classpath IO in December It was meeting aicas needs and ours (at kaffe). At the moment I have left Roman makes his experiments hoping that everything will stabilize afterwards. http://lists.gnu.org/archive/html/class

Re: SecurityManager troubles

2006-01-13 Thread Guilhem Lavaux
Gary Benson wrote: Guilhem Lavaux wrote: Gary Benson wrote: FWIW I was able to push IBM's JRE into an infinite loop with this test, so it would appear to be vulnerable to the same class of problems even if not this actual problem. BTW, Gary your test triggers a really nasty VerifyErr

Re: SecurityManager troubles

2006-01-12 Thread Guilhem Lavaux
Gary Benson wrote: Jeroen Frijters wrote: Guilhem Lavaux wrote: This block is the loop: at testSM$MySM.checkPermission (testSM.java:17) at java.lang.SecurityManager.checkSecurityAccess (SecurityManager.java:1011) at java.security.Security.getProperty (Security.java:396) at

Re: NIO (Non-block & Scatter/Gather)

2006-01-12 Thread Guilhem Lavaux
Archie Cobbs wrote: Robert Schuster wrote: These macros look strange to me. What do our JNI experts say? +/* FIXME: This can't be right. Need converter macros */ +#define CONVERT_JINT_TO_INT(x) ((int)(x & 0x)) +#define CONVERT_INT_TO_JINT(x) ((int)(x & 0x)) + +/* FIXME: This

Re: SecurityManager troubles

2006-01-11 Thread Guilhem Lavaux
Jeroen Frijters wrote: Gary Benson wrote: Guilhem Lavaux wrote: 3) One solution of the problem is to load some core classes. But it will appear quite soon that some other classes may also be loaded for really wicked applications. It is a limitative solution and I would not support it. Yes

SecurityManager troubles

2006-01-10 Thread Guilhem Lavaux
Hi, I have stumbled across a bug probably shared by all VMs using GNU Classpath. In Apache Ant a SecurityManager is installed to be able to execute java application without forking the VM. Thanks to the SM exiting a VM is forbidden and so ant is protected from the applications using System.ex

Replacing target layer (2)

2006-01-06 Thread Guilhem Lavaux
Hi, Ok. Here is an update of the previous patch. After some discussion that one should be compatible with AICAS' and kaffe's needs. I have slightly abstractized the syscall interfaces for file's IO. Now I provide an interface for doing jlong math and handling errors. For most architecture the

Re: Target-Native Impls

2006-01-06 Thread Guilhem Lavaux
Roman Kennke wrote: Ok. Dalibor also gave a little positive feedback on IRC. So I'll prepare this stuff and check it in after the next release, unless there comes a big NO in the meantime. Also, I am going to adjust the existing native code to actually use the target native layer where it does n

Re: Replacing target layer (2)

2006-01-06 Thread Guilhem Lavaux
(at least). All syscalls must be protected in that case. I accept to take this new target as something we can work on though... Regards, Guilhem. Guilhem Lavaux wrote: Hi, Ok. Here is an update of the previous patch. After some discussion that one should be compatible with AICAS' and k

Re: [Fwd: [cp-patches] [RFC, Concept proposal]: Easing "target" dependency]

2005-12-03 Thread Guilhem Lavaux
Hi Mark, Mark Wielaard wrote: Hi Guilhem, On Wed, 2005-11-30 at 20:31 +0100, Guilhem Lavaux wrote: So I am proposing to keep the basic skeleton of the target layer but put the real code not in macro but in real C functions. That way we will be able to add autoconf macros without

[Fwd: [cp-patches] [RFC, Concept proposal]: Easing "target" dependency]

2005-11-30 Thread Guilhem Lavaux
Hi, As I got no answer on classpath-patches I send this email to this list. Regards, Guilhem. --- Begin Message --- Hi, I would like to propose a code split to split the java interface from accessing syscalls in File IO (and generally for all native IO). Some VM may want (like us in kaffe)

Re: VM support for GetDirectBufferAddress

2005-01-06 Thread Guilhem Lavaux
commits his patch I may add its support afterward (or someone else). Regards, Guilhem Lavaux. ___ Classpath mailing list Classpath@gnu.org http://lists.gnu.org/mailman/listinfo/classpath

Re: About locale data ... (again)

2004-08-13 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi, On Thu, 2004-07-29 at 16:30, Guilhem Lavaux wrote: As we always need a good locale database for GNU Classpath, I was thinking of a way to get it. The ICU locale converter is only partially satisfying as it does not have any collation rules generator (at least). I&#x

Re: About locale data ... (again)

2004-08-13 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi, On Thu, 2004-07-29 at 16:30, Guilhem Lavaux wrote: As we always need a good locale database for GNU Classpath, I was thinking of a way to get it. The ICU locale converter is only partially satisfying as it does not have any collation rules generator (at least). I&#x

[Fwd: [kaffe] (no subject)] (jni.h)

2004-08-03 Thread Guilhem Lavaux
Hi, As it is a Classpath's file, I'm forwarding this mail here. I've added a small amount of lines for win32 at the top but it is not related. Cheers, Guilhem. --- Begin Message --- Cc; [EMAIL PROTECTED] Subject: [Jan Schulz] Bug#262760: kaffe-dev: include/jni.h misses #include to compile eclip

About locale data ... (again)

2004-07-29 Thread Guilhem Lavaux
Hi all, As we always need a good locale database for GNU Classpath, I was thinking of a way to get it. The ICU locale converter is only partially satisfying as it does not have any collation rules generator (at least). I've seen that www.openi18n.org[1][2] has begun a new standard file format t

Re: jni.h fixes

2004-07-06 Thread Guilhem Lavaux
Tom Tromey wrote: "Guilhem" == Guilhem Lavaux <[EMAIL PROTECTED]> writes: Hi Tom, Guilhem> * first, it is not compilable in C++ mode. I've fixed that by Guilhem> moving some ifdef block and adding a '}' to finish the Guilhem> 'extern

jni.h fixes

2004-07-06 Thread Guilhem Lavaux
ghtly wrong. Instead of JNIEXPORT jint JNICALL JNI_CreateJavaVM (JavaVM **, void **, void *); I'd rather put: JNIEXPORT jint JNICALL JNI_CreateJavaVM (JavaVM **, JNIEnv **, void *); I have attached a patch. Cheers, Guilhem. ChangeLog entry: 2004-07-06 Guilhem Lavaux <[EMAIL PROTECTED]>

Re: URLStreamHandler does not correcly parse filenames as URL

2004-06-14 Thread Guilhem Lavaux
Roman Kennke wrote: Original Submission: I found, that java.net.URLStreamHandler does not correctly parse filenames such as "mapping.xml" as URLs. Some applications do such things, like Castor (here I found the error). The problem is, that URLStreamHandler.parseURL looks for "/" and does not check

Patch for the collator

2004-05-29 Thread Guilhem Lavaux
w they are correctly returned by by CollationElementIterator.next() but ignored by compare(). Cheers, Guilhem. ChangeLog entry: 2004-05-29 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/RuleBasedCollator.java (CollationElement.CollationElement): Removed unused construc

java.text.DecimalFormat && SimpleDateFormat

2004-05-16 Thread Guilhem Lavaux
Hi, Here are two related fixes concerning DecimalFormat and SimpleDateFormat. Without them, dates may be wrongly parsed, especially if they are encoded like that '04082004' for '04/08/2004'. DecimalFormat should stop at the right place based on the different parameters. Cheers, Guilhem. ChangeL

java.text.RuleBasedCollator && CollationElementIterator.

2004-05-16 Thread Guilhem Lavaux
missing features (like the missing '!' and some uncertainties concerning implicit accented characters reordering). I'll commit it if nobody is against it. Cheers, Guilhem. ChangeLog entry: 2004-05-16 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/Collatio

java.text.DecimalFormat.parse() patch

2004-05-01 Thread Guilhem Lavaux
Hi, Here is a patch which fixes 3 old failures on mauve and maybe 2 or 3 new because of the updated mauve test. This fixes handling of exponentiation notation, grouping handling and better handling of Long and Double types. ChangeLog entry: 2004-05-01 Guilhem Lavaux <[EMAIL PROTEC

gnu.java.net.protocol.file.Handler again (and java.net.URL)

2004-04-23 Thread Guilhem Lavaux
all platforms now. ChangeLog entry: 2004-04-23 Guilhem Lavaux <[EMAIL PROTECTED]> * gnu/java/net/protocol/file/Handler.java (parseURL): Added a comment on ftp implementation in GNU Classpath. * java/net/URL.java (set): This method now matches the behavi

Re: gnu.java.net.protocol.file.Handler update

2004-04-23 Thread Guilhem Lavaux
On Thu, 2004-04-22 at 22:30, Michael Koch wrote: > Am Dienstag, 20. April 2004 15:37 schrieb Michael Koch: > > Am Dienstag, 20. April 2004 09:24 schrieb Guilhem Lavaux: > > > Hi, > > > > > > Apparently the special parseURL implementation in > > > gnu.j

RE: gnu.java.net.protocol.file.Handler update

2004-04-20 Thread Guilhem Lavaux
Hi, Thanks Jeroen ! If noone is against I'm checking in this changes now. Cheers, Guilhem. On Tue, 2004-04-20 at 15:32, Jeroen Frijters wrote: > Guilhem Lavaux wrote: > > Apparently the special parseURL implementation in > > gnu.java.net.protocol.file.Handler is not requi

Re: java.net.URL authority/userInfo

2004-04-20 Thread Guilhem Lavaux
Michael Koch wrote: Am Dienstag, 20. April 2004 09:19 schrieb Guilhem Lavaux: Hi, Here is a patch for URL.java and URLStreamHandler.java to implement support for authority and cleanup userInfo handling. I have updated a small testcase in mauve for authority and there does not seem to be any

Re: Http headers

2004-04-20 Thread Guilhem Lavaux
Michael Koch wrote: Am Dienstag, 20. April 2004 09:15 schrieb Guilhem Lavaux: Hi, If you try the mauve test URLConnection/Http you may notice there is failure due to an unknown header "server" which should be "Server". Apparently to make the search throught header fields

gnu.java.net.protocol.file.Handler update

2004-04-20 Thread Guilhem Lavaux
Hi, Apparently the special parseURL implementation in gnu.java.net.protocol.file.Handler is not required anymore and even broken according to mauve test gnu.testlet.java.net.URL.URLTest. If we replace it using GCJ implementation (attached) 39 failures are fixed and no regression happens. So I sugg

java.net.URL authority/userInfo

2004-04-20 Thread Guilhem Lavaux
Guilhem Lavaux <[EMAIL PROTECTED]> * java/net/URL.java (userInfo): New field. (URL): Set authority to the right value. (getContent, openStream): Made final as in the Java spec. (setURL): Fixed authority and file initialization. * ja

Http headers

2004-04-20 Thread Guilhem Lavaux
Hi, If you try the mauve test URLConnection/Http you may notice there is failure due to an unknown header "server" which should be "Server". Apparently to make the search throught header fields independent from the case we have using toLowerCase for all header keys and values: this is not right. I

java.text.Format

2004-04-11 Thread Guilhem Lavaux
Hi, Here is the latest patch (that one is really obvious) concerning java.text.Format. ChangeLog entry: 2004-04-11 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/Format.java: Updated importations. Removed unnecessary classes. Cheers, Guilhem. Index: java/text/Forma

java.text.DecimalFormat

2004-04-11 Thread Guilhem Lavaux
Hi, Here is patch to implement attributes and fixes the exponential notation. The formatting has been rebuilt to be able to construct the output string without inserting characters in the middle of the string. ChangeLog entry: 2004-04-11 Guilhem Lavaux <[EMAIL PROTECTED]>

java.text.SimpleDateFormat

2004-04-11 Thread Guilhem Lavaux
Hi, Here is patch to implement attributes in SimpleDateFormat. ChangeLog entry: 2004-11-04 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/SimpleDateFormat.java: (formatWithAttribute): New method. It implements the formatting process with attributes. (

java.text.MessageFormat

2004-04-11 Thread Guilhem Lavaux
Hi, Here is patch for java.text.MessageFormat. It adds support for MessageFormat.Field, attributed iterators, FieldPos support and adds two simple missing methods. There is also one or two documentation updates. ChangeLog entry: 2004-04-10 Guilhem Lavaux <[EMAIL PROTECTED]> * jav

Re: java.text attributes

2004-04-10 Thread Guilhem Lavaux
Sorry Guilhem, but I cant find the parts where you fix the Makefile.ams ;-) Héhé ! Actually it is partial as I don't fix the java either here. ;-) But here are the makefiles. Michael Index: java/text/Makefile.am === RCS file:

java.text attributes

2004-04-10 Thread Guilhem Lavaux
). By the way, I am moving FormatCharacterIterator.java to gnu.java.text. I know there may be some code redundancy between FormatCharacterIterator and FormatBuffers but it seems cleanest to me that way for the rest of java.text classes. ChangeLog entry: 2004-04-10 Guilhem Lavaux <[EM

Re: Comparison ICU/java.text

2004-04-10 Thread Guilhem Lavaux
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi again ! I must add that I've found it may support full locales: ICU includes a locale converter: Java to ICU and POSIX to ICU. Tom, have you received any answer from IBM ? Cheers, Guilhem. Guilhem Lavaux wrote: | | To the request of Tom Tro

Re: The Mauve unicode testcase and VM performance

2004-04-08 Thread Guilhem Lavaux
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stephen Crawley wrote: | Folks, | | I've just checked in a new version of the Mauve testcase for Unicode | character handling. This fixes previous problems that resulted in | huge numbers of test failures with the current version of Classpath. | [It tu

Re: Object serialization and final fields

2004-04-06 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi Guilhem, On Fri, 2004-04-02 at 21:52, Guilhem Lavaux wrote: Here is the real patch for object serialization. I've added new static methods to VMObjectStreamClass and changed the methods called in ObjectStreamField accordingly. Note that we need to check all excep

Re: Object serialization and final fields

2004-04-02 Thread Guilhem Lavaux
geLog entry: 2004-04-02 Guilhem Lavaux <[EMAIL PROTECTED]> * java/io/ObjectStreamField.java (setBooleanField, setCharField, setByteField, setShortField, setIntField, setLongField, setFloatField, setDoubleField): Use native methods directly to be able to set f

Comparison ICU/java.text

2004-03-30 Thread Guilhem Lavaux
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi ! To the request of Tom Tromey I have made a small comparison between ICU text and java.text. As it is MIT licenced and has a strong implementation it would have been great to be able to import classes though I don't really like to have some pure IB

Re: Object serialization and final fields

2004-03-29 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi, Hi Mark ! On Thu, 2004-03-25 at 21:19, Guilhem Lavaux wrote: Some people has reported failures in kaffe with applications trying to deserialize objects containing final fields. Apparently it is authorized in the serialization spec but we cannot rely on

Object serialization and final fields

2004-03-25 Thread Guilhem Lavaux
Hi, Some people has reported failures in kaffe with applications trying to deserialize objects containing final fields. Apparently it is authorized in the serialization spec but we cannot rely on java.lang.reflect.Field to set them. So our only solution is to bypass the protection in java.lan

[Fwd: BufferedInputStream.mark()]

2004-03-11 Thread Guilhem Lavaux
e mark() logic to be able to allocate buffers incrementally. Please review. Here is the changelog: 2004-03-06 Guilhem Lavaux <[EMAIL PROTECTED]> * libraries/javalib/java/io/BufferedInputStream.java (mark, refill) Make an incremental mark buffer allocation. New f

BufferedInputStream.mark()

2004-03-10 Thread Guilhem Lavaux
Hi, I've been trying to make azureus work with kaffe and apparently they use an hidden feature of sun's jdk: it is capable to do mark(Integer.MAX_VALUE). So I modified the mark() logic to be able to allocate buffers incrementally. Please review. Here is the changelog: 2004-03-0

Re: Object serialization patch

2004-02-24 Thread Guilhem Lavaux
Jeroen Frijters wrote: Guilhem Lavaux wrote: Yes, I'm also not completely satisfied with this method. But there exists cases where it is needed. For example, if serialPersistentFields declares class types wrongly. The types are not checked previously in that case and this results

Re: Object serialization patch

2004-02-23 Thread Guilhem Lavaux
Jeroen Frijters wrote: Hi, Here is a new patch I propose. I've taken the suggestion into account and fix another small error reporting problem. I don't understand checkTypeConsistency, it looks odd and I'm having a hard time believing that it is correct. BTW, Shouldn't "nonPrimitive" be named

Re: Object serialization patch

2004-02-23 Thread Guilhem Lavaux
Hi, Here is a new patch I propose. I've taken the suggestion into account and fix another small error reporting problem. New changelog entry: 2004-02-23 Guilhem Lavaux <[EMAIL PROTECTED]> * libraries/javalib/java/io/ObjectInputStream.java (readClassDescrip

Re: Object serialization patch

2004-02-23 Thread Guilhem Lavaux
Jeroen Frijters wrote: Hi, Thanks for the patch. I have one question. int comp_val = - real_fields[real_idx].compareTo (stream_fields[stream_idx]); + real_fields[real_idx].getName().compareTo (stream_fields[stream_idx].getName()); By my reading of the spec, primitive fie

FYI: gnu.java.net.protocol.http.Connection

2003-12-27 Thread Guilhem Lavaux
03-12-27 Guilhem Lavaux <[EMAIL PROTECTED]> + * gnu/java/net/protocol/http/Connection.java + (receiveReply): Add the null header containing the reply of the server. + (getHeaderField, getHeaderFieldKey): Check whether the connection has + already been established. +

Re: [PATCH] ServerSocket.bind

2003-12-26 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi Michael, On Thu, 2003-12-25 at 18:34, Michael Koch wrote: After talking with guilhem on irc I got the problem and wrote the attached patch. I commited it to trunk already. Mark: Can you please commit this to classpath ? Now that you have commit access to classpath

[PATCH] ServerSocket.bind

2003-12-24 Thread Guilhem Lavaux
Hi, It seems that nobody checks for null internet address in ServerSocket.bind. Here is a quick fix which should prevent calling a native method with a null address argument. Regards, Guilhem. ChangeLog: 2003-12-24 Guilhem Lavaux <[EMAIL PROTECTED]> * java/net/ServerSocket.java

Re: [PATCH] RuleBasedCollator

2003-12-20 Thread Guilhem Lavaux
Tom Tromey wrote: "Guilhem" == Guilhem Lavaux <[EMAIL PROTECTED]> writes: Guilhem> Please review. I read through this. The code looks fine to me, based on what I remember of RuleBasedCollator. I'm glad to see that someone is paying attention to java.tex

Re: [PATCH] RuleBasedCollator

2003-12-18 Thread Guilhem Lavaux
Tom Tromey wrote: "Guilhem" == Guilhem Lavaux <[EMAIL PROTECTED]> writes: Guilhem> Please review. I read through this. The code looks fine to me, based on what I remember of RuleBasedCollator. I'm glad to see that someone is paying attention to java.tex

[PATCH] Serialization #6 (and final)

2003-12-07 Thread Guilhem Lavaux
. If transient we have to make it return a default value, if not we try to get it in the pool of read fields. If the field doesn't exist we should throw an exception. ChangeLog entry: 2003-12-07 Guilhem Lavaux <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java:

Re: [PATCH] Serialization #5

2003-12-07 Thread Guilhem Lavaux
Brian Jones wrote: Guilhem Lavaux <[EMAIL PROTECTED]> writes: Dalibor Topic wrote: Salut Guilhem, @@ -442,18 +443,46 @@ String field_name = this.realInputStream.readUTF (); dumpElementln (field_name); String class_name; - + +// There're man

Re: [PATCH] Serialization #5

2003-12-03 Thread Guilhem Lavaux
Dalibor Topic wrote: Salut Guilhem, @@ -442,18 +443,46 @@ String field_name = this.realInputStream.readUTF (); dumpElementln (field_name); String class_name; - + +// There're many cases you can't get java.lang.Class from +// typename if your context class loader

[PATCH] Serialization #5

2003-12-02 Thread Guilhem Lavaux
stream) are of the required types. * if getOffset() < 0 then readFields() should not try to read any field from the input stream. Cheers, Guilhem. ChangeLog entry: 2003-12-02 Guilhem Lavaux <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java: (getField): Handle transien

[PATCH] Serialization #4

2003-11-27 Thread Guilhem Lavaux
but changing but this is mainly due to the change in the class lookup logic. Cheers, Guilhem. P.S.: Modifications concerning ObjectOutputStream will follow after all modifications about ObjectInputStream. ChangeLog entry: 2003-11-27 Guilhem Lavaux <[EMAIL PROTECTED]> * java/io/Obj

Re: [PATCH] Serialization #2 (set field methods)

2003-11-26 Thread Guilhem Lavaux
Sorry. Here is the patch. Guilhem. Index: java/io/ObjectInputStream.java === RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v retrieving revision 1.32 diff -u -r1.32 ObjectInputStream.java --- java/io/ObjectInpu

[PATCH] Serialization #3

2003-11-26 Thread Guilhem Lavaux
ath's. I will add the documentation on time. But you may understand that it's a nightmare to separate all portions of code as they've been written in one pass. BTW, I will also build some additionnal Mauve tests to import kaffe's tests. Cheers, Guilhem. ChangeLog: 2003-26-1

[PATCH] Serialization #2 (set field methods)

2003-11-26 Thread Guilhem Lavaux
this patch ? I would think they are straightforward to understand... In the other case I'll try to write something. ChangeLog: 2003-26-11 Guilhem Lavaux <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java: (setBooleanField) Throw an InvalidClassException if the

[PATCH] Pre-submit for serialization

2003-11-26 Thread Guilhem Lavaux
h the previous API. This change was originally submitted/suggested by Helmer Kraemer to fix something in the modified serializer. Cheers, Guilhem. ChangeLog: 2003-11-26 Guilhem Lavaux <[EMAIL PROTECTED]>, Helmer Kraemer <[EMAIL PROTECTED]> * gnu/java/lang/reflect/T

Re: [PATCH] Compliance of DecimalFormatSymbols

2003-11-22 Thread Guilhem Lavaux
Mark Wielaard wrote: At your service! - ChangeLog entries should start with: date Name email. - Just between filename and (field/method) - Entries are full sentences with starting capital and ending dot. 2003-11-21 Guilhem Lavaux <[EMAIL PROTECTED]> * jav

Re: [PATCH] Two methods for NumberFormat

2003-11-22 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi Guilhem, On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote: I am continuing the series of patches with that one, it adds two methods to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). They have to be implemented according to Java 1.4. Thanks

[PATCH] Two methods for NumberFormat

2003-11-21 Thread Guilhem Lavaux
Hi, I am continuing the series of patches with that one, it adds two methods to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). They have to be implemented according to Java 1.4. Please review it before I check it in. Regards, Guilhem. Index: java/text/NumberFormat.java

[PATCH] NumberFormat

2003-11-21 Thread Guilhem Lavaux
Hi, Here is just a patch to review about NumberFormat.Field before I check it in. It implements java.text.NumberFormat.Field it is quite straightforward using the documentation. Regards, Guilhem. ChangeLog entry: 2003-11-21 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/NumberForma

[PATCH] Compliance of DecimalFormatSymbols

2003-11-21 Thread Guilhem Lavaux
. ChangeLog entry: 2003-11-21 Guilhem Lavaux <[EMAIL PROTECTED]> * java/text/DecimalFormatSymbols.java(locale): New field. (serialVersionOnStream): Upgraded to number 2 (readObject): updated to assign locale if it wasn't by the serializer. Index: java/text/DecimalFormatS

Re: [PATCH] attributed string fixes

2003-11-19 Thread Guilhem Lavaux
Mark Wielaard wrote: Hi, On Wed, 2003-11-19 at 16:03, Dalibor Topic wrote: graydon hoare wrote: 2003-11-18 Graydon Hoare <[EMAIL PROTECTED]> * java/text/AttributedString.java: Fix arithmetic. * java/text/AttributedStringIterator.java: Likewise. PLease take a look at Guilhem's

Re: java.io.DataInputStream.readLine misbehaviour

2003-11-02 Thread Guilhem Lavaux
Mark Wielaard wrote: OK. Let me try to summarize the behavior we want so we can at least create some good tests: DataInputStream.readLine(): - Should not block when it has seen at least a \r but return as soon as possible even when it cannot be sure that the next character is or isn't a \n to pr

java.io.DataInputStream.readLine misbehaviour

2003-10-31 Thread Guilhem Lavaux
Hi, Continuing the Classpath-Kaffe merge, I noticed that DataInputStream is failing one of kaffe's regression test (InputStreamTest). It seems the failure comes from readLine(): readLine() is a little too conservative compared to JDK's implementation. The real behaviour seems to be the follow

URL's fix

2003-10-29 Thread Guilhem Lavaux
ng.Error. This is the only solution to be able to report errors. Here is the corresponding ChangeLog entry: 2003-10-29 Guilhem Lavaux <[EMAIL PROTECTED]> * gnu/java/net/URLParseError.java: New error class. * gnu/java/net/protocol/jar/Handler.java: (parseUrl) Fixed error

Re: Modular InetAddress

2003-10-27 Thread Guilhem Lavaux
Bryce McKinlay wrote: On Oct 26, 2003, at 10:31 PM, Guilhem Lavaux wrote: here is a quick patch to be able to have a modular getHostByName and a getHostByAddr. To change implementation the user has just to provide a property gnu.java.net.dns containing the full class name of an implementation

Modular InetAddress

2003-10-26 Thread Guilhem Lavaux
light overhead when solving because I don't use static method anymore for getHostByName and getHostByAddr. Cheers, Guilhem. P.S.: This is against classpath 2003-10-26. ChangeLog entry: 2003-10-26 Guilhem Lavaux <[EMAIL PROTECTED]> * java/net/InetAddress.java: () check the

Re: Implementing java.text

2003-10-18 Thread Guilhem Lavaux
Dalibor Topic wrote: > Hi Michael, hi Guilhem, Hi Dalibor, (always here but a lot busy ;) ) > > while trying to merge in the latest improvements in Classpath, I noticed that Michael started reformatting java.text, and fixing some problems on his own. Which is a great thing, but leaves me with

Re: Modular DNS resolution

2003-10-10 Thread Guilhem Lavaux
Hi, It seems that the best I can do is to prepare something to put in gnu.java.net and build a calling system compatible with dnsJava (for instance). I hope to have something done for the next week ... Cheers, Guilhem. ___ Classpath mailing list [EM

Modular DNS resolution

2003-10-05 Thread Guilhem Lavaux
Hi ! I would like to introduce in classpath a concept which used to be in kaffe but was recently removed because of the merging with classes from classpath: DNS solver modularity. Previously it was possible to specify to kaffe (using -Ddns.resolve=class or something like this). That used to gi

RFC on patch [bug #4968]

2003-09-28 Thread Guilhem Lavaux
Hi, I know that I don't write that much ChangeLog ... but could someone can have a look at http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4968&group_id=85 and tell me if it sees something against comitting it in the repository. I would like to speed up the process of merging between Kaffe

Re: FYI: Patch: java.text.SimpleDateFormat

2003-09-28 Thread Guilhem Lavaux
Bryce McKinlay wrote: On Sunday, Sep 28, 2003, at 11:04 Pacific/Auckland, Mark Wielaard wrote: Hi, On Sat, 2003-09-27 at 22:21, Bryce McKinlay wrote: Can you give me a pointer to the failing mauve test? Without the patch the following four mauve tests fail: FAIL: gnu.testlet.java.text.SimpleD

Re: Locale collation rules

2003-08-23 Thread Guilhem Lavaux
Tom Tromey wrote: "Guilhem" == Guilhem Lavaux <[EMAIL PROTECTED]> writes: Guilhem> Is it legally possible to get the rules returned by sun jdk's Guilhem> RuseBasedCollator.getRules() as it was done in Mauve ? We would have to have RMS ask the FSF lawyer ab

Locale collation rules

2003-08-22 Thread Guilhem Lavaux
Hi, I have posted to Mark and to Classpath bug database a patch to implement some major parts of RuleBasedCollator. It is now possible to interpret at least some locale collation rules. Is it legally possible to get the rules returned by sun jdk's RuseBasedCollator.getRules() as it was done in M

Serialization

2003-08-14 Thread Guilhem Lavaux
Hi, I nearly managed to get Classpath's serialization up to kaffe's level and at the same time keeping the advantage of it. However, it is "nearly". As I said to Mark Wielaard, kaffe's regression tests TestSerialVersions.Test0007, Test0009, Test0010, Test0011, Test0013 fails; but also TestSerial

Class loader and serialization

2003-08-14 Thread Guilhem Lavaux
Hi, it seems there is a misunderstanding problem between kaffe's class loader mechanism and classpath's serialization. Here is the current state: * ObjectInputStream builds class decriptors from input stream, or if it is not described build them from classes directly. To do so it resolves classes

Re: Class loader and serialization

2003-08-14 Thread Guilhem Lavaux
Hi, Thanks to Mark I have found a compatible way to do what I want with the SecurityManager. I am going to see if it works in real world now. Thanks Mark ! ;) Cheers, Guilhem. ___ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/

  1   2   >