Re: [PATCH] swing frame fixes

2003-11-28 Thread Sascha Brawer
Hi Graydon, >ok, I've attached a testcase for mauve which gives JLayeredPane class >(also attached) a good workout; I tested this on sun's jdk and my own >code, and picked a bunch of bugs out of both the test and my own code >as a result. Yeah, this happens to me, too: First I think that the code

Re: Mauve tests [was: Re: [PATCH] swing frame fixes]

2003-11-19 Thread Tom Tromey
> "Arnaud" == Arnaud Vandyck <[EMAIL PROTECTED]> writes: Arnaud> I'd like to know where are the mauve tests? ./test? ./testsuite? http://sources.redhat.com/mauve/ Arnaud> And maybe how can I write a mauve test for a awt or swing Arnaud> class? For AWT, I know Tom Fitzsimmons put the Acunia

Mauve tests [was: Re: [PATCH] swing frame fixes]

2003-11-19 Thread Arnaud Vandyck
On Wed, 19 Nov 2003 17:04:32 +0100 Sascha Brawer <[EMAIL PROTECTED]> wrote: > Do you have any Mauve test code for your class? This question may sound > malicious, but I really think that we all should writing more test cases. > (This includes myself, I finally should clean up my test suite for > j

Re: [PATCH] swing frame fixes

2003-11-19 Thread Arnaud Vandyck
On Wed, 19 Nov 2003 17:16:40 +0100 Michael Koch <[EMAIL PROTECTED]> wrote: > Why adding stupid ? Doesnt javadoc/gcjdoc add them automatically ? > If javadoc does and gcjdoc doesnt we should fix the bug in gcjdoc and > not use workarounds. I don't remember javadoc does that. But as javadoc is in

Re: [PATCH] swing frame fixes

2003-11-19 Thread Michael Koch
On Wed, Nov 19, 2003 at 05:04:32PM +0100, Sascha Brawer wrote: > Hi Graydon, > > >this patch implements JLayeredPane and makes some minor adjustments to > >JFrame and JRootPane. > > Thanks for having written some documentation for the class! Just a > suggestion: Please separate paragraphs by tag

Re: [PATCH] swing frame fixes

2003-11-19 Thread Sascha Brawer
Hi Graydon, >this patch implements JLayeredPane and makes some minor adjustments to >JFrame and JRootPane. Thanks for having written some documentation for the class! Just a suggestion: Please separate paragraphs by tags. Also, it IMHO would be better to describe attributes like "position" with

Re: [PATCH] swing frame fixes

2003-11-18 Thread Tom Tromey
> "graydon" == graydon hoare <[EMAIL PROTECTED]> writes: graydon> 2003-11-18 Graydon Hoare <[EMAIL PROTECTED]> graydon>* javax/swing/JLayeredPane.java: Implement. graydon>* javax/swing/JFrame.java (getContentPane): Make public graydon>* javax/swing/javax/swing/JRootPa

[PATCH] swing frame fixes

2003-11-18 Thread graydon hoare
hi, this patch implements JLayeredPane and makes some minor adjustments to JFrame and JRootPane. -graydon 2003-11-18 Graydon Hoare <[EMAIL PROTECTED]> * javax/swing/JLayeredPane.java: Implement. * javax/swing/JFrame.java (getContentPane): Make public * javax/swing/java