Re: java.io.File and its native methods

2004-04-25 Thread Etienne Gagnon
Mark Wielaard wrote: Starting your review with "This makes no sense whatsoever" and then not giving any suggestion what you would like to see changed or how isn't helpful. This is false. I did provide a clear indication of the solution. I cite the relevant part of my message: Begin

Re: java.io.File and its native methods

2004-04-25 Thread Mark Wielaard
Hi, On Sat, 2004-04-24 at 14:41, Etienne Gagnon wrote: > To classpath maintainers: If you want to separate all native calls to Native* > classes, I don't care, but please do not mix the VM* interface and the > Native* interface. They are semantically quite different things. I am suprized > that

RE: java.io.File and its native methods

2004-04-25 Thread Mark Wielaard
Hi, On Sat, 2004-04-24 at 20:57, Jeroen Frijters wrote: > Michael Koch wrote: > > Here is another update. > > Many thanks! Looks great. As far as I'm concerned, please commit. I agree that this looks nice. It is good to see that every VM/Platform specific method takes a path as argument. I had t

RE: java.io.File and its native methods

2004-04-24 Thread Jeroen Frijters
Michael Koch wrote: > Here is another update. Many thanks! Looks great. As far as I'm concerned, please commit. Regards, Jeroen ___ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath

Re: java.io.File and its native methods

2004-04-24 Thread Archie Cobbs
Etienne Gagnon wrote: > > I'm not sure what the precise naming semantics are, maybe it would make > > sense to have interface that must be implemented by a VM into VM* > > classes, and classes that can be implemented natively in a different > > fashion in their own Platform* or Native* namespace

Re: java.io.File and its native methods

2004-04-24 Thread Etienne Gagnon
Dalibor Topic wrote: I'm not sure what the precise naming semantics are, maybe it would make sense to have interface that must be implemented by a VM into VM* classes, and classes that can be implemented natively in a different fashion in their own Platform* or Native* namespace. I'd prefer Nati

Re: java.io.File and its native methods

2004-04-24 Thread Dalibor Topic
Hi Mark, hallo Michael, salut Etienne, Mark Wielaard wrote: Hi Etienne, On Sat, 2004-04-24 at 08:54, Michael Koch wrote: Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon: This makes no sense whatsoever. File is NOT VM-specific in any way. VM*.java should be reserved for the VM interfac

Re: java.io.File and its native methods

2004-04-24 Thread Michael Koch
Am Samstag, 24. April 2004 12:15 schrieb Jeroen Frijters: > Michael Koch wrote: > > Here is an updated patch. It uses PlatformFile insteam of VMFile > > and moved add the things you request to it too. > > Thanks. However, I think isHidden should pass the entire path instead > of just the name. Othe

RE: java.io.File and its native methods

2004-04-24 Thread Jeroen Frijters
Michael Koch wrote: > Here is an updated patch. It uses PlatformFile insteam of VMFile and > moved add the things you request to it too. Thanks. However, I think isHidden should pass the entire path instead of just the name. Otherwise it still won't be possible to call a native method that figure

Re: java.io.File and its native methods

2004-04-24 Thread Mark Wielaard
Hi Etienne, On Sat, 2004-04-24 at 08:54, Michael Koch wrote: > Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon: > > This makes no sense whatsoever. File is NOT VM-specific in any way. > > > > VM*.java should be reserved for the VM interface only. > > The idea is to get native methods out

RE: java.io.File and its native methods

2004-04-24 Thread Jeroen Frijters
Michael Koch wrote: > I started to do some GNU classpath/VM separation work. I decided to > split the native methods of java.io.File into its own VM class called > java.io.VMFile. The refactoring worked really smooth and so I provide > here the patch for discussion. I have one minor nitpick myse

Re: java.io.File and its native methods

2004-04-24 Thread Michael Koch
Am Samstag, 24. April 2004 07:47 schrieb Ewout Prangsma: > Hi Michael, > > I think it is really good news that natives are moved to VM specific > classes. > > Great! Thanks, Michael ___ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/ma

Re: java.io.File and its native methods

2004-04-24 Thread Michael Koch
Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon: > This makes no sense whatsoever. File is NOT VM-specific in any way. > > VM*.java should be reserved for the VM interface only. The idea is to get native methods out of normal classes to make it possible for some JVMs to use GNU classpath

Re: java.io.File and its native methods

2004-04-23 Thread Ewout Prangsma
Hi Michael, I think it is really good news that natives are moved to VM specific classes. Great! Ewout - Original Message - From: "Michael Koch" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Friday, April 23, 2004 10:07 PM Subject: java.io.File and its nati

Re: java.io.File and its native methods

2004-04-23 Thread Etienne Gagnon
This makes no sense whatsoever. File is NOT VM-specific in any way. VM*.java should be reserved for the VM interface only. Etienne Michael Koch wrote: Hi list, I started to do some GNU classpath/VM separation work. I decided to split the native methods of java.io.File into its own VM class ca