[cp-patches] FYI: A single value CORBA 1.4 interfaces.

2005-06-17 Thread Meskauskas Audrius
2005-06-07 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/PortableServer/ID_ASSIGNMENT_POLICY_ID.java, org/omg/PortableServer/ID_UNIQUENESS_POLICY_ID.java, org/omg/PortableServer/IMPLICIT_ACTIVATION_POLICY_ID.java, org/omg/PortableServer/LIFESPAN_POLICY_ID.java, org/omg/PortableServer/REQU

Re: [cp-patches] [RFA/JDWP] ReferenceKey

2005-06-17 Thread Keith Seitz
On Fri, 2005-06-17 at 13:19 -0700, Keith Seitz wrote: > > - Could java.util.WeakHashMap be used instead of writing your own? > >See java.lang.VMString.intern() for an example. > > Yeah, that's a good question. Originally, I wrote this thing using a > Hashtable and SoftReferences, and the table

Re: [cp-patches] [RFA/JDWP] ReferenceKey

2005-06-17 Thread Keith Seitz
On Fri, 2005-06-17 at 14:47 -0500, Archie Cobbs wrote: > Coupla questions. Disclaimer: I haven't really been paying attention, > so ignore me if these are stupid irrelevant.. Nothing is irrelevant: I'm a Java newbie. > - Could java.util.WeakHashMap be used instead of writing your own? >See ja

Re: [cp-patches] [RFA/JDWP] ReferenceKey

2005-06-17 Thread Archie Cobbs
Keith Seitz wrote: Okay, here'e where the weirdness starts. The ID manager (not yet submitted) keeps a table which map objects to IDs. This is used to quickly lookup Objects to see if they have an ID associated with them already. The ReferenceKey class is a SoftReference class with some logic to

[cp-patches] Patch: FYI: detect -encoding option for jikes

2005-06-17 Thread Tom Tromey
As noted a while ago, jikes does not have a '-encoding' option on Windows. This patch fixes the build so that we only use this option where it is available. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * lib/Makefile.am (JAVAC): Use JIKESENCODING. * m4/acinclude.m4

[cp-patches] [RFA/JDWP] ReferenceKey

2005-06-17 Thread Keith Seitz
Hi, Okay, here'e where the weirdness starts. The ID manager (not yet submitted) keeps a table which map objects to IDs. This is used to quickly lookup Objects to see if they have an ID associated with them already. The ReferenceKey class is a SoftReference class with some logic to allow the ID ma

[cp-patches] Re: [RFA/JDWP] ReferenceKey

2005-06-17 Thread Keith Seitz
On Fri, 2005-06-17 at 12:25 -0700, Keith Seitz wrote: > ChangeLog > 2005-06-17 Keith Seitz <[EMAIL PROTECTED]> > > * gnu/classpath/jdwp/id/ReferenceKey.java: New file. Geez. I did it again... Patch is attached this time. Really. It is. I promise. Keith Index: gnu/classpath/jdwp/id/Re

[cp-patches] Patch: #13419 JOptionPane.showInputDialog multi-line

2005-06-17 Thread Anthony Balkissoon
This patch fixes bug #13419 concerning JOptionPane not showing multi-line messages. Patch is attached. 2005-06-17 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/SwingUtilities.java: (layoutCompoundLabel): Added check for multi-line text. -Tony Index: javax/swing/SwingUti

[cp-patches] Re: [RFA/JDWP] Exceptions

2005-06-17 Thread Keith Seitz
On Fri, 2005-06-17 at 08:29 -0600, Tom Tromey wrote: > > "Keith" == Keith Seitz <[EMAIL PROTECTED]> writes: > > Keith> Okay, this is another mean-spirited patch. It contains a bunch of > Keith> exception types used by the JDWP back-end. Sadly, it does not contain > Keith> all of them -- JDWP d

[cp-patches] Patch: view in JScrollPane

2005-06-17 Thread Lillian Angel
I fixed the Patch in this attachment to not include the ChangeLog. Sorry about that. 2005-06-17 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JScrollPane.java (JScrollPane): Viewport was not being set when the view was null. Whenever a view would be added to container

[cp-patches] Re: [RFA/JDWP] Exceptions

2005-06-17 Thread Tom Tromey
> "Keith" == Keith Seitz <[EMAIL PROTECTED]> writes: Keith> Okay, this is another mean-spirited patch. It contains a bunch of Keith> exception types used by the JDWP back-end. Sadly, it does not contain Keith> all of them -- JDWP defines new errors for every little thing. The rest Keith> will

[cp-patches] view in JScrollPane

2005-06-17 Thread Lillian Angel
With the new changes to JScrollPane, the view would not appear because the viewport view was never initialized. I fixed this. 2005-06-17 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JScrollPane.java (JScrollPane): Viewport was not being set when the view was null. Whe

Re: [cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-17 Thread Lillian Angel
On Fri, 2005-06-17 at 08:17 -0600, Tom Tromey wrote: > > "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: > > A small formatting nit ... > > Lillian> +if (p instanceof JScrollPane && !vd.equals( new > Dimension() )) > Lillian> +( (JScrollPane) p ).setPre

Re: [cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-17 Thread Tom Tromey
> "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: A small formatting nit ... Lillian> + if (p instanceof JScrollPane && !vd.equals( new Dimension() )) Lillian> + ( (JScrollPane) p ).setPreferredSize( vd ); The spaces are in the wrong places here. Should be:

Re: [cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-17 Thread Lillian Angel
On Fri, 2005-06-17 at 12:28 +0200, Roman Kennke wrote: > Hi Lillian, > > Lillian Angel wrote: > > >I fixed these 2 bugs. Attached is a patch file. > > > > > > >--- javax/swing/JViewport.java 27 May 2005 21:12:46 - 1.20 > >+++ javax/swing/JViewport.java 16 Jun 2005 16:56:53

[cp-patches] [generics] RFC: VM interface changes

2005-06-17 Thread Jeroen Frijters
Hi, Here is the first part of my proposed VM interface changes to make the VM interface more compatible with HEAD. Please comment. Regards, Jeroen Index: java/lang/Class.java === RCS file: /cvsroot/classpath/classpath/java/lang/Clas

[cp-patches] [generics] FYI: java/util/TreeMap.java & java/lang/ThreadLocal.java compilation fixes

2005-06-17 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-06-17 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ThreadLocal.java, java/util/TreeMap.java: Fixes to make compiling with Eclipse Java Compiler SVN HEAD possible. Index: java/lang/ThreadLocal.java

Re: [cp-patches] Patch: adding to top-level containers

2005-06-17 Thread Roman Kennke
Hi, this is cool, thank you. Generally I would prefer to go for 1.4 compatibility and completeness first, and add 1.5 stuff later, but in this case it really does not hurt. Again, some suggestions: - comments should have the following form: /** * Sentence start with capital letter and end wi

Re: [cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-17 Thread Roman Kennke
Hi Lillian, Lillian Angel wrote: I fixed these 2 bugs. Attached is a patch file. --- javax/swing/JViewport.java 27 May 2005 21:12:46 - 1.20 +++ javax/swing/JViewport.java 16 Jun 2005 16:56:53 - @@ -344,6 +344,12 @@ viewListener = createViewListener(); v.ad

Re: [cp-patches] Patch: NullPointerException in ToolTipManger #11538

2005-06-17 Thread Roman Kennke
Hi Lillian, This simple patch fixes the NullPointerException in the function mousePressed in ToolTipManager. Attached is the patch. 2005-06-15 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/ToolTipManager.java Fixed Bug #11538. (mousePressed): check if currentCompone

Re: [cp-patches] Patch: JList multiple selection and keyboard selection

2005-06-17 Thread Roman Kennke
Hi Tony, This is a more comprehensive patch than the last one I sent, it should be used instead. Allows for multiple selection in JLists as well as selection/navigation of the JList using the keyboard. This patch looks very good to me. The only little thing I changed before committing it is

Re: [cp-patches] FYI: Fixlet for DataInputStream.readLine

2005-06-17 Thread Roman Kennke
Jeroen> I don't know how others feel about this, but I would be more Jeroen> comfortable if you took it out. Done. 2005-06-17 Roman Kennke <[EMAIL PROTECTED]> * java/io/DataInputStream.java: Reverted my patch from 2005-06-15. /Roman Index: java/io/DataInputStream.java ==