[cp-patches] Patch: #13420 JInternalFrame default close operation

2005-06-21 Thread Anthony Balkissoon
This patch properly fixes JInternalFrame, JDialog, and JFrame accepting invalid defaultCloseOperations. As per 1.5, JFrame throws an invalid argument error, but the other two allow (and store) the invalid operator and default to DO_NOTHING_ON_CLOSE (tested against reference implementation). This

Re: [cp-patches] [RFA/JDWP] IdManager

2005-06-21 Thread Keith Seitz
On Tue, 2005-06-21 at 14:08 -0500, Archie Cobbs wrote: > You're definition of "type" then is the static (compile time type). > But in Java Class objects are associated with runtime types, > not compile time types. I've been confused about this before and > went so far as to document it so I wouldn

Re: [cp-patches] [RFA/JDWP] IdManager

2005-06-21 Thread Archie Cobbs
Keith Seitz wrote: "Uniquely identifies a reference type in the target VM. It should not be assumed that for a particular class, the classObjectID and the referenceTypeID are the same. A particular reference type will be identified by exactly one ID in JDWP commands and replies throughout its lif

Re: [cp-patches] [RFA/JDWP] ReferenceKey

2005-06-21 Thread Keith Seitz
On Mon, 2005-06-20 at 09:04 -0600, Tom Tromey wrote: > > "Keith" == Keith Seitz <[EMAIL PROTECTED]> writes: > > Keith> Unfortunately, with the WeakHashMap, there is no way to get the keys > put > Keith> into a ReferenceQueue (that I can see at least). Consequently, I'll > Keith> never know wh

Re: [cp-patches] [RFA/JDWP] IdManager

2005-06-21 Thread Keith Seitz
On Mon, 2005-06-20 at 13:48 -0500, Archie Cobbs wrote: > > "Uniquely identifies a reference type in the target VM. It should not be > > assumed that for a particular class, the classObjectID and the > > referenceTypeID are the same. A particular reference type will be > > identified by exactly one

[cp-patches] FYI: New 1.4 CORBA classes.

2005-06-21 Thread Meskauskas Audrius
2005-06-21 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/IOP/Encoding.java, org/omg/IOP/IOR.java, org/omg/IOP/IORHelper.java, org/omg/IOP/IORHolder.java, org/omg/IOP/TaggedProfileHolder.java, org/omg/IOP/TaggedProfile.java, org/omg/IOP/TaggedProfileHelper.java, org/omg/IOP/TaggedComponentHol

Re: [cp-patches] Patch: #13460 Incorrect logic in java.util.logging.Logger

2005-06-21 Thread Tom Tromey
> "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: Lillian> 2005-06-20 Lillian Angel <[EMAIL PROTECTED]> Lillian> * java/util/loggin.Logger Lillian>(setParent): No lines after throwing an exception are executed Lillian>and there is no point to check if the parent is nu

[cp-patches] FYI: #13460 Incorrect logic in java.util.logging.Logger

2005-06-21 Thread Lillian Angel
Incorrect Logic. committed 2005-06-21 Lillian Angel <[EMAIL PROTECTED]> * java/util/loggin.Logger (setParent): No lines after throwing an exception are executed and there is no point to check if the parent is null, because a NullPointerException would have been thrown

[cp-patches] FYI: Null check after dereference in gnu.xml.aelfred2.XmlParser

2005-06-21 Thread Lillian Angel
Damage Prevention. Prevents a NullPointerException 2005-06-21 Lillian Angel <[EMAIL PROTECTED]> * gnu/xml/aelfred2/XmlParser (parseAttribute): if (type.equals("CDATA") || type == null) this would always throw a NullPointerException if type is null. fixes bug #13458 Committed!

[cp-patches] FYI:Fixing CORBA senmatic warnings.

2005-06-21 Thread Meskauskas Audrius
Three senmatic warnings in "classpath daily snapshot 20050621 (Michael Koch):" are related to CORBA implementation. These compile (the shapshot failed due other reason) and have no effect on functionality, but they can also be fixed. 2005-06-21 Audrius Meskauskas <[EMAIL PROTE

[cp-patches] FY:Replaced spaces by tabs in ChangeLog

2005-06-21 Thread Meskauskas Audrius
I replaced spaces by tabs in the recent ChangeLog entries. No record is written in ChangeLog as this would lead to the infinite recursion :). Audrius ChangeLog.patch Description: Binary data ___ Classpath-patches mailing list Classpath-patches@gnu.or

Re: [cp-patches] FYI: Null check after dereference in javax.swing.DefaultDesktopManager

2005-06-21 Thread Mark Wielaard
Hi Lilian, On Mon, 2005-06-20 at 16:57 -0400, Lillian Angel wrote: > 2005-06-20 Lillian Angel <[EMAIL PROTECTED]> > > * javax/swing/DefaultDesktopManager > (getBoundsForIconOf): No reason to check if desktopPane > is null after dereferencing desktopPane in code. >

[cp-patches] Some ChangeLog cleanups

2005-06-21 Thread Mark Wielaard
Hi, Please follow the ChangeLog guidelines at: http://www.gnu.org/software/classpath/docs/hacking.html#SEC9 This patch cleans up some of the new entries to follow these guidelines. In particular it makes sure lines start with a tab and that there are 2 spaces between the elements of the ChangeLog

[cp-patches] FYI: Current and CurrentOperations documentation update.

2005-06-21 Thread Meskauskas Audrius
2005-06-21 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/CORBA/Current.java, org/omg/CORBA/CurrentOperations.java: Documentation update. current_doc.patch Description: Binary data ___ Classpath-patches mailing list Classpath-patches@gnu.org htt

[cp-patches] FYI: Helper and holder for CORBA Current.

2005-06-21 Thread Meskauskas Audrius
2005-06-21 Audrius Meskauskas <[EMAIL PROTECTED]> * org/omg/CORBA/CurrentHelper.java, org/omg/CORBA/CurrentHolder.java: New files./* CurrentHolder.java -- Copyright (C) 2005 Free Software Foundation, Inc. This file is part of GNU Classpath. GNU Classpath is free software; you can redistrib