[cp-patches] RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Christian Schlichtherle
Hi everyone, the changes from int to long are required as to the ZIP file format specification available online from PKZIP Inc. The specification says that all integers are 4 byte unsigned integers. Java's int type is 4 byte signed, thus the type long is required to hold a ZIP file integer. You

[cp-patches] FYI: getPropertyPrefix() in UI delegates

2005-08-31 Thread David Gilbert
I committed this patch to tidy up the getPropertyPrefix() methods in the UI delegates for the Basic look and feel. Sun's implementation is a little inconsistent here: all the descendants of BasicButtonUI include the full stop ('.') with the prefix, while the descendants of BasicMenuItemUI and

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread Mark Wielaard
Hi David, On Wed, 2005-08-31 at 16:14 +, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create system class loader Exception occured while printing exception

Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Andrew Pinski wrote: On Aug 31, 2005, at 12:14 PM, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread Mark Wielaard
On Wed, 2005-08-31 at 17:44 +0200, Mark Wielaard wrote: Hmmm, after a clean build and install of both classpath and jamvm I have the same issue. Reverting the patch makes things work again. Embarrassing. Apologies. I am investigating what goes wrong and why I didn't notice this before. It was

[cp-patches] [RFC/docs] Additions and fixes for README and INSTALL

2005-08-31 Thread Robert Schuster
Hi, I updated README and INSTALL. Everyone ok with the changes? 2005-08-31 Robert Schuster [EMAIL PROTECTED] * README: Added MysaifuVM to list of VMs * INSTALL: Added info about Qt4 and ecj. cu Robert Index: README ===

[cp-patches] FYI: MetalBorders

2005-08-31 Thread David Gilbert
I committed this patch which implements the getTextFieldBorder() method in the MetalBorders class: 2005-08-31 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalBorders.java (textFieldBorder): new field, (Flush3DBorder): new class,

Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon()

2005-08-31 Thread Tom Tromey
On Tue, 2005-08-30 at 21:35 +, David Gilbert wrote: I committed this patch to add an icon for JRadioButtonMenuItems under the Metal look and feel: +public int getIconWidth() +{ + return 10; +} I notice there are an awful lot of constant integers in the plaf code.

[cp-patches] Patch for PR swing/23204 BasicTableUI

2005-08-31 Thread Anthony Balkissoon
This patch implements the getMinimumSize and getMaximumSize methods in BasicTableUI, essentially fixing bug PR swing/23204 where table columns weren't being automatically resized. I have not yet closed this bug because changes need to be made (most likely in ViewportLayout) to allow

[cp-patches] Patch for PR swing/23037 FileChooser.java

2005-08-31 Thread Anthony Balkissoon
This patch fixes PR swing/23037 where the directory up button in JFileChoosers wasn't stopping at the top of the directory structure, but rather bouncing back to the user's home directory. Patch attached. 2005-08-31 Anthony Balkissoon [EMAIL PROTECTED] PR swing/23037 *

Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon()

2005-08-31 Thread David Gilbert
Tom Tromey wrote: On Tue, 2005-08-30 at 21:35 +, David Gilbert wrote: I committed this patch to add an icon for JRadioButtonMenuItems under the Metal look and feel: +public int getIconWidth() +{ + return 10; +} I notice there are an awful lot of

[cp-patches] Patch for PR swing/23036 BasicFileChooserUI

2005-08-31 Thread Anthony Balkissoon
This patch fixes PR swing/23036 where the look-in box for JFileChoosers wasn't displaying the correct parent directories. Patch is attached. 2005-08-31 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicFileChooserUI.java: (boxEntries): Made this method package

[cp-patches] fix heavyweight placement within lightweight container

2005-08-31 Thread Thomas Fitzsimmons
Hi, This patch fixes the placement of heavyweight components in lightweight containers. I have an app that adds a Canvas to a JFrame; the canvas was being drawn with the wrong offsets relative to the frame. I've committed this patch, which fixes the canvas's placement. Tom 2005-08-31 Thomas

Re: [cp-patches] [RFC/docs] Additions and fixes for README and INSTALL

2005-08-31 Thread Mark Wielaard
Hi Robert, On Wed, 2005-08-31 at 18:57 +0200, Robert Schuster wrote: I updated README and INSTALL. Everyone ok with the changes? 2005-08-31 Robert Schuster [EMAIL PROTECTED] * README: Added MysaifuVM to list of VMs * INSTALL: Added info about Qt4 and ecj. Thanks for keeping