Re: [cp-patches] [RFC] JSSE 1.5 classes and methods

2005-09-13 Thread Chris Burdess
Casey Marshall wrote: I'm looking for comments about this approach, since I imagine it is controversial; this looks closely compatible with 1.5, according to japicompat, but I'm not sure if that level of compatibility is close enough. There are a couple alternatives to a new class under 'gnu':

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread Chris Burdess
David Daney wrote: As I threatened last week, I made some major changes to the gnu.java.net.protocol.http package. ... The current version reads the entire body of a HTTP response in to a memory buffer (ByteArrayResponseBodyReader) and if user code needs the content it gets a

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Chris Burdess
David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available bytes into its buffer

[cp-patches] FYI: Added API comments to JTabbedPane

2005-09-13 Thread Roman Kennke
2005-09-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTabbedPane.java: Added API comments all over. /Roman Index: javax/swing/JTabbedPane.java === RCS file: /cvsroot/classpath/classpath/javax/swing/JTabbedPane.java,v

[cp-patches] FYI: SizeRequirements fix

2005-09-13 Thread Roman Kennke
2005-09-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/SizeRequirements.java (toString): Implemented this method. (calculateAlignedPositions): Partly implemented this method. /RomanIndex: javax/swing/SizeRequirements.java

[cp-patches] FYI: DefaultStyledDocument additions

2005-09-13 Thread Roman Kennke
Hi, I added lots of stuff to javax.swing.text.DefaultStyledDocument. 2005-09-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java (ElementSpec): New inner class. (ElementBuffer.change): Also store the DefaultDocumentEvent.

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread Chris Burdess
David Daney wrote: You would probably have a better chance if you threw out all the inetlib classes and started from scratch with a pull-based client. What are you talking about? I am not using inetlib. The gnu.java.net.protocol.http package is the inetlib HTTP client. I do agree with

[cp-patches] FYI: java.io.ByteArrayOutputStream fix toString(int)...

2005-09-13 Thread David Daney
As approved by Tom Tromey on [EMAIL PROTECTED] 2005-09-13 David Daney [EMAIL PROTECTED] * java/io/ByteArrayOutputStream.java: Reformated copyright notice. (toString(int)): Pass correct parameters to String constructor. David Daney. Index: java/io/ByteArrayOutputStream.java

Re: [cp-patches] RFC: [Patch] rewrite of classpath/gnu/java/net/protocol/http/*

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: You would probably have a better chance if you threw out all the inetlib classes and started from scratch with a pull-based client. What are you talking about? I am not using inetlib. The gnu.java.net.protocol.http package is the inetlib HTTP

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Tom Tromey
Chris == Chris Burdess [EMAIL PROTECTED] writes: I did take the liberty of adding my own micro-optimization, in that if the encoding is US-ASCII, we can skip using String's character encoding system and just request hibyte of 0. I did this because a year ago with libgcj-3.4.3 we were

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Tom Tromey wrote: Chris == Chris Burdess [EMAIL PROTECTED] writes: I did take the liberty of adding my own micro-optimization, in that if the encoding is US-ASCII, we can skip using String's character encoding system and just request hibyte of 0. I did this because a year ago with

[cp-patches] Re: Patch for approval fixes bug # 23006

2005-09-13 Thread Anthony Balkissoon
Sorry, I sent this from my non-list account. On Tue, 2005-09-13 at 16:18 -0400, Anthony Balkissoon wrote: To account for peers' size requirements, Components should be invalidated before they are first shown on the screen. This patch calls invalidateTree() when a Window is first shown. This

[cp-patches]: Patch: JTree missing functions-

2005-09-13 Thread Lillian Angel
Added methods in JTree that were missing. 2005-09-13 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java (AccessibleJTree): Added new Inner class. (AccessibleJTree.addAccessibleSelection): New method. (AccessibleJTree.clearAccessibleSelection): New method.

[cp-patches] Patch: FYI: warning fixes

2005-09-13 Thread Tom Tromey
I'm checking this in. This mostly fixes some warnings related to javadoc but also a couple related to unused imports. It also adds a missing @since -- try to remember these, folks. Tom 2005-09-13 Tom Tromey [EMAIL PROTECTED] * java/lang/Process.java: Added import for javadoc.

[cp-patches] FYI: BasicComboBoxUI

2005-09-13 Thread David Gilbert
I committed this patch: 2005-09-13 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboBoxUI.java (lightHighlight): removed, (installDefaults): only update component attributes if they are tagged with UIResource, initialise button colors from

[cp-patches] FYI: MetalComboBoxButton and MetalComboBoxEditor

2005-09-13 Thread David Gilbert
I committed these new classes. The MetalComboBoxUI class that uses them isn't complete yet, but I'm working on it: 2005-09-13 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalComboBoxButton.java: new file, * javax/swing/plaf/metal/MetalComboBoxEditor.java:

[cp-patches] DiffieHellman and RSA

2005-09-13 Thread Casey Marshall
I've checked these in. I put an RFC for these out some time ago [1], but didn't see Tromey's reply until now. This adds DiffieHellman key exchange and RSA cipher support; as I understand it, this should fix problems with using Eclipse's 'extssh' with free runtimes. 2005-09-13 Casey

[cp-patches] Patch: FYI: update eclipse javadoc settings

2005-09-13 Thread Tom Tromey
I'm checking this in. I was getting a fair number of warnings for javadoc references to non-visible or deprecated members. The latter seemed reasonable to allow in our code; the former, well, maybe. I'm enabling both, and we can see how it goes. Tom 2005-09-13 Tom Tromey [EMAIL PROTECTED]