[cp-patches] FYI: Missing JComboBox methods.

2005-09-26 Thread Sven de Marothy
2005-09-27 Sven de Marothy <[EMAIL PROTECTED]> * javax/swing/JComboBox.java (firePopupMenuCanceled): Implement (firePopupMenuWillBecomeInvisible): Implement (firePopupMenuWillBecomeVisible): Implement Index: javax/swing/JComboBox.java ===

[cp-patches]: Patch: JTree, ToolTipManager, JMenuItem fixes

2005-09-26 Thread Lillian Angel
I have started to work on getting the accelerators in Menus to work. The change I made in JMenuItem currently has no effect just yet. 2005-09-26 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JTree.java (JTree): Root should be visible by default. * javax/swing/ToolTipMa

[cp-patches] RFC: 2 swing.text.Utilities methods implemented

2005-09-26 Thread Anthony Balkissoon
I implemented getRowStart and getRowEnd in javax.swing.text.Utilities. This is RFC because of the issue raised in the large comment in each of this methods (namely, performance). Some comments would be appreciated. 2005-09-26 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/text/U

[cp-patches] Patch: FYI: 2 javadoc fixes

2005-09-26 Thread Tom Tromey
I'm checking this in. This fixes a couple of javadoc warnings from Eclipse. Tom 2005-09-26 Tom Tromey <[EMAIL PROTECTED]> * java/lang/reflect/Proxy.java: Javadoc fix. * java/io/OutputStreamWriter.java (OutputStreamWriter): Javadoc fix. Index: java/io/OutputStreamWriter.java =

Re: [cp-patches]: GtkDialogPeer fix and Tree fix

2005-09-26 Thread Lillian Angel
On Mon, 2005-09-26 at 13:23 -0400, Thomas Fitzsimmons wrote: > Hi, > > You should include in each patch message you send to this list a > description of what the patch does. This one in particular deserves a > description since we're using reflection tricks (which are warranted in > this case, in

Re: [cp-patches]: GtkDialogPeer fix and Tree fix

2005-09-26 Thread Thomas Fitzsimmons
Hi, You should include in each patch message you send to this list a description of what the patch does. This one in particular deserves a description since we're using reflection tricks (which are warranted in this case, in my opinion). Tom On Mon, 2005-09-26 at 11:20 -0400, Lillian Angel wrot

Re: [cp-patches] Patch: javax.sound.midi

2005-09-26 Thread Anthony Green
On Mon, 2005-09-26 at 09:48 -0600, Tom Tromey wrote: > There are one or two places where the code goes past column 79. > (I'm not super concerned about this. I think we need a reformatting > flag day anyway.) I've cleaned most of these up in the attached patch. This patch also removes the declar

Re: [cp-patches] Patch: javax.sound.midi

2005-09-26 Thread Tom Tromey
Anthony> This doesn't quite work because ShortMessage's parent Anthony> declares an abstract clone(), so you can't super.clone() it. Anthony> Perhaps they did this to force the implementation method I Anthony> chose. Ok, thanks. How amazingly lame. Tom _

Re: [cp-patches] Patch: javax.sound.midi

2005-09-26 Thread Anthony Green
On Mon, 2005-09-26 at 09:48 -0600, Tom Tromey wrote: > I think this is looking great. I think it is OK to go in. Thanks. I'll do that. > I think @author should have your full name, like: > > @author Anthony Green ([EMAIL PROTECTED]) > > Each class' javadoc should say '@since 1.3'. Ok, I'

[cp-patches]: GtkDialogPeer fix and Tree fix

2005-09-26 Thread Lillian Angel
2005-09-26 Lillian Angel <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GtkDialogPeer.java (create): If the dialog is a toolTip or a PopupMenu, its type should be set to: GDK_WINDOW_TYPE_HINT_MENU, so the parent window does not lose focus. * javax/swi

Re: [cp-patches] Patch: javax.sound.midi

2005-09-26 Thread Tom Tromey
> "Anthony" == Anthony Green <[EMAIL PROTECTED]> writes: Anthony> Here's a virtually complete javax.sound.midi implementation. Anthony> No providers yet. Anthony> Ok? I took a quick look through this. I think this is looking great. I think it is OK to go in. First though, some minor nits,

[cp-patches] [generics] Patch: FYI: Formatter updates

2005-09-26 Thread Tom Tromey
I'm checking this in on the generics branch. This fixes some small bugs in Formatter and also adds support for decimal formatting (integer only) and most date/time formats. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * java/util/Formatter.java (format): Set fmtLocale.

Re: [cp-patches] Patch: FYI: more eclipse updates

2005-09-26 Thread Tom Tromey
> "Anthony" == Anthony Green <[EMAIL PROTECTED]> writes: Anthony> My Eclipse (from FC4) is complaining about not finding Anthony> ${system_path:make}. I had to replace this with Anthony> /usr/bin/make for both CompileNative and CreateLocaleData. Anthony> Any idea why? Nope. Is it the FC4 Ec

Re: [cp-patches] FYI: BaseBreakIterator patch fixes #24017

2005-09-26 Thread Anthony Balkissoon
Small fix to this patch, got rid of the (now) unused local variable "save". 2005-09-26 Anthony Balkissoon <[EMAIL PROTECTED]> * gnu/java/text/BaseBreakIterator.java: (following): Removed unused local variable. --Tony On Thu, 2005-09-22 at 14:24 -0400, Anthony Balkissoon wrote:

[cp-patches] FYI: SizeRequirements improvement

2005-09-26 Thread Roman Kennke
Hi, I improved the SizeRequirements (again), so that calculateTiledPositions() takes the minimum and maximum sizes into account to better use the allocated space. 2005-09-26 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/SizeRequirements.java (calculateTiledPositions): Improved

Re: [cp-patches] FYI: Fixed Swing painting (again)

2005-09-26 Thread Roman Kennke
Am Montag, den 26.09.2005, 12:16 +0200 schrieb Mark Wielaard: > Hi Roman, > > On Mon, 2005-09-26 at 11:50 +0200, Roman Kennke wrote: > > > > Rectangle bounds = children[i].getBounds(); > > > > Rectangle oldClip = g.getClipBounds(); > > > > +if (oldClip == null) > > > > +

[cp-patches] [generics] Partial implementation of generic signature parsing

2005-09-26 Thread Jeroen Frijters
Hi, I started implementing the parsing of the new Signature attribute that describes the 1.5 generic signatures. Not everything is there yet, but I will continue to flesh out the implementation. Regards, Jeroen 2005-09-25 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/java/lang/reflect/Cla

Re: [cp-patches] Patch: FYI: more eclipse updates

2005-09-26 Thread Anthony Green
On Tue, 2005-08-16 at 15:42 -0600, Tom Tromey wrote: > 2005-08-16 Tom Tromey <[EMAIL PROTECTED]> > > * .project: Fixed typo. Added builder for native code. > * .externalToolBuilders/CompileNative.launch: New file. My Eclipse (from FC4) is complaining about not finding ${system_path

[cp-patches] [generics] Removed generics from VMSystem interface

2005-09-26 Thread Jeroen Frijters
Hi, As previously discussed, I've applied the attached patch to remove the generic type from the VMSystem.environ() call, to make it easier to have a common VMSystem for the trunk and the generics branch. Regards, Jeroen 2005-09-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/Syste

[cp-patches] [generics] Removed java/lang/MalformedParameterizedTypeException.java

2005-09-26 Thread Jeroen Frijters
Hi, I removed java/lang/MalformedParameterizedTypeException.java, I think someone accidentally added it to the wrong directory. Regards, Jeroen 2005-09-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/MalformedParameterizedTypeException.java: Removed. _

Re: [cp-patches] FYI: Fixed Swing painting (again)

2005-09-26 Thread Mark Wielaard
Hi Roman, On Mon, 2005-09-26 at 11:50 +0200, Roman Kennke wrote: > > > Rectangle bounds = children[i].getBounds(); > > > Rectangle oldClip = g.getClipBounds(); > > > +if (oldClip == null) > > > + oldClip = bounds; > > > > And later you do: > > > > g

Re: [cp-patches] FYI: Fixed Swing painting (again)

2005-09-26 Thread Roman Kennke
Hi Mark, Am Sonntag, den 25.09.2005, 23:38 +0200 schrieb Mark Wielaard: > Hi Roman, > > > > 2005-09-22 Roman Kennke <[EMAIL PROTECTED]> > > > > * javax/swing/JComponent.java > > (paintChildren): If a child component is invisible, skip it. > > Handle the (rare) case when no clip is

Re: [cp-patches] FYI: JComponent painting reworked

2005-09-26 Thread Roman Kennke
Am Sonntag, den 25.09.2005, 19:30 +0200 schrieb Mark Wielaard: > Hi Roman, > > On Thu, 2005-09-22 at 16:13 +0200, Roman Kennke wrote: > > + /** > > + * Performs normal painting without double buffering. > > + * > > + * @param r the area to be repainted > > + */ > > + void paintSimple(Rec