Re: [cp-patches] Re: imageio/ImageReader|Writer check *Listeners

2005-10-03 Thread Andreas Tobler
Andreas Tobler wrote: Hi Tom, Thomas Fitzsimmons wrote: @@ -185,8 +185,10 @@ { if (listener == null) return; - -progressListeners.add(listener);+if (progressListeners != null) + { +progressListeners.add(listener); + } If progressListeners is null her

[cp-patches] Re: imageio/ImageReader|Writer check *Listeners

2005-10-03 Thread Andreas Tobler
Hi Tom, Thomas Fitzsimmons wrote: @@ -185,8 +185,10 @@ { if (listener == null) return; - -progressListeners.add(listener); +if (progressListeners != null) + { + progressListeners.add(listener); + } If progressListeners is null here it should be initia

[cp-patches] Re: imageio/ImageReader|Writer check *Listeners

2005-10-03 Thread Thomas Fitzsimmons
On Mon, 2005-10-03 at 22:35 +0200, Andreas Tobler wrote: > Hello Tom, > > as spoken about on irc. > > Is this what you had in mind? > > I can run 2D swing Demo again. > > Andreas > > > 2005-10-03 Andreas Tobler <[EMAIL PROTECTED]> > > * javax/imageio/ImageWriter.java (availableLocale

[cp-patches] Patch: FYI: qt peers and loadLibrary

2005-10-03 Thread Tom Tromey
I'm checking this in. For libgcj we don't want to use loadLibrary to find the JNI code. Instead we just link it directly into the peer library. Tom 2005-10-03 Tom Tromey <[EMAIL PROTECTED]> * gnu/java/awt/peer/qt/QtToolkit.java (initToolkit): Use Configuration to see if librar

[cp-patches] imageio/ImageReader|Writer check *Listeners

2005-10-03 Thread Andreas Tobler
Hello Tom, as spoken about on irc. Is this what you had in mind? I can run 2D swing Demo again. Andreas 2005-10-03 Andreas Tobler <[EMAIL PROTECTED]> * javax/imageio/ImageWriter.java (availableLocales, locale, originatingProvider, output, progressListeners, warningListener

[cp-patches] FYI: PlainView update partially fixes bug 24152

2005-10-03 Thread Anthony Balkissoon
This fix for PlainView solves one of the problems that was leading to bug 24152, but it is not done yet. The bug report is viewable here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24152 This caches the length of the longest line in the View so that it doesn't have to be calculated each time. H

[cp-patches] Re: FYI: PlainView update partially fixes bug 24152

2005-10-03 Thread Anthony Balkissoon
Forgot to attach the patch. --Tony On Mon, 2005-10-03 at 16:07 -0400, Anthony Balkissoon wrote: > This fix for PlainView solves one of the problems that was leading to > bug 24152, but it is not done yet. > > The bug report is viewable here: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24152 >

Re: [cp-patches] SampleModel/ComponentSampleModel fix

2005-10-03 Thread Tom Tromey
> "Tom" == Thomas Fitzsimmons <[EMAIL PROTECTED]> writes: Tom>* java/awt/image/SampleModel.java (numBands): Make field Tom>package-private. According to both japi and the javadoc, this field is 'protected'. Based on reading the javadoc, I think ComponentSampleModel also has a protect

Re: [cp-patches] SampleModel/ComponentSampleModel fix

2005-10-03 Thread Thomas Fitzsimmons
On Mon, 2005-10-03 at 11:44 -0600, Tom Tromey wrote: > > "Tom" == Thomas Fitzsimmons <[EMAIL PROTECTED]> writes: > > Tom> * java/awt/image/SampleModel.java (numBands): Make field > Tom> package-private. > > According to both japi and the javadoc, this field is 'protected'. > > Based on rea

[cp-patches] Patch: FYI: javadoc -vs- AWT

2005-10-03 Thread Tom Tromey
I'm checking this in. This fixes a number of javadoc buglets in AWT. After this patch eclipse reports just one remaining javadoc warning in AWT, and a few serialization warnings. Tom 2005-10-03 Tom Tromey <[EMAIL PROTECTED]> * java/awt/Polygon.java (evaluateCrossings): Removed @see.

Re: [cp-patches] FYI: Scrolling fixes

2005-10-03 Thread Lillian Angel
On Fri, 2005-09-30 at 15:26 +0200, Roman Kennke wrote: > This fixes some issues with the JScrollPane. It should now work reasonable > again. Actually, the scrolling is still pretty broken. When I scroll to the left, it moves right :( Lillian ___ Clas

Re: [cp-patches] Complete javax.imageio

2005-10-03 Thread Thomas Fitzsimmons
On Mon, 2005-10-03 at 16:12 +0200, Andreas Tobler wrote: > Hi Tom, > > hopefully you can enlight a java newbie :) > > In javax/imageio/ImageReader.java you change the following for example > > protected List progressListeners = new ArrayList(); > > to > > protected List progressListeners = nul

[cp-patches]: Patch: JOptionPane fix

2005-10-03 Thread Lillian Angel
Fixes bug#24113 2005-10-03 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JOptionPane.java (getInputValue): If the option selected is 'Cancel', then the input value is set to null. (showInternalConfirmDialog): Added check to prevent NPE. (showInternalCon

[cp-patches] FYI: javax.rmi.CORBA compatibility fixes.

2005-10-03 Thread Meskauskas Audrius
2005-10-03 Audrius Meskauskas <[EMAIL PROTECTED]> * javax/rmi/CORBA/ValueHandler.java (getRunTimeCodeBase): Fixed return type. * gnu/javax/rmi/CORBA/ValueHandlerDelegateImpl.java (getRunTimeCodeBase): Implemented. Index: gnu/javax/rmi/CORBA/ValueHandlerDelegateImpl.java ===

[cp-patches] Patch: FYI: small RMI/CORBA japi fix

2005-10-03 Thread Tom Tromey
I'm checking this in. Japi pointed out a minor problem in javax.rmi.CORBA; one of the return types was wrong. Fixed as appended. Tom 2005-10-03 Tom Tromey <[EMAIL PROTECTED]> * gnu/javax/rmi/CORBA/ValueHandlerDelegateImpl.java (getRunTimeCodeBase): Changed return type.

Re: [cp-patches] Complete javax.imageio

2005-10-03 Thread Andreas Tobler
Hi Tom, hopefully you can enlight a java newbie :) In javax/imageio/ImageReader.java you change the following for example protected List progressListeners = new ArrayList(); to protected List progressListeners = null; The java doc says: progressListeners: A List of currently registered IIO

[cp-patches] Re: Patch: FYI: small RMI/CORBA japi fix

2005-10-03 Thread Tom Tromey
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: Tom> Japi pointed out a minor problem in javax.rmi.CORBA; one of the return Tom> types was wrong. Fixed as appended. Looks like this was already fixed in cvs, and I didn't see the commit until after I posted. Tom __

Re: [cp-patches] FYI: Fix for JComboBox drop down list

2005-10-03 Thread Lillian Angel
This is fixed now. 2005-10-03 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JMenuItem.java (init): Set horizontalTextPosition to TRAILING, instead of LEFT. Icons are drawn in the correct spot now. On Mon, 2005-10-03 at 09:34 -0400, Lillian Angel wrote: > > I can loo

Re: [cp-patches] RFC: Fix for JComboBox drop down list

2005-10-03 Thread Lillian Angel
> I can look into this, but it surely has nothing to do with the > BoxLayout. The icons were drawn wrong since we draw them at all. I think > they are laid out in SwingUtilities.layoutCompoundLabel, so either that > one is wrong or the call to this method is wrong (more likely). The icons were d

[cp-patches] FYI: The small intermediate page form CORBA interoperability.

2005-10-03 Thread Meskauskas Audrius
Andrew Watson , Vice President and Technical Director of the Object Management Group, has officially assigned us 20 bit Vendor Minor Code Id: 0x47430 ("GC"). We must use this Id to mark remote Classpath - specific system exceptions that other applications may receive from our CORBA implementati

[cp-patches] FYI: BasicTabbedPaneUI

2005-10-03 Thread David Gilbert
This simple patch (committed) fixes the alignment of the icon and text on the tab for a JTabbedPane, a problem that shows up in the JUnit Swing-based TestRunner: 2005-10-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java (layoutLabel): place t

[cp-patches] FYI: MetalComboBoxButton

2005-10-03 Thread David Gilbert
This patch (committed) tidies up non-editable JComboBoxes a little (under the MetalLookAndFeel) by truncating the text if necessary and adding the '...' suffix to indicate the truncation. I've made a note that this should be handled in the SwingUtilities.layoutCompoundLabel() method, but since

[cp-patches] FYI: News update

2005-10-03 Thread Meskauskas Audrius
2005-10-03 Audrius Meskauskas <[EMAIL PROTECTED]> * NEWS: Added entry about Classpath VMCID and IIOP. Index: NEWS === RCS file: /cvsroot/classpath/classpath/NEWS,v retrieving revision 1.97 diff -u -r1.97 NEWS ---