[cp-patches] FYI: Implemented LookAndFeel methods

2005-10-12 Thread Roman Kennke
I implemented 3 methods that were previously stubbed in javax.swing.LookAndFeel. 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/LookAndFeel.java (installBorder): Implemented. (installColors): Implemented. (installColorsAndFont): Implemented. /Roman

Re: [cp-patches] FYI: Implemented LookAndFeel methods

2005-10-12 Thread Roman Kennke
Here comes the actual patch. Am 12.10.2005 schrieb Roman Kennke [EMAIL PROTECTED]: I implemented 3 methods that were previously stubbed in javax.swing.LookAndFeel. 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/LookAndFeel.java (installBorder): Implemented.

[cp-patches] FYI: Some JViewport fixes

2005-10-12 Thread Roman Kennke
I investigated the JViewport stuff a little more and fixed the following issues, which should bring JViewport a little closer to the reference impl's behaviour: 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (ViewListener.componentResized): Only call

[cp-patches] FYI: Some JComponent fixlets

2005-10-12 Thread Roman Kennke
Here come two fixlets for JComponent that I found while investigating the revalidate stuff a little more: 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (setFont): Only get active if the new font differs from the old one. Call revalidate when

[cp-patches] FYI: Removed unneeded method in JComboBox

2005-10-12 Thread Roman Kennke
I removed a method in JComboBox that is unneeded and unspecified (and deprecated). 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComboBox.java (isFocusTraversable): Removed unneeded and unspecified method. /Roman Index: javax/swing/JComboBox.java

[cp-patches] FYI: MetalIconFactory

2005-10-12 Thread David Gilbert
Some tests I am working on for the JFileChooser/BasicFileChooserUI/MetalFileChooserUI classes depend on some of the methods of MetalIconFactory returning the same icon reference each time they are called. In many cases, Classpath is returning a new icon instance for each call. I wrote Mauve

[cp-patches] FYI: Component fixlet

2005-10-12 Thread Roman Kennke
This fixes a small repaint problem in java.awt.Component. The rectangle calculation in reshape() was wrong, it calculated rectangle relative to the parent's parent, which should only be relative to the parent. 2005-10-12 Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java

[cp-patches] FYI: JViewport optimization

2005-10-12 Thread Roman Kennke
This optimizes JViewport. The backingstore drawing mechanism created images far too often. Now it only creates a new image when the actual size of the viewport changed. 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (sizeChanged): A new flag, indicating

Re: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR classpath/24104 et al. ...

2005-10-12 Thread David Daney
Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: David Daney wrote: LimitedLengthInputStream shouldn't have a finalize(). Let's consider the case where a client program did not read the entire body of the response: As implemented in the patch, the finalize is indeed

Re: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR classpath/24104 et al. ...

2005-10-12 Thread Tom Tromey
Jeroen == Jeroen Frijters [EMAIL PROTECTED] writes: OK to commit? Jeroen I vote yes. Me too. Please go ahead and check it in. Thanks for doing this. Tom ___ Classpath-patches mailing list Classpath-patches@gnu.org

Re: [cp-patches] FYI: Fixed ScrollPaneLayout

2005-10-12 Thread Lillian Angel
I don't know if this patch caused the problem, but something today has made the Swing demo fail (on the List world tab): java.lang.NullPointerException at javax.swing.ScrollPaneLayout.minimumLayoutSize

Re: [cp-patches] RFA: Fix LineInputStream (PR classpath/24259)

2005-10-12 Thread Tom Tromey
David == David Daney [EMAIL PROTECTED] writes: David 2005-10-07 David Daney [EMAIL PROTECTED] David PR classpath/24259 David * gnu/java/net/LineInputStream.java: Import BufferedInputStream. David (Constructor): Don't do blockReads on BufferedInputStreams. David (readLine): Rename

[cp-patches] FYI: AbstractDocument fixlet resolves PR24335

2005-10-12 Thread Anthony Balkissoon
Small fix to AbstractDocument's insertString and remove methods fixes the bug I mentioned in my last post. The DocumentEvents now don't include ElementChanges unless Elements were added or removed. I'll turn the testcase I worked on into a Mauve testcase and submit it. 2005-10-12 Anthony

Re: [cp-patches] FYI: PlainView update improvements

2005-10-12 Thread Anthony Balkissoon
Didn't include the patch. Here it is. --Tony On Wed, 2005-10-12 at 13:41 -0400, Anthony Balkissoon wrote: This patch fixes a number of issues with PlainView's updating facilities. First, changedUpdate is implemented and made to call the same method as insertUpdate and removeUpdate (so this

[cp-patches] FYI: Properly implement ObjectInputStream ObjectValidators

2005-10-12 Thread Mark Wielaard
Hi, This fixes bug #22841 by rewriting the ObjectValidators support. It seems this code has been wrong since 1998 when it was first added. But it is not a feature that is often used. 2005-10-12 Mark Wielaard [EMAIL PROTECTED] Fixes bug #22841 * java/io/ObjectInputStream

[cp-patches] FYI: JTable doc and import fixes

2005-10-12 Thread Anthony Balkissoon
Just fixed some of those little yellow exclamation marks Eclipse was showing. A few links in API docs and 2 unused imports. 2005-10-12 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JTable.java: Fixed some API docs and unused imports. --Tony Index: javax/swing/JTable.java

[cp-patches] FYI: Fix LineInputStream (PR classpath/24259)

2005-10-12 Thread David Daney
I just committed this patch which is the partner to my last patch. This patch corrects the run-away buffering condition documented in the PR by limiting the maximum buffer size. In addition buffering is disabled if the underlying stream is a BufferedInputStream. Because in this case the

[cp-patches] FYI: ScrollPaneLayout fixlet

2005-10-12 Thread Roman Kennke
In my latest patch to ScrollPaneLayout I obviously forgot some necessary NPE checks. Here they come. 2005-10-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/ScrollPaneLayout.java (minimumLayoutSize): Added checks to avoid NPEs. /Roman Index: javax/swing/ScrollPaneLayout.java

[cp-patches] RFC: Swing painting overhaul

2005-10-12 Thread Roman Kennke
Hi, I finally got my improved (I hope) Swing painting to work. The situation before was, that we always went up to the root window and painted everything and let the clipping sort out what is not repainted. This new painting is more finegrained. It makes use of the opaque and isOptimizedPainting

[cp-patches]: Patch: UIDefaults fix

2005-10-12 Thread Lillian Angel
When running applications that have their own UI's created, I was getting exceptions all the time. Tom Tromey suggested this fix a while back, and it has seemed to fix the problem every time. It has not had any adverse side effects either. 2005-10-12 Lillian Angel [EMAIL PROTECTED] *

Re: [cp-patches]: Patch: JTree fix

2005-10-12 Thread Mark Wielaard
Hi Lillian, On Wed, 2005-10-05 at 17:28 -0400, Lillian Angel wrote: Fixed up BasicTreeUI because it was not efficent when painting. 2005-10-05 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalTreeUI.java (installUI): Fixed to call toggleExpandState instead.

[cp-patches] [generics] Various miscellaneous fixes found by JAPI or ecj

2005-10-12 Thread Andrew John Hughes
I'm committing the attached patch to fix a few methods and fields that lack generic information. Changelog: 2005-10-12 Andrew John Hughes [EMAIL PROTECTED] * java/awt/datatransfer/DataFlavor.java: (DataFlavor(Class?,String,String): Genericized. *