[cp-patches] Re: build failure - problems detecting freetype2 headers

2005-10-19 Thread Christian Thalinger
On Tue, Oct 18, 2005 at 10:41:11AM -0600, Tom Tromey wrote: The updated patch looks good to me. Write a ChangeLog entry and email it and the patch to me, I'll check it in. 2005-10-19 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Also check for pangoft2 without cairo and

[cp-patches] FYI: DebugGraphics logging implemented

2005-10-19 Thread Roman Kennke
Hi, I implemented the logging facility of javax.swing.DebugGraphics. This is a really useful tool for debugging our Swing. All you have to do is to call setDebugGraphicsOptions(DebugGraphics.LOG_OPTION) on a Swing component, and all painting operations on the component and its children are then

Re: [cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

2005-10-19 Thread Roman Kennke
Am Dienstag, den 18.10.2005, 22:58 +0200 schrieb Robert Schuster: Hi Roman, Index: javax/swing/colorchooser/DefaultSwatchChooserPanel.java === RCS file:

[cp-patches] FYI: ComponentUI clipping reverted

2005-10-19 Thread Roman Kennke
I have thought again about my clipping patch for ComponentUI from 2005-10-12 and came to the conclusion that this is not right. It works in most cases, but when the clipping is a little weird, this method can be destructive (on the GUI). If there are still clipping problems, then most likely in

[cp-patches] FYI: TableColumnModel API fix

2005-10-19 Thread Roman Kennke
This fixes a minor API comment issue in TableColumnModel. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/TableColumnModel.java: Fixed some minor API doc errors. /Roman Index: javax/swing/table/TableColumnModel.java

[cp-patches] javax.swing.text.html.parser cleanup

2005-10-19 Thread Roman Kennke
Adds comments to empty blocks in javax.swing.text.html.parser 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/parser/ContentModel.java * javax/swing/text/html/parser/DTD.java * javax/swing/text/html/parser/DocumentParser.java *

[cp-patches] javax.swing.text.html cleanup

2005-10-19 Thread Roman Kennke
This adds comments to two empty blocks in javax.swing.text.html. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/HTML.java * javax/swing/text/html/HTMLDocument.java Filled emtpy blocks with comments. /Roman Index: javax/swing/text/html/HTML.java

[cp-patches] FYI: ComboBox fixes

2005-10-19 Thread David Gilbert
This patch (committed) fixes most of the failing Mauve tests for the combo box classes: 2005-10-19 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicArrowButton.java (buttonBorder): removed, (BasicArrowButton): don't set border, use default border,

[cp-patches] FYI: javax.swing.text cleanup

2005-10-19 Thread Roman Kennke
Some cleanup for javax.swing.text. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/AbstractDocument.java * javax/swing/text/AttributeSet.java * javax/swing/text/ComponentView.java * javax/swing/text/DefaultCaret.java *

[cp-patches] FYI:javax.swing.tree cleanup

2005-10-19 Thread Roman Kennke
Some cleanup for javax.swing.tree. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/tree/DefaultMutableTreeNode.java * javax/swing/tree/DefaultTreeCellEditor.java * javax/swing/tree/TreeCellRenderer.java * javax/swing/tree/TreeModel.java

[cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Roman Kennke
This adds super() calls to 2 previously empty constructors. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/undo/CannotRedoException.java * javax/swing/undo/CannotUndoException.java Put super() call in empty constructors. /Roman Index:

[cp-patches] FYI: implemented JButton method

2005-10-19 Thread Roman Kennke
I implemented the previously stubbed method JButton.removeNotify. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JButton.java (removeNotify): Implemented this previously stubbed method. /Roman Index: javax/swing/JButton.java

[cp-patches] FYI: implemented JEditorPane.read()

2005-10-19 Thread Roman Kennke
This implements the read() method in JEditorPane. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JEditorPane.java Added comments to empty blocks. (read): Implemented this previously stubbed method. /Roman Index: javax/swing/JEditorPane.java

[cp-patches] FYI: JLabel fixlet

2005-10-19 Thread Roman Kennke
This adds a repaint() and revalidate() call to JLabel.setText(). This is backed up by a Mauve testcase that I've written. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLabel.java (setText): Call revalidate() and repaint(). /Roman Index: javax/swing/JLabel.java

[cp-patches] FYI: OverlayLayout fixlet

2005-10-19 Thread Roman Kennke
This fixes the OverlayLayout so that it respects the container's insets correctly. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/OverlayLayout.java (checkLayout): Respect the container's insets correctly. /Roman ___

[cp-patches] FYI: Chain SocketException

2005-10-19 Thread Mark Wielaard
Hi, This helped me debug starting jboss a bit. 2005-10-19 Mark Wielaard [EMAIL PROTECTED] * java/net/Socket.java (getImpl): Chain exception before throwing. Committed, Mark diff -u -r1.53 Socket.java --- java/net/Socket.java9 Oct 2005 22:05:47 - 1.53 +++

[cp-patches] FYI: Load LoginModules through context class loader

2005-10-19 Thread Mark Wielaard
Hi, This was one of the patches needed to get JBoss starting up. We were not finding any LoginModules since we were trying to find them through the bootstrap class loader. 2005-10-19 Mark Wielaard [EMAIL PROTECTED] * javax/security/auth/login/LoginContext.java (lookupModule):

[cp-patches] FYI: Removed debug output in JComponent

2005-10-19 Thread Roman Kennke
I removed a debug statement in JComponent. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (getDebugGraphicsOptions): Removed debug output. /Roman Index: javax/swing/JComponent.java === RCS

[cp-patches] RFC: Don't call protected addURL() method from URLClassLoader constructors

2005-10-19 Thread Mark Wielaard
Hi, This is the last piece needed to get JBoss (4.0.3) to start up. JBoss has some ClassLoaders that subclass URLClassLoader and override the protected addURL() method. These ClassLoaders don't expect addURL() to be called while they are calling super() in their own constructor since they haven't

[cp-patches] Re: RFC: Don't call protected addURL() method from URLClassLoader constructors

2005-10-19 Thread Mark Wielaard
Hi Andrew, On Wed, 2005-10-19 at 17:36 +0100, Andrew Haley wrote: 2005-10-19 Mark Wielaard [EMAIL PROTECTED] * java/net/URLClassLoader.java (addURLs): Don't call addURL(), but call urls.add() and addURLImpl() directly on each URL. Andrew, I know you hacked on this code to

Re: [cp-patches] FYI: javax.swing cleanup

2005-10-19 Thread Roman Kennke
Hi, I saw you also added the start of the AccessibleJTable with this last patch (you forgot to mention that in the ChangeLog entry). Whoops, that one must have sneaked in. My plan was to finish this before committing it... /Roman signature.asc Description: Dies ist ein digital signierter

Re: [cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Michael Koch
On Wed, Oct 19, 2005 at 08:46:16PM +0200, Roman Kennke wrote: Hi Micheal, -public class CannotRedoException - extends RuntimeException +public class CannotRedoException extends RuntimeException { The old version is according to our formatting rules. The new version is not.

Re: [cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Roman Kennke
Hi, -public class CannotRedoException - extends RuntimeException +public class CannotRedoException extends RuntimeException { The old version is according to our formatting rules. The new version is not. Well, last time I asked about that on IRC I was told (by

[cp-patches] Patch: use StringBuilder for reading/writing property files

2005-10-19 Thread Anthony Green
Synchronization often shows up near the very top of gcj-compiled benchmarks. It turns out that, for benchmarks I've run, ~50% of the synchronization calls come from reading property files with StringBuffer. This should all go away if we use StringBuilder instead. Ok? 2005-10-19 Anthony Green

Re: [cp-patches] FYI: ComboBox fixes

2005-10-19 Thread Lillian Angel
The arrow is not being painted anymore. It was this morning, so I suspect this patch has something to do with it. Thanks, Lillian On Wed, 2005-10-19 at 15:56 +0100, David Gilbert wrote: This patch (committed) fixes most of the failing Mauve tests for the combo box classes: 2005-10-19