Re: [cp-patches] Patch: MetalTabbedPaneUI missing functions

2005-11-22 Thread Thomas Fitzsimmons
On Tue, 2005-11-22 at 16:10 -0500, Lillian Angel wrote: > Added missing functions in MetalTabbedPaneUI. Again, most just call > super. If these methods just call super then there's no reason to override them. I'm surprised that JAPI is marking these as missing since they are implemented in the ba

[cp-patches] Patch: JEditorPane fix

2005-11-22 Thread Lillian Angel
Added missing constructor. 2005-11-12 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/JEditorPane.java (JEditorPaneAccessibleHypertextSupport): Implemented. Index: javax/swing/JEditorPane.java === RCS file: /cvsroo

[cp-patches] Patch: MetalTabbedPaneUI missing functions

2005-11-22 Thread Lillian Angel
Added missing functions in MetalTabbedPaneUI. Again, most just call super. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalTabbedPaneUI.java (getColorForGap): Implemented. Background color is always returned in this case. (paintHighligh

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
Ok, next time i'll send immediately a changelog. These are commited. TWISTI 2005-11-22 Christian Thalinger <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c (nativeGetFontFamilies): Added missing DeleteLocalRef calls. * native/jn

[cp-patches] Patch: MetalScrollPaneUI

2005-11-22 Thread Lillian Angel
Implemented missing functions in MetalScrollPaneUI. Nothing extra is done in any of these functions, so they all call super. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalScrollPaneUI.java (installUI): Implemented. (uninstallUI): Implemented

[cp-patches] Patch: MetalIconFactory and MetalTextFieldUI function implementations

2005-11-22 Thread Lillian Angel
Added implementations for missing functions in MetalIconFactory and MetalTextFieldUI. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalIconFactory.java (getMenuArrowIcon): Implemented. (getMenuItemArrowIcon): Implemented to call getMenuArrowIcon

Re: [cp-patches] FYI: New class MaskFormatter.java

2005-11-22 Thread Anthony Balkissoon
I updated the Mauve tests and had to check in this small change. 2005-11-22 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/text/MaskFormatter.java: (convertValue): Don't check the valid/invalid character sets if we're matching a literal. --Tony Index: javax/swing

Re: [cp-patches] FYI: New class MaskFormatter.java

2005-11-22 Thread Anthony Balkissoon
On Tue, 2005-11-22 at 14:42 -0500, Anthony Balkissoon wrote: > Checked in a small fix that the Mauve tests pointed out (I'll reply to > this with the specific tests once I've checked those in). the tests are in gnu/testlet/javax/swing/text/MaskFormatter/MaskFormatterTest.java --Tony __

Re: [cp-patches] FYI: New class MaskFormatter.java

2005-11-22 Thread Anthony Balkissoon
Checked in a small fix that the Mauve tests pointed out (I'll reply to this with the specific tests once I've checked those in). 2005-11-22 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/text/MaskFormatter.java: (convertValue): If character is a literal don't throw a Parse

[cp-patches] Patch: MetalComboBoxUI

2005-11-22 Thread Lillian Angel
JAPI pointed out some missing methods in MetalComboBoxUI. I added/implemented them. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalComboBoxUI.java (configureEditor): Implemented. (unconfigureEditor): Implemented. (layoutComboBox): Impl

[cp-patches] FYI: New class MaskFormatter.java

2005-11-22 Thread Anthony Balkissoon
Implemented this missing class from javax.swing.text. I have a bunch of related tests that I need to commit to Mauve-form and I'll commit those. 2005-11-22 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/text/MaskFormatter.java: New class. --Tony Index: javax/swing/text/MaskForma

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-22 Thread Lillian Angel
I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> PR 24937 * gnu/java/awt/peer/gtk/GdkGraphics.java (drawString): Removed pattern matching code. This is now

Re: [cp-patches] FYI: Getting the system clipboard in javax/swing/TransferHandler

2005-11-22 Thread Meskauskas Audrius
>Yes. But the problem was that 1) whenever there was any insecure access to the clipboard all successive calls would use this local clipboard. Yes, if the situation changes in the way that the access to the system clipboard is now permitted, the system clipboard must be returned. This patch fi

Re: [cp-patches] FYI: Stopping the DefaultCaret timer when the component looses the focus.

2005-11-22 Thread Meskauskas Audrius
Despite the current version always operates correctly, yes, the timer generally must be started regardless if the caret is now visible or not (it may get visible due blinking). I was also thinking about the version where the "visible" property is not involved into the blinking process, but in

[cp-patches] FYI: BasicOptionPaneUI fix

2005-11-22 Thread Roman Kennke
Hi, I adjusted the BasicOptionPaneUI to work properly with Lillian's reworked Graphics.drawString. The problem here is that JLabel is not able to display multiline strings, so we have to split this over multiple JLabels. 2005-11-22 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/ba

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-22 Thread Lillian Angel
Robert was right about the regex. I have fixed it for now. I will work on putting the filtering of characters in the native code instead. 2005-11-22 Lillian Angel <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GdkGraphics.java (drawString): Fixed regex. On Tue, 2005-11-22 at 12:

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Mark Wielaard
Hi Christian, On Tue, 2005-11-22 at 11:14 +0100, Christian Thalinger wrote: > This one i found with jaha > (http://www.cs.helsinki.fi/u/abrax/HACK/JAVA/JAHA.html). > --- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c18 > Aug 2005 01:22:00 - 1.19 > +++ native/jni/gt

Re: [cp-patches] FYI: Stopping the DefaultCaret timer when the component looses the focus.

2005-11-22 Thread Mark Wielaard
Hi Audrius, > This should fix the resource leak, stopping the caret blinking timer > when the caret looses the focus. > 2005-11-22 Audrius Meskauskas <[EMAIL PROTECTED]> > > * javax/swing/text/DefaultCaret.java (focusGained): > Update timer status. (focusLost): Stop the timer >

Re: [cp-patches] Comparable in java.util.Calendar

2005-11-22 Thread Mark Wielaard
Hi Kendall, On Mon, 2005-11-21 at 21:35 -0600, Kendall Bell wrote: > 2005-11-21 Kendall Bell <[EMAIL PROTECTED]> > > * java/util/Calendar.java: Implemented Comparable. Seems you accidentally attached the original source file, not the diff -u patch. Please do include all method names you a

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
This one i found with jaha (http://www.cs.helsinki.fi/u/abrax/HACK/JAVA/JAHA.html). TWISTI Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c === RCS file: /cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_

Re: [cp-patches] FYI: Getting the system clipboard in javax/swing/TransferHandler

2005-11-22 Thread Mark Wielaard
Hi Audrius, On Sat, 2005-11-19 at 23:40 +0100, Meskauskas Audrius wrote: > The idea probably is that if we cannot get access to the system > clipboard, we may still want to cut/copy/paste inside the same > application (for instance, to move the text fragment in the text area > being currently e

Re: [cp-patches] FYI: Add some comment to java/io/StreamTokenizer.java

2005-11-22 Thread Mark Wielaard
Hi Ito, On Sun, 2005-11-20 at 10:23 +0900, Ito Kazumitsu wrote: > 2005-11-20 Ito Kazumitsu <[EMAIL PROTECTED]> > > Fixes bug #22691 > * java/io/StreamTokenizer.java(parseNumbers): Added some comment. Seems you forgot to actually commit this patch. As I said in the bug report I thin

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Mark Wielaard
Hi Christian, On Tue, 2005-11-22 at 00:18 +0100, Christian Thalinger wrote: > These are some patches for missing DeleteLocalRef calls i've found with > CACAO. Are they ok? It seems so to me. Should i search for more stuff > like that? Nice. Please do include a ChangeLog entry, that does make r

[cp-patches] FYI: Stopping the DefaultCaret timer when the component looses the focus.

2005-11-22 Thread Meskauskas Audrius
This should fix the resource leak, stopping the caret blinking timer when the caret looses the focus. 2005-11-22 Audrius Meskauskas <[EMAIL PROTECTED]> * javax/swing/text/DefaultCaret.java (focusGained): Update timer status. (focusLost): Stop the timer (unless the event i