Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Christian Thalinger
On Tue, 2005-11-22 at 14:07 -0500, Lillian Angel wrote: I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. I'm compiling my local classpath (on x86_64) with --enable-Werror and this patch broke it. This patched fix it. Is const

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-25 Thread Christian Thalinger
On Thu, 2005-11-24 at 17:31 +0100, Mark Wielaard wrote: Yes, please. Commited. TWISTI ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] Re: RFC: MetalFileChooserUI implementation

2005-11-25 Thread David Gilbert
One additional thing, there is a screen shot here for those that like that sort of thing: http://www.object-refinery.com/classpath/JFileChooser.png Regards, Dave David Gilbert wrote: Hi all, In recent weeks I have done some work on a MetalFileChooserUI implementation, but don't have

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Mark Wielaard
Hi Christian, On Fri, 2005-11-25 at 10:50 +0100, Christian Thalinger wrote: On Tue, 2005-11-22 at 14:07 -0500, Lillian Angel wrote: I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. I'm compiling my local classpath (on

Re: [cp-patches] RFC: BasicTabbedPaneUI paint null Icon?

2005-11-25 Thread Mark Wielaard
Hi, On Tue, 2005-11-22 at 01:03 +0100, Mark Wielaard wrote: This one is a little strange. Apparently the plastic laf overrides getIconForTab(int) and returns null in certain cases. But then it still calls paintIcon on it. I cannot find too much documentation on this, but this seems the

[cp-patches] Re: RFC: MetalFileChooserUI implementation

2005-11-25 Thread Lillian Angel
Looks great! I will continue the implementation for this. Thanks alot! Lillian On Fri, 2005-11-25 at 11:46 +, David Gilbert wrote: One additional thing, there is a screen shot here for those that like that sort of thing: http://www.object-refinery.com/classpath/JFileChooser.png

[cp-patches] Re: RFC: MetalFileChooserUI implementation

2005-11-25 Thread David Gilbert
Hi Lillian, Roman suggested I commit the patch, which I'll do unless that messes anything up for you. I also have some Mauve tests for MetalFileChooserUI that I need to commit - I'll probably get that done over the weekend. Regards, Dave Lillian Angel wrote: Looks great! I will

[cp-patches] Re: RFC: MetalFileChooserUI implementation

2005-11-25 Thread Lillian Angel
Please commit :) On Fri, 2005-11-25 at 15:29 +, David Gilbert wrote: Hi Lillian, Roman suggested I commit the patch, which I'll do unless that messes anything up for you. I also have some Mauve tests for MetalFileChooserUI that I need to commit - I'll probably get that done over

Re: [cp-patches] FYI: gnu_java_awt_peer_gtk_GtkClipboard.c 64-bit fix

2005-11-25 Thread Mark Wielaard
Hi, On Sun, 2005-11-20 at 22:05 +0100, Mark Wielaard wrote: According to http://developer.gnome.org/doc/API/2.0/glib/glib-Type-Conversion-Macros.html the following seems appropriate: 2005-11-20 Mark Wielaard [EMAIL PROTECTED] *

Re: [cp-patches] FYI: Getting the system clipboard in javax/swing/TransferHandler

2005-11-25 Thread Mark Wielaard
Hi Gary, On Tue, 2005-11-22 at 11:41 +0100, Mark Wielaard wrote: Yes. But the problem was that 1) whenever there was any insecure access to the clipboard all successive calls would use this local clipboard and 2) I am not sure it is really valuable to have (mutually?) insecure code (ex)change

[cp-patches] FYI: GtkSelection.c LocalRef cleanup

2005-11-25 Thread Mark Wielaard
Hi, This should fix a bug Christian reported by cleaning up LocalRefs after they have been used. 2005-11-25 Mark Wielaard [EMAIL PROTECTED] Fixes bug #24981 * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkSelection.c (clipboard_targets_received): DeleteLocalRef of

Re: [cp-patches] RFC: GdkGraphics fix

2005-11-25 Thread Tom Tromey
Lillian == Lillian Angel [EMAIL PROTECTED] writes: Lillian drawString(AttributedCharacterIterator...) iterates through the Lillian characters and stores the non-newline chars in an array. Here Roman Lillian suggested that I make some changes and pass the char[] to the native Lillian drawString

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Lillian Angel
Thanks, I fixed this. Committed. 2005-11-25 Lillian Angel [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c (drawString): Changed pointer to be const, and fixed check to draw characters only if they are = ' '. Handles all control

[cp-patches] [generics] Patch: FYI: genericize java.security.cert

2005-11-25 Thread Tom Tromey
I'm checking this in on the generics branch. This genericizes java.security.cert. While I was in there... it seems like we have a number of stubs in here. Also there is some unimplemented stuff. Tom 2005-11-25 Tom Tromey [EMAIL PROTECTED] * java/security/cert/X509Extension.java

[cp-patches] Patch: GdkGraphics typo

2005-11-25 Thread Lillian Angel
Temporarily broke the build with this typo. Fixed now. 2005-11-25 Lillian Angel [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c: Fixed typo. Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c

[cp-patches] [generics] Patch: FYI: genericize java.text

2005-11-25 Thread Tom Tromey
I'm checking this in on the generics branch. This genericizes java.text. Tom 2005-11-25 Tom Tromey [EMAIL PROTECTED] * java/text/NumberFormat.java (format): No longer final. * java/text/AttributedCharacterIterator.java (getAllAttributeKeys): Genericized.

[cp-patches] [generics] Patch: FYI: genericize java.rmi.server

2005-11-25 Thread Tom Tromey
I'm checking this in on the generics branch. This genericizes java.rmi.server. Tom 2005-11-25 Tom Tromey [EMAIL PROTECTED] * java/rmi/server/RMIClassLoaderSpi.java (loadClass): Genericized. (loadProxyClass): Likewise. (getClassAnnotation): Likewise. *

[cp-patches] [generics] Patch: FYI: java.awt.Font generics

2005-11-25 Thread Tom Tromey
I'm checking this in on the generics branch. This genericizes java.awt.Font. Tom 2005-11-25 Tom Tromey [EMAIL PROTECTED] * java/awt/Font.java (Font): Genericized. (deriveFont): Likewise. (getAttributes): Likewise. (getFont): Likewise. Index:

[cp-patches] FYI: Started to replace java.awt.datatransfer.SystemFlavorMap dummy

2005-11-25 Thread Jan Röhrich
I started to replace the dummy implementation of java.awt.datatransfer.SystemFlavorMap. I hope that I'm able to add the last 4 missing methods in java.awt.datatransfer soon. 2005-11-26 Jan Roehrich [EMAIL PROTECTED] * java/awt/datatransfer/SystemFlavorMap.java

[cp-patches] Patch: MetalFileChooser

2005-11-25 Thread Lillian Angel
Here is another editing fix. 2005-11-25 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalFileChooserUI.java (mouseClicked): Fixed to keep track of last object clicked, instead of index. Problems arise when lists change for different directories and

Re: [cp-patches] RFC: BasicTabbedPaneUI paint null Icon?

2005-11-25 Thread Roman Kennke
Am Freitag, den 25.11.2005, 14:58 +0100 schrieb Mark Wielaard: Hi, On Tue, 2005-11-22 at 01:03 +0100, Mark Wielaard wrote: This one is a little strange. Apparently the plastic laf overrides getIconForTab(int) and returns null in certain cases. But then it still calls paintIcon on it. I

[Fwd: Re: [cp-patches] Comparable in java.util.Calendar]

2005-11-25 Thread Kendall Bell
Original Message From: - Thu Nov 24 10:35:50 2005 X-Account-Key: account2 X-UIDL: 20051124083124F859 X-Mozilla-Status: 0011 X-Mozilla-Status2:

[cp-patches] [generics] Patch: FYI: genericize javax.swing

2005-11-25 Thread Tom Tromey
I'm checking this in on the generics branch. This genericizes javax.swing. The only real oddity is the patch to ContentModel.getElements(). Could someone more swing-knowledgeable take a quick look at this and see whether it is correct? Let me know if it is not and I will clean it up. (It did