[cp-patches] [generics] Patch: FYI: generics -vs- javax.sound.sampled

2005-12-02 Thread Tom Tromey
I'm checking this in on the generics branch. javax.sound.sampled was merged to the generics branch after my last round of genericization. This patch fixes it up. Tom 2005-12-02 Tom Tromey <[EMAIL PROTECTED]> * javax/sound/sampled/Port.java (Info): Genericized. * javax/sound/s

[cp-patches] [generics] Patch: FYI: javax.naming generics cleanups

2005-12-02 Thread Tom Tromey
I'm checking this in on the generics branch. The 1.5 japi results seem to lag cvs by a couple of days. I found these missing genericizations when looking through the results today. Unfortunately due to the lag it is kind of hard to tell what is really unfinished; some of the things it claims are

[cp-patches] FYI: InternationalFormatter fixlet

2005-12-02 Thread Anthony Balkissoon
Small fixlet for InternationalFormatter. 2005-12-02 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/text/InternationalFormatter.java: (valueToString): If argument is null return empty String. --Tony Index: javax/swing/text/InternationalFormatter.java ==

[cp-patches] Re: Patch: fix alsa configury for systems with multilibs

2005-12-02 Thread Tom Tromey
> "Anthony" == Anthony Green <[EMAIL PROTECTED]> writes: Anthony> It's not enough to test that the alsa headers exist. We also Anthony> need to make sure the libraries are there. This was a Anthony> problem for x86-64 linux. Anthony> Ok for everywhere? We talked on irc, but just for the rec

Re: [Fwd: Re: [cp-patches] Comparable in java.util.Calendar]

2005-12-02 Thread Mark Wielaard
Hi Kendall, > On Tue, 2005-11-22 at 09:55 -0600, Kendall Bell wrote: > > 2005-11-21 Kendall Bell <[EMAIL PROTECTED]> > > > > * java/util/Calendar.java: > > Implemented Comparable. > > (compareTo) Method added. > > Thanks. Could you also email that to the classpath-patches list so >

Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

2005-12-02 Thread Nicolas Geoffray
Mark Wielaard wrote: Yes, but it makes it easier to share code with ClassLoader and VMClassLoader if we do this. Then callTransformers doesn't have to be public, but can just be package private. Then we don't have to worry about whether or not someone can get insecure access to a IntrumentationI

Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

2005-12-02 Thread Mark Wielaard
Hi Nicolas, On Fri, 2005-12-02 at 12:22 +0100, Nicolas Geoffray wrote: > >Aha. Sorry I missed the dual nature of the > >ClassFileTransFormer.transform() method. I see you documented this in > >your original patch. In that case I really do think we should move these > >to vm/reference/java/lang and

[cp-patches] Patch: More JFormattedTextField implementations and fixes

2005-12-02 Thread Anthony Balkissoon
This is the last big part of JFormattedTextField I was working on. It implements all the parts that were throwing InternalError ("not implemented") and fixes a lot of bugs with how we were generating formatters and formatter factories. It also implements missing parts of JFormattedTextField.Abstr

Re: [cp-patches] FYI: Fixes in org.omg.CORBA.Object._is_equivalent.

2005-12-02 Thread Mark Wielaard
Hi Audrius, Going through some older patches. On Sun, 2005-11-06 at 14:24 +0100, Meskauskas Audrius wrote: > + /** > + * Get the hashcode of this IOR. > + */ > + public int hashCode() > + { > +Adler32 adler = new Adler32(); > +if (key != null) > + adler.update(key); > +if

Re: [cp-patches] Patch: Implementing non-abstract members on abstract X509Certificate and correcting GeneralName OtherName parsing

2005-12-02 Thread Mark Wielaard
Hi, On Thu, 2005-12-01 at 21:18 -0800, Casey Marshall wrote: > This patch looks good to me. Do you have a copyright assignment on > file for Classpath? No, I'll sent Rafael the request forms. Most of this is small/obvious and can be applied when we change it to our coding style though. But for

Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

2005-12-02 Thread Nicolas Geoffray
Hi Mark, Mark Wielaard wrote: My idea was even that a VM might only want to have one redefine prepare/apply cycle running at the same time. Then it can easily cleanup anything not used. But this might be optimizing for an unusual case. We can probably assume that transformers will actually tra

[cp-patches] Re: FYI: GtkSelection.c LocalRef cleanup

2005-12-02 Thread Christian Thalinger
On Tue, 2005-11-29 at 14:21 +0100, Mark Wielaard wrote: > On Tue, 2005-11-29 at 14:10 +0100, Mark Wielaard wrote: > > On Sat, 2005-11-26 at 14:19 +0100, Christian Thalinger wrote: > > > The line where it's out of local refs is: > > > > > > #2 0x2b4f5c01 in clipboard_targets_received (clip