Re: [cp-patches] FYI: New BasicLookAndFeel methods

2005-12-16 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> Note that for real acoustic feedback we still need to fix the Roman> UI classes to trigger these methods on certain events and of Roman> course we need some javax.sound.sampled provider and some audio Roman> files :-(. Would you min

[cp-patches] FYI: New BasicLookAndFeel methods

2005-12-16 Thread Roman Kennke
I implemented some missing methods in javax.swing.plaf.basic.BasicLookAndFeel. This are the three audio related methods that can be used to implement acoustic feedback for look and feels. Note that for real acoustic feedback we still need to fix the UI classes to trigger these methods on certain ev

[cp-patches] FYI: New JTable methods

2005-12-16 Thread Roman Kennke
I implemented the remaining missing methods in javax.swing.JTable. These are the last missing methods in the javax.swing package wrt JDK1.4 completeness. :-D 2005-12-16 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTable.java (AccessibleJTable.getAccessibleRowAtIndex): New met

[cp-patches] FYI: SwingUtilities.processKeyBindings() implemented

2005-12-16 Thread Roman Kennke
Hi, thanks to the work done by Anthony Balkissoon (KeyboardManager) I finally could make some sense out of the method SwingUtilities.processKeyBindings() which previously caused headaches to me :-) What I think what this method actually should do (and this is how I implemented it) is, that it pro

[cp-patches] Re: [commit-cp] classpath ./ChangeLog vm/reference/gnu/classpat...

2005-12-16 Thread Keith Seitz
Mark Wielaard wrote: Please fix. Indeed! I got a little ahead of myself. I've committed the attached patch which should fix it. (This time I even waited for the build to finish. O:-) Keith 2005-12-16 Keith Seitz <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/EventManager.java (

[cp-patches] RFC : modifiers in java/lang/Class

2005-12-16 Thread Nicolas Geoffray
Hi, The access flag of a class might have the synchronized bit set, even if it's not appropriate for a class. The java file attached prints "public synchronized" as modifiers with jamvm, whereas it prints "public" with sun. This patch just changes the return of Class.getModifiers to return onl

Re: [cp-patches] [PATCH/JDWP] VMVirtualMachine methods throw common exception

2005-12-16 Thread Mark Wielaard
Hi Keith, On Fri, 2005-12-16 at 13:04 -0800, Keith Seitz wrote: > I've been hoarding several classpath patches w.r.t. JDWP while I've been > away, and I think it is time I start committing some of them before > they get out of hand. [Of course, it should also help to put some > people's minds

[cp-patches] Re: [commit-cp] classpath ./ChangeLog vm/reference/gnu/classpat...

2005-12-16 Thread Mark Wielaard
Hi Keith, On Fri, 2005-12-16 at 21:04 +, Keith Seitz wrote: > * vm/reference/gnu/classpath/jdwp/VMVirtualMachine.java > (VMVirtualMachine): All methods now throw JdwpException. That breaks the build since JdwpException is a checked exception and we now have several places that cal

[cp-patches] FYI: Api doc updates for IntegerSyntax based printing attributes.

2005-12-16 Thread Wolfgang Baer
Hi all, only api doc updates except one minor fix to return the correct name of the attribute class. Regards, Wolfgang 2005-12-16 Wolfgang Baer <[EMAIL PROTECTED]> * javax/print/attribute/standard/JobImpressionsCompleted.java: Added and updated javadocs to class and m

[cp-patches] Patch: StyledEditorKit fix

2005-12-16 Thread Lillian Angel
Fixed a few things that differed from what the API stated. 2005-12-16 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/text/StyledEditorKit.java (createInputAttributes): This should copy the element attributes into the set, not clear out the set. Fixed to match th

[cp-patches] Patch: HTML default StyleSheet

2005-12-16 Thread Lillian Angel
Implemented more of HTML to use the default style sheet. I have, also, created/committed the default style sheet (default.css) with all the correct values. 2005-12-16 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/text/html/HTMLDocument.java (HTMLDocument): Fixed. The style she

[cp-patches] [PATCH/JDWP] VMVirtualMachine methods throw common exception

2005-12-16 Thread Keith Seitz
Hi, I've been hoarding several classpath patches w.r.t. JDWP while I've been away, and I think it is time I start committing some of them before they get out of hand. [Of course, it should also help to put some people's minds at some ease -- as far as I know, neither I nor Red Hat has yet ab

Re: [cp-patches] RFC: new VM interface for Socket impls

2005-12-16 Thread Guilhem Lavaux
Hi Roman, I have a few problem concerning the VM interface. 1) accept() & close() may be called at the same time. Calling close() in another thread should stop the accept() call this is perfectly valid and implemented in kaffe/gcj/jdk. I know that in general we must authorize the user to use

[cp-patches] FYI: Patch for EnumSyntax attributes in the print api

2005-12-16 Thread Wolfgang Baer
Hi all, this patch completes the classes extending javax.print.attribute.EnumSyntax which are needing some methods to be overriden. There are also several fixes found during work on the internals. Regards, Wolfgang 2005-12-16 Wolfgang Baer <[EMAIL PROTECTED]> * javax/print/attribu

[cp-patches] FYI: Removed java_nio.c

2005-12-16 Thread Roman Kennke
I removed this obsolete file. According to ChangeLog-2003 it was excluded from compilation since 2003-07-02 by Michael. 2005-12-16 Roman Kennke <[EMAIL PROTECTED]> * native/jni/java-nio/java_nio.c Removed obsolete file. /Roman ___

[cp-patches] Patch: FYI: javadoc fix in Class

2005-12-16 Thread Tom Tromey
I'm checking this in. This updates some javadoc in java.lang.Class to more accurately reflect reality. Tom 2005-12-16 Tom Tromey <[EMAIL PROTECTED]> * java/lang/Class.java (getPackage): Javadoc fix. Index: java/lang/Class.java =

[cp-patches] FYI: Fix for __attribute__ handling

2005-12-16 Thread Roman Kennke
In jcl.c we redefine __attribute__(x) for non-GCC compilers. This can be improved a little by redefining it only if it's not already defined. 2005-12-16 Roman Kennke <[EMAIL PROTECTED]> * native/jni/classpath/jcl.c: Only redefine __attribute__ if it's not already defined. /Roma

[cp-patches] FYI: DatagramSocket fix

2005-12-16 Thread Roman Kennke
Hi, the DatagramSocket supports setting a factory for DatagramSocketImpls, but seems to never actually use it. This patch fixes this. A mauve test is following soon. 2005-12-16 Roman Kennke <[EMAIL PROTECTED]> * java/net/DatagramSocket.java (DatagramSocket(SocketAddress)): Actu

[cp-patches] Patch: FYI: warning fixlet

2005-12-16 Thread Tom Tromey
I'm checking this in. This fixes a warning in the core that I happened to come across. (I try to keep java.lang and other core packages more or less warning free in the Eclipse build...) Tom 2005-12-16 Tom Tromey <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java: Organized imports

Re: [cp-patches] RFC: new VM interface for Socket impls

2005-12-16 Thread Roman Kennke
Hi there, I have put together a new proposal for the VM interface for Plain(Datagram)SocketImpl. I incorporated most of Marks suggestions. Also I introduced an optimization for VMPlainDatagramSocketImpl.receive() which turns out to be significantly faster than before because it avoids copying stuf

Re: [cp-patches] RFC: new VM interface for Socket impls

2005-12-16 Thread Roman Kennke
Hi Mark, Am Mittwoch, den 07.12.2005, 13:35 +0100 schrieb Mark Wielaard: > On Fri, 2005-11-11 at 17:53 +0100, Mark Wielaard wrote: > > On Wed, 2005-11-09 at 21:16 +, Roman Kennke wrote: > > > Ingo has abstracted out the native code from gnu.java.net.PlainSocketImpl > > > and gnu.java.net.Plain