RE: [cp-patches] RFC: Hashtable cleanup

2006-01-10 Thread Jeroen Frijters
Roman Kennke wrote: > I would like to propose the following patch that was written by my > collegue Fridjof. Basically, it replaces the parameterized > Iterator and Enumerator classes with normal classes for values/entries/keys. Thank you! This is much better than before. Regards, Jeroen _

Re: [cp-patches] FYI: Define isnan explicitly in fdlibm

2006-01-10 Thread Christian Thalinger
On Sat, 2005-12-17 at 21:43 +0100, Guilhem Lavaux wrote: > Hi, > > Here is a patch to define isnan explicitly as a macro if it is not > already defined. At the same it removes the symbol renaming in namespace.h. Hi! As i merged the changes into CACAO, i noticed that this patch breaks some stuff

[cp-patches] FYI: major DefaultStyledDocument.ElementBuffer improvements

2006-01-10 Thread Anthony Balkissoon
More improvements to DefaultStyledBuffer and its ElementBuffer class. I also currently have 6 detailed tests that I'm running which will be converted into Mauve tests to support these classes. Work still needs to be done, the ElementBuffer.insertUpdate rewrite is not perfect yet, and DefaultSty

Re: [cp-patches] RFC: gnu.regexp fix to allow "([(])"

2006-01-10 Thread Tom Tromey
> "Ito" == Ito Kazumitsu <[EMAIL PROTECTED]> writes: Ito> ChangeLog: Ito> 2006-01-10 Ito Kazumitsu <[EMAIL PROTECTED]> Ito>Fixes bug #22802 Ito>* gnu/regexp/RE.java(initialize): Fixed the parsing of Ito>character classes within a subexpression. I think it is awesome that you're

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Mark Wielaard
On Tue, 2006-01-10 at 19:00 +0100, Christian Thalinger wrote: > On Tue, 2006-01-10 at 18:28 +0100, Mark Wielaard wrote: > > libgcj installs it as: > > propdir = $(libdir) > > > > $(INSTALL_DATA) $(srcdir)/java/util/logging/logging.properties > > $(DESTDIR)$(propdir)/logging.properties > > > > Th

Re: [cp-patches] FYI: Wrap over the ChangeLog

2006-01-10 Thread Mark Wielaard
Hi Roman, On Tue, 2006-01-10 at 16:09 +0100, Roman Kennke wrote: > I moved all the ChangeLog entries of 2005 into ChangeLog-2005, as was > done the years before. Thanks! It seems we have been almost twice as busy in 2005: ChangeLog-2004 666K (1545 entries ~= 4.2 commits/day) ChangeLog-2005 1.2M

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Christian Thalinger
On Tue, 2006-01-10 at 18:28 +0100, Mark Wielaard wrote: > libgcj installs it as: > propdir = $(libdir) > > $(INSTALL_DATA) $(srcdir)/java/util/logging/logging.properties > $(DESTDIR)$(propdir)/logging.properties > > That seems a better place. But it looks like we have to update > LogManager in t

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Mark Wielaard
Hi Christian, On Tue, 2006-01-10 at 16:56 +0100, Christian Thalinger wrote: > On Tue, Jan 10, 2006 at 04:47:41PM +0100, Mark Wielaard wrote: > > * If the system property java.util.logging.config.file > > * is not set, however, the contents of the URL > > * "{gnu.classpath.home.url}/logg

Re: [cp-patches] FYI: StringTokenizer fixlet

2006-01-10 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> In the java.util.StringTokenizer we trigger an NPE if delim is null. The Roman> spec explicitly says, that we shouldn't do so, and Sun's impl Roman> doesn't. This patch fixes this. I didn't look, but a mauve test for this would be g

[cp-patches] RFC: gnu.regexp fix to allow "([(])"

2006-01-10 Thread Ito Kazumitsu
This fixes the bug #22802. ChangeLog: 2006-01-10 Ito Kazumitsu <[EMAIL PROTECTED]> Fixes bug #22802 * gnu/regexp/RE.java(initialize): Fixed the parsing of character classes within a subexpression. Index: classpath/gnu/regexp/RE.java =

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Mark Wielaard
Hi Christian, On Tue, 2005-07-19 at 21:27 +0200, Christian Thalinger wrote: > Shouldn't the logging.properties file be installed instead of packaged > into glibj.zip? Here is a patch for the resources Makefile. The file > still added to glibj.zip, but this shouldn't be a problem. According to Log

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Christian Thalinger
On Tue, Jan 10, 2006 at 04:47:41PM +0100, Mark Wielaard wrote: > * If the system property java.util.logging.config.file > * is not set, however, the contents of the URL > * "{gnu.classpath.home.url}/logging.properties" are passed to > * [EMAIL PROTECTED] #readConfiguration(java.io.I

[cp-patches] RFC: Hashtable cleanup

2006-01-10 Thread Roman Kennke
Hi there, I would like to propose the following patch that was written by my collegue Fridjof. Basically, it replaces the parameterized Iterator and Enumerator classes with normal classes for values/entries/keys. The EntryIterator and EntryEnumerator are just like the previous HashIterator and Enu

Re: [cp-patches] FYI: First class for javax.management.

2006-01-10 Thread Meskauskas Audrius
There are very many various classes, methods and fields with names, containing underscores in the official org.omg namespace (see org.omg.PortableInterceptor.IORInterceptor_3_0Operations for instance). Hence we must use them anyway. I am not sure if the underscores are really bad for separatin

[cp-patches] FYI: ChangeLog-2005

2006-01-10 Thread Roman Kennke
I included the ChangeLog-2005 in the Makefile.am, so that it will be shipped in releases. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * Makefile.am (EXTRA_DIST): Added ChangeLog-2004. * ChangeLog-2005: New File. /Roman Index: Makefile.am

[cp-patches] FYI: Wrap over the ChangeLog

2006-01-10 Thread Roman Kennke
Hi there, I moved all the ChangeLog entries of 2005 into ChangeLog-2005, as was done the years before. /Roman ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] FYI: Another ViewportLayout fix

2006-01-10 Thread Roman Kennke
I had to fix the condition in ViewportLayout.layoutContainer() again, in order to avoid a ClasscastException. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/ViewportLayout.java (layoutContainer): Fixed condition, to avoid ClasscastException. /Roman Index: javax/swing

[cp-patches] FYI: RepaintManager fix

2006-01-10 Thread Roman Kennke
I fixed a condition in RepaintManager.validateInvalidComponents() to avoid an NPE. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/RepaintManager.java (validateInvalidComponents): Fixed condition to avoid NPE. /Roman Index: javax/swing/RepaintManager.java

[cp-patches] VMDirectByteBuffer fixes

2006-01-10 Thread Roman Kennke
In VMDirectByteBuffer.c we have two mistakes. - In get() and put() we call ReleaseByteArrayElements() with the wrong pointer because we add the offset directly after GetByteArrayElements(). - In put() we copy something into the array after it is released. Both are fixed with the attached patch.

[cp-patches] FYI: ViewportLayout fix

2006-01-10 Thread Roman Kennke
Hi there, This ViewportLayout fix makes Scrollable view components always have the viewport size, when they return true on getScrollableTracksViewportHeight() and ...Width(), independent of their preferred size. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/ViewportLayout.j

[cp-patches] FYI: BasicListUI API doc fixlet

2006-01-10 Thread Roman Kennke
I added a @since to BasicListUI.playSound. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicLookAndFeel.java (playSound): Added @since 1.4 to the API docs. /Roman Index: javax/swing/plaf/basic/BasicLookAndFeel.java ==

[cp-patches] FYI: BasicListUI fixlet

2006-01-10 Thread Roman Kennke
Hi there, this makes the BasicListUI update its layout also when the list itself has been invalidated since the last update. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicListUI.java (maybeUpdateLayoutState): Also update the layout state, if the

[cp-patches] FYI: JViewport fixlet

2006-01-10 Thread Roman Kennke
Index: javax/swing/JViewport.java === RCS file: /cvsroot/classpath/classpath/javax/swing/JViewport.java,v retrieving revision 1.38 diff -u -r1.38 JViewport.java --- javax/swing/JViewport.java 19 Dec 2005 13:12:15 - 1.38 +++ javax/s

[cp-patches] FYI: API docs fix for JTabbedPane

2006-01-10 Thread Roman Kennke
I improved the API docs for JTabbedPane a little. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: Cleared API docs a little. /Roman Index: javax/swing/JTabbedPane.java === RCS file: /cvs

[cp-patches] FYI: BasicSplitPaneDivider indendantion fixlet

2006-01-10 Thread Roman Kennke
This fixes two little indendantion mistakes in the BasicSplitPaneUI. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicSplitPaneDivider.java (MouseHandler.mousePressed): Fixed indendation. (MouseHandler.mouseDragged): Fixed indendation. /Roman In

[cp-patches] FYI: GdkGraphics2D NPE fix

2006-01-10 Thread Roman Kennke
I added a null check in the GdkGraphics2D constructor to avoid an NPE if the source GdkGraphics2D object has a null bg field. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GdkGraphics2D.java (GdkGraphics2D(GdkGraphics2D)): Added null check for the bg

[cp-patches] FYI: ComponentUI indendation fixlet

2006-01-10 Thread Roman Kennke
I fixed a little indendation mistake in javax.swing.plaf.ComponentUI. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/ComponentUI.java (update): Fixed indendation. /Roman Index: javax/swing/plaf/ComponentUI.java ==

Re: [cp-patches] FYI: implemented rest of EventSetDescriptor

2006-01-10 Thread Robert Schuster
Hi Mark, something is wrong with the overal formatting of this class anyway. I'll fix this. cya Robert Mark Wielaard wrote: > Hi Robert, > > On Tue, 2006-01-10 at 00:35 +0100, Robert Schuster wrote: > >>2006-01-09 Robert Schuster <[EMAIL PROTECTED]> >> >>* java/beans/EventSetDescript

[cp-patches] FYI: StringTokenizer fixlet

2006-01-10 Thread Roman Kennke
In the java.util.StringTokenizer we trigger an NPE if delim is null. The spec explicitly says, that we shouldn't do so, and Sun's impl doesn't. This patch fixes this. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * java/util/StringTokenizer.java (StringTokenizer(String, String, bo

Re: [cp-patches] FYI: implemented rest of EventSetDescriptor

2006-01-10 Thread Mark Wielaard
Hi Robert, On Tue, 2006-01-10 at 00:35 +0100, Robert Schuster wrote: > 2006-01-09 Robert Schuster <[EMAIL PROTECTED]> > > * java/beans/EventSetDescriptor.java: Implemented the two 1.4 > constructors. > (getGetListenerMethod): New method. Thanks, cool. A few minor forma

[cp-patches] FYI: reformatted EventSetDescriptor

2006-01-10 Thread Robert Schuster
Hi, I reformatted the EventSetDescriptor class, fixed its API doc a bit and corrected the copyright year. Yay, this class was last touched in 1998! 2006-01-10 Robert Schuster <[EMAIL PROTECTED]> * java/beans/EventSetDescriptor.java: Reformatted and fixed API docs. cya Robert I

[cp-patches] FYI: SecurityManager API doc fix

2006-01-10 Thread Roman Kennke
Hi, In the java.lang.SecurityManager we import some AWT classes, only for some API docs references. I removed those imports and instead fully qualified those references. This was necessary, because we want to do AWT-less builds, and importing a class makes the compiler want this class present, wh

[cp-patches] FYI: ArrayList fixlet

2006-01-10 Thread Roman Kennke
Hi, The java.util.ArrayList is specified to have a default capacity of 10, we had implemented 16 there. This patch fixes this. 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * java/util/ArrayList.java (DEFAULT_CAPACITY): Changed default capacity to 10, as specified. /Roman Index:

[cp-patches] FYI: javanet.c portability fix

2006-01-10 Thread Roman Kennke
Hi, I replaced two occurances of strerror() in javanet.c with the corresponding target native macro, in order to make this file compile on platforms that don't have strerror() (in this case, WindowsCE). 2006-01-10 Roman Kennke <[EMAIL PROTECTED]> * native/jni/java-net/javanet.c

[cp-patches] FYI: implemented last EventSetDescriptor method

2006-01-10 Thread Robert Schuster
Hi, this is the method I forgot in the last patch. 2006-01-10 Robert Schuster <[EMAIL PROTECTED]> * java/beans/EventSetDescriptor.java: (getGetListenerMethod): New method. cya Robert Index: java/beans/EventSetDescriptor.java =

[cp-patches] FYI: implemented rest of EventSetDescriptor - NOTE

2006-01-10 Thread Robert Schuster
Hi, for some unknown reasons this patch did not contain the getGetListenerMethod. I fix the ChangeLog to: 2006-01-09 Robert Schuster <[EMAIL PROTECTED]> * java/beans/EventSetDescriptor.java: Implemented the two 1.4 constructors. cya Robert Index: java/beans/EventSetDescriptor

[cp-patches] FYI: Make sure we have linenumber info with gcjx

2006-01-10 Thread Mark Wielaard
Hi, gcjx needs an explicit -g to generate linenumber info. This patch makes it so: 2006-01-10 Mark Wielaard <[EMAIL PROTECTED]> * lib/Makefile.am (GCJX): Add -g to get linenumber info. Committed, Mark --- lib/Makefile.am 3 Jan 2006 12:33:24 - 1.108 +++ lib/Makefile.am

Re: [cp-patches] FYI: First class for javax.management.

2006-01-10 Thread Chris Burdess
Meskauskas Audrius wrote: > /** >* The attribute name. >*/ > final String m_name; > > /** >* The attribute value. >*/ > final Object m_value; Do we really need all this "m_*" Hungarian notation business? We don't use this form (or indeed underscores at all) anywhere else i

[cp-patches] FYI: Hashtable fix for PR 25727

2006-01-10 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2006-01-09 Jeroen Frijters <[EMAIL PROTECTED]> PR classpath/25727 * java/util/Hashtable.java (contains): Call equals on existing value. (containsKey, get, put, remove): Call equals on existing key. (getEntry): Call equals