Re: [cp-patches] FYI: major DefaultStyledDocument.ElementBuffer improvements

2006-01-11 Thread Mark Wielaard
Hi Tony, On Tue, 2006-01-10 at 16:49 -0500, Anthony Balkissoon wrote: Work still needs to be done, the ElementBuffer.insertUpdate rewrite is not perfect yet, and DefaultStyledDocument.insertUpdate is correct (to my knowledge) but incomplete. 2006-01-10 Anthony Balkissoon [EMAIL

Re: [cp-patches] RFC: Hashtable cleanup

2006-01-11 Thread Tom Tromey
Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman So, should I check this in? Yes, but... Roman +if (idx = 0) /* added this test to avoid Roman + * ArrayIndexOutOfBounds when Hashtable is Roman + * modified concurrently, return null in

Re: [cp-patches] RFC: Hashtable cleanup

2006-01-11 Thread Roman Kennke
Hi Tom, Am Mittwoch, den 11.01.2006, 11:19 -0700 schrieb Tom Tromey: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman So, should I check this in? Yes, but... Roman + if (idx = 0) /* added this test to avoid Roman + * ArrayIndexOutOfBounds when Hashtable

[cp-patches] Patch: DefaultStyledDocument fixlet

2006-01-11 Thread Lillian Angel
This fixes the ElementSpec Tag Type problem. Since the resolve parent was being set; the attribute sets between ElementSpecs were not being compared properly. 2006-01-11 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java (toString): Shouldn't append

Re: [cp-patches] RFC: gnu.regexp fix to allow ([(])

2006-01-11 Thread Mark Wielaard
Hi Tom, On Tue, 2006-01-10 at 13:14 -0700, Tom Tromey wrote: Anyway, last night I was wondering whether there are regex test suites that we could reuse... like maybe from perl or Henry Spencer or something like that. There is the prce test-suite (. And Ziga turned that into a Mauve test. See

Re: [cp-patches] RFC: gnu.regexp fix to allow ([(])

2006-01-11 Thread Tom Tromey
Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark There is the prce test-suite (. And Ziga turned that into a Mauve test. Sigh. I didn't even think to look first. Thanks. Tom ___ Classpath-patches mailing list Classpath-patches@gnu.org

Re: [cp-patches] RFC: Hashtable cleanup

2006-01-11 Thread Roman Kennke
Hi Tom, I applied your suggested changes and committed the attached patch. I am going to commit the mentioned mauve test now. 2006-01-11 Roman Kennke [EMAIL PROTECTED] Reported by: Fridjof Siebert [EMAIL PROTECTED] * java/util/Hashtable.java (KEYS): Removed unneeded

[cp-patches] FYI: More DefaultStyledDocument ElementBuffer fixes

2006-01-11 Thread Anthony Balkissoon
This patch fixes more issues with the ElementBuffer. 2006-01-11 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java: (ElementBuffer.insertUpdate): Properly recreate Elements if the first tag is an end tag. Avoid NPE by pushing the proper

[cp-patches] FYI: Another DefaultStyledDocument ElementBuffer fix

2006-01-11 Thread Anthony Balkissoon
These changes to DefaultStyledDocument make all the local tests I have here pass. I will commit these tests to Mauve now. The number one outstanding problem with DefaultStyledDocument and ElementBuffer is the way DocumentEvents are handled and marked up. Lillian is working on that right now,

[cp-patches] DefaultStyledDocument insertFracture fix

2006-01-11 Thread Lillian Angel
Added the addEdit calls in insertFracture. Now, this correctly updates the document structure when a fracture is inserted. 2006-01-11 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java (insertFracture): Added calls to addEdit for each time a

[cp-patches] Patch: RFC: remove InetAddress caching

2006-01-11 Thread Tom Tromey
I'm not checking this in yet -- I would like comments first. I happened to run across the caching code in java.net.InetAddress today. We had a couple discussions about this already in the past, e.g. one is here: http://gcc.gnu.org/ml/java/2000-04/msg00106.html I still think this code is

Re: [cp-patches] Patch: RFC: remove InetAddress caching

2006-01-11 Thread Archie Cobbs
Tom Tromey wrote: I'm not checking this in yet -- I would like comments first. I happened to run across the caching code in java.net.InetAddress today. We had a couple discussions about this already in the past, e.g. one is here: http://gcc.gnu.org/ml/java/2000-04/msg00106.html I still think

Re: [cp-patches] Patch: RFC: remove InetAddress caching

2006-01-11 Thread David Daney
Tom Tromey wrote: I'm not checking this in yet -- I would like comments first. I happened to run across the caching code in java.net.InetAddress today. We had a couple discussions about this already in the past, e.g. one is here: http://gcc.gnu.org/ml/java/2000-04/msg00106.html I still think