[cp-patches] FYI:Rewriting JTable.rowAtPoint

2006-01-19 Thread Audrius Meskauskas
This rewrites the rowAtPoint method in JTable, replacing loop by division. The table may have 2 rows or about (only part visible in the scroll pane). Hence the loop delay may already be significant. 2006-01-19 Audrius Meskauskas <[EMAIL PROTECTED]> * javax/swing/JTable.java (rowAtPoint):

[cp-patches] FYI: more JWindow constructor fixes

2006-01-19 Thread Roman Kennke
I fixed the remaining JWindow constructors to also accept null owner arguments. This involved modifying the SwingUtilities.getOwnerFrame() signature once more, and adding casts to the statements that call this method. 2006-01-19 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JWindow.jav

[cp-patches] FYI: Some swing fixes

2006-01-19 Thread Roman Kennke
Hi, this fixes an issue I had with JWindow. The constructor JWindow(Frame) is allowed to take a null parameter and in that case should install a shared owner frame (as returned by SwingUtilites.getOwnerFrame). However, the implementation of this is a little tricky, since the super class does not a

[cp-patches] FYI: JTable cleanup.

2006-01-19 Thread Audrius Meskauskas
This patch adds comments to the uncommented methods and removes the currently unused EditorUpdateTimer inner class. 2006-01-19 Audrius Meskauskas <[EMAIL PROTECTED]> * javax/swing/JTable.java: Commenting method headers. (EditorUpdateTimer): Removed. Index: JTable.java

[cp-patches] FYI: JWindow API docs

2006-01-19 Thread Roman Kennke
I added some API docs to the JWindow constructors. 2006-01-19 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JWindow.java: Added API docs to the constructors. /Roman Index: javax/swing/JWindow.java === RCS file: /cvsroot/c

[cp-patches] FYI: JOptionPane fixlet

2006-01-19 Thread Roman Kennke
In my last commit I forgot to adjust the JOptionPane to the new SwingUtilities.getOwnerFrame() signature. This is done by this patch. 2006-01-19 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JOptionPane.java Added cast to Frame for JDialog constructor. /Roman Index: javax/swin

[cp-patches] FYI: SwingFramePeer fix

2006-01-19 Thread Roman Kennke
This fixes the handling of mouse events for the SwingFramePeer. The previous implementation was mostly bogus and cause NPEs and whatnot. This is now checked correctly and the mouse event gets translated when there is a menu bar so that it gets dispatched with the correct coordinates. 2006-01-19 R

[cp-patches] FYI: Bugfix for target layer

2006-01-19 Thread Roman Kennke
Hi, I added the missing function targetGenericMisc_formatString() that somehow got lost. 2006-01-19 Roman Kennke <[EMAIL PROTECTED]> * native/target/generic/target_generic_misc.c: (targetGenericMisc_formatString): Added missing method. /Roman Index: native/target/generic/targe

Re: [cp-patches] FYI: Remove (bogus) asserts in java-net.

2006-01-19 Thread Mark Wielaard
Hi Roman, On Thu, 2006-01-19 at 11:18 +0100, Roman Kennke wrote: > Granted, the example is a little constructed. The point is not if you > get the crash in f2() anyway. The point is that the asserts help you > find the actual bug. In a real world environment you may trash the stack > anywhere, not

Re: [cp-patches] Re: [commit-cp] classpath ChangeLog configure.ac

2006-01-19 Thread Mark Wielaard
Hi, On Thu, 2006-01-19 at 08:55 -0700, Tom Tromey wrote: > After seeing this patch I noticed that we don't have a place where our > configure options are documented in full. It seems like this would be > nice... from the name it is unclear when I would want to use this. We have a list in the INS

Re: [cp-patches] RFC: configure fixlet

2006-01-19 Thread Wolfgang Baer
Mark Wielaard wrote: Hi Wolfgang, On Mon, 2006-01-16 at 09:46 +0100, Wolfgang Baer wrote: if only ecj is available currently configure breaks because we don't test for a found ecj in the error test. Tested on my local box. 2006-01-16 Wolfgang Baer <[EMAIL PROTECTED]> * m4/acinclude

Re: [cp-patches] FYI: Remove (bogus) asserts in java-net.

2006-01-19 Thread Tom Tromey
> "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: Mark> I find the example a bit contrived. You will get a crash anyway in f2() Mark> since you trashed env and are using it. Yes... let's not talk about asserts in the abstract. I don't think that sheds much light. >> > assert((*env)->G

Re: [cp-patches] Re: [commit-cp] classpath ChangeLog configure.ac

2006-01-19 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> Whoops, this was a kind of accident. The patch wasn't really complete Roman> and even worse, the posix layer also isn't (it does not compile yet). Roman> The intention was to add a switch to the configury which enables the Roman> pos

[cp-patches] RFC: gnu.regexp: fixed bugs in RETokenRepeated

2006-01-19 Thread Ito Kazumitsu
From: Ito Kazumitsu <[EMAIL PROTECTED]> Subject: Re: [cp-patches] RFC: gnu.regexp fix to avoid unwanted PatternSyntaxException Date: Thu, 19 Jan 2006 01:39:52 +0900 (JST) > From: Ito Kazumitsu <[EMAIL PROTECTED]> > Date: Thu, 05 Jan 2006 23:47:03 +0900 (JST) > > > + // doables.index == las

Re: [cp-patches] FYI: java-nio adjustments for target/native

2006-01-19 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> That would most likely cause problems on these ports. The specific Roman> problem is that these ports actually have a malloc() syscall, only that Roman> it doesn't really do what you would expect, and the macro works around Roman> th

FYI: Re: [cp-patches] Re: JamVM stopped working today

2006-01-19 Thread Christian Thalinger
Hi! The target native layer thing seems to be broken for non-linux architectures. This fixes the issue and defaults to TARGET=Linux, which is actually generic. This is commited. TWISTI 2006-01-19 Christian Thalinger <[EMAIL PROTECTED]> * configure.ac: Set TARGET to Linux per defaul

Re: [cp-patches] FYI: Remove (bogus) asserts in java-net.

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 02:12 +0100 schrieb Mark Wielaard: > Hi Roman, > > On Wed, 2006-01-18 at 12:20 +0100, Roman Kennke wrote: > > Am Donnerstag, den 12.01.2006, 10:36 +0100 schrieb Mark Wielaard: > > > Hi, > > > > > > The crashes we were seeing with the net code in Mauve were

Re: [cp-patches] Re: [commit-cp] classpath ChangeLog configure.ac

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 01:59 +0100 schrieb Mark Wielaard: > Hi Roman, > > On Wed, 2006-01-18 at 11:31 +, Roman Kennke wrote: > > CVSROOT:/cvsroot/classpath > > Module name:classpath > > Branch: > > Changes by: Roman Kennke <[EMAIL PROTECTED]>06/01/18

[cp-patches] RFC: Rewritten java.net.SocketPermission

2006-01-19 Thread Gary Benson
Hi all, I've been writing Mauve tests to try and figure out what the patch on PR classpath/24708 is all about and I figured it made things a little neater but didn't go nearly far enough. I gave up trying to rescue bits of it after a while and just wrote chunks of it from scratch. It's my first m

[cp-patches] FYI: Implementing multiple editors for JTable (with example)

2006-01-19 Thread Meskauskas Audrius
This patch add the multi-editor support for JTable. The table now supports the two editors: text and boolean. The boolean values are rendered and edited using JCheckBox. I add the more complicated table example to the Swing demo to show the table with header, multiple data types (text and boo

[cp-patches] FYI: Fixlet for target Makefile.am

2006-01-19 Thread Roman Kennke
In my last commit I made a little mistake. I added a conditional to the native/target/Makefile.am but didn't actually use it when putting together the SUBDIRS. This resulted in posix beeing build unconditionally which of course is wrong. This is fixed by the attached patch. 2006-01-19 Roman Kennk

Re: [cp-patches] FYI: java-util adjustments for target/native

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 02:02 +0100 schrieb Mark Wielaard: > Hi Roman, > > On Wed, 2006-01-18 at 10:19 +, Roman Kennke wrote: > > I checked in this adjustment for VMTimeZone.c to make use of the target > > native portability layer. > > > > 2006-01-18 Roman Kennke <[EMAIL PR

[cp-patches] Re: [commit-cp] classpath ChangeLog configure.ac

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 01:59 +0100 schrieb Mark Wielaard: > Hi Roman, > > On Wed, 2006-01-18 at 11:31 +, Roman Kennke wrote: > > CVSROOT:/cvsroot/classpath > > Module name:classpath > > Branch: > > Changes by: Roman Kennke <[EMAIL PROTECTED]>06/01/18

Re: [cp-patches] FYI: java-nio adjustments for target/native

2006-01-19 Thread Roman Kennke
Hi Tromey, Am Mittwoch, den 18.01.2006, 14:29 -0700 schrieb Tom Tromey: > > "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: > > Roman> Then we can use shorter macro names or even better function > Roman> calls like cp_mem_alloc() or something similar. > > Can we use the standard names, a

Re: [cp-patches] FYI: javanet.c fixes and improvements

2006-01-19 Thread Christian Thalinger
Hi! Not sure if it's related to this commit, but mips-irix does not work anymore: cc-1020 cc: ERROR File = javanet.c, Line = 1062 The identifier "MSG_NOSIGNAL" is undefined. TARGET_NATIVE_NETWORK_SOCKET_SEND (fd, p + offset, len, bytes_sent); ^ cc-1020 cc: ERROR File = jav