RE: [cp-patches] RFC: Introduction of VMMath

2006-02-07 Thread Jeroen Frijters
Robert Schuster wrote: > Nice work. I think the JNode guys will appreciate this. :) As do I! Regards, Jeroen

Re: [cp-patches] RFC: Introduction of VMMath

2006-02-07 Thread Andrew John Hughes
On Tue, 2006-02-07 at 00:20 +0100, Robert Schuster wrote: > Hi. > > Nice work. I think the JNode guys will appreciate this. :) > Yep, Ewout filed the bug. > > +package java.lang; > > + > > +import gnu.classpath.Configuration; > > + > > +class VMMath > > +{ > > + > > + static > > + { > > +

[cp-patches] FYI: Component fixes

2006-02-07 Thread Roman Kennke
Yesterday I added a couple of JDK1.5 firePropertyChange methods to java.awt.Component. I made them protected (copy+paste) but they should be public according to the specs. Why this is so is beyond me though... fixed by the attached patch. 2006-02-06 Roman Kennke <[EMAIL PROTECTED]> * ja

[cp-patches] FYI: JTextComponent.getSelectedText

2006-02-07 Thread Robert Schuster
Hi, I committed the following patch which fixes returning the selected text of a text component (tested for JTextField). 2006-02-07 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/JTextComponent.java: (getSelectedText): Calculate offset and use that as second argu

[cp-patches] FYI: JTextPane fixlet

2006-02-07 Thread Roman Kennke
This fixes a small issue in JTextPane which makes the BeanShell JConsole look a little nicer. 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTextPane.java (setCharacterAttributes): Replace input attributes when replace==true. /Roman Index: javax/swing/JTextP

[cp-patches] FYI: BasicTextUI cleanup

2006-02-07 Thread Roman Kennke
This cleans up the BasicTextUI a little (remove ECJ warnings, etc). 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTextUI.java (RootView.preferenceChange): Changed view parameter to view so that it doesn't hide a field of that class. (R

[cp-patches] FYI: DefaultStyledDocument.ElementBuffer fixlet

2006-02-07 Thread Roman Kennke
I adjusted the ElementBuffer.insert method so that it only registers an element change if that element has actually changed. It is required that DocumentEvent.getChange(Element) returns null for a not-changed element instead of an empty ElementChange. 2006-02-07 Roman Kennke <[EMAIL PROTECTED]>

[cp-patches] FYI: Added ASN.1 encoding/decoding support for DSS keys

2006-02-07 Thread Raif S. Naffah
hello there, the attached patch fixes a bug in the gnu.java.security.der.DERWriter class and adds support for encoding/decoding ASN.1 forms of the DSS keys. the ChangeLog is: 2006-02-07 Raif S. Naffah <[EMAIL PROTECTED]> * gnu/java/security/key/KeyPairCodecFactory.java (getEncodingN

[cp-patches] FYI: removed DefaultExceptionListener

2006-02-07 Thread Robert Schuster
Hi, a while ago (2006-31-01) I said I moved DefaulExceptionListener from gnu.java.beans.decoder one level up. While the new file is in place I forgot to remove the old one. This is fixed by this patch. I fixed the ChangeLog for that date as well. ChangeLog: 2006-02-07 Robert Schuster <[EMAIL

[cp-patches] FYI: View fixlet

2006-02-07 Thread Roman Kennke
The spec for javax.swing.text.View.forwardUpdate says that newly added child views should not be notified of updates (makes sense to me). This patch implements this. 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/View.java (forwardUpdate): Don't notify newly adde

[cp-patches] RFC: gnu.regexp: backslash escape in a replacement

2006-02-07 Thread Ito Kazumitsu
I added support for backslash escape in a replacement as an optional feature for fear that some application may depend on the current behavior of gnu.regexp. ChangeLog 2006-02-07 Ito Kazumitsu <[EMAIL PROTECTED]> Fixes bug #26112 * gnu/regexp/RE.java(REG_REPLACE_USE_BACKSLASHES

[cp-patches] RFC: new TextActions

2006-02-07 Thread Robert Schuster
Hi, I am starting to grok that swing stuff. :) I added TextAction implementations for selecting the current line (backward and forward), the whole text from the current position (backward & forward) and corrected the behavior of single character deletions when the text has a selection. Or textfi

Re: [cp-patches] RFC: new TextActions

2006-02-07 Thread Roman Kennke
Hi Robert, Am Dienstag, den 07.02.2006, 16:15 +0100 schrieb Robert Schuster: > Hi, > I am starting to grok that swing stuff. :) Great! Welcome in the Swing hacker boat. > I added TextAction implementations for selecting the current line (backward > and > forward), the whole text from the curren

[cp-patches] FYI: BasicTextUI fixes

2006-02-07 Thread Roman Kennke
Hi there, This fixes BasicTextUI.paint and related methods to conform with the specs. Most importantly, paint() must acquire a read lock on the document to prevent bad things to happen while painting. Also, update() must be overridden and paintBackground() implemented, so that the background paint

Re: [cp-patches] RFC: new TextActions

2006-02-07 Thread Anthony Balkissoon
On Tue, 2006-02-07 at 16:15 +0100, Robert Schuster wrote: > Hi, > I am starting to grok that swing stuff. :) > > I added TextAction implementations for selecting the current line (backward > and > forward), the whole text from the current position (backward & forward) and > corrected the behavior

Re: [cp-patches] RFC: new TextActions

2006-02-07 Thread Robert Schuster
Committed. Roman Kennke wrote: > Hi Robert, > > Am Dienstag, den 07.02.2006, 16:15 +0100 schrieb Robert Schuster: > >>Hi, >>I am starting to grok that swing stuff. :) > > > Great! Welcome in the Swing hacker boat. > > >>I added TextAction implementations for selecting the current line (backw

[cp-patches] FYI: CellRendererPane fixlet

2006-02-07 Thread Roman Kennke
I enclosed the actual painting/translating/etc in CellRendererPane.paintComponent() in a try-finally block to properly cleanup when something goes wrong. While this does not add super much value, it is still a little nicer than before. 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax

[cp-patches] FYI: UIManager fixlet

2006-02-07 Thread Roman Kennke
In UIManager we had a SwingPropertyChangeSupport typed field that I now made an instance of java.beans.PropertyChangeSupport (The SwingPropertyChangeSupport class has been obsoleted). 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/UIManager.java (listeners): Made this

Re: [cp-patches] RFC: new TextActions

2006-02-07 Thread Robert Schuster
Hi, > Looks fine. Except that I personally don't like all those anonymous > inner classes lined up in a huge(!) array. But that's how it was > implemented for the other actions, so this is ok. Please commit. Yes. They are evil. Maybe someone wants to go for that low hanging fruit: PR 26160 cya Ro

[cp-patches] FYI: GlyphView fix

2006-02-07 Thread Roman Kennke
This fixes GlyphView to return the correct indices for endOffset and startOffset. This makes it possible to remove text in styled text panes (BeanShell! yay ;-) ) without throwing loads of exceptions. 2006-02-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/GlyphView.java

[cp-patches] FYI: AbstractDocument fix

2006-02-07 Thread Roman Kennke
I fixed AbstractDocument.insertString to have the locking/unlocking in a try finally block for more robustness. Also, as pointed out in this fine article: http://java.sun.com/products/jfc/tsc/articles/text/concurrency/index.html the lock has to be held until all listeners are notified. 2006-02-07

[cp-patches] RFC: Checking in the tools subfolder

2006-02-07 Thread Audrius Meskauskas
The proposed patch creates the tools folder in the root of classpath. The folder currently contains the giop stub and tie code generator (needed by javax.swing.CORBA). I plant to add IOR parser later. There are several reasons for adding tools folder: 1. The cp-tools build system currently does

[cp-patches] Patch: GtkComponentPeer fix

2006-02-07 Thread Lillian Angel
I added this check to prevent several assertion errors in GdkGraphics. 2006-02-07 Lillian Angel <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/GtkComponentPeer.java (handleEvent): Added check. Should not paint or update the component if it's width and height are both 0. In

[cp-patches] FYI: BasicStroke API docs

2006-02-07 Thread David Gilbert
I tidied up the BasicStroke API docs, and added a graphic to illustrate the line cap and join styles: 2006-02-07 David Gilbert <[EMAIL PROTECTED]> * java/awt/BasicStroke.java: Updated API docs all over, * java/awt/doc-files/capjoin.png: New file. Regards, Dave Index: java/aw