Re: [cp-patches] FYI: GapContent.getArray() marked as final

Patch attached. Regards, Dave David Gilbert wrote: I committed this patch - JAPI points out that the method should be final: 2006-03-04 David Gilbert <[EMAIL PROTECTED]> * javax/swing/text/GapContent.java (getArray): Mark as final. Regards, Dave Index: javax/swing/text/GapC

[cp-patches] FYI: GapContent.getArray() marked as final

I committed this patch - JAPI points out that the method should be final: 2006-03-04 David Gilbert <[EMAIL PROTECTED]> * javax/swing/text/GapContent.java (getArray): Mark as final. Regards, Dave

[cp-patches] FYI: StyleConstants - mark fields final

This patch (committed) marks a bunch of fields as final (pointed out by JAPI): 2006-03-04 David Gilbert <[EMAIL PROTECTED]> * javax/swing/text/StyleConstants.java (CharacterConstants.Background): Marked final, (CharacterConstants.BidiLevel): Likewise, (Character

[cp-patches] Patch: FYI: update SSLException

I'm checking this in. I realized after I committed my last SSLException patch that I needed to have an '@since 1.5' on the new constructors. This adds that, adds javadoc to the other constructor, and adds an @since for the class. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * javax/

[cp-patches] Patch: FYI: constructors in javax.net.ssl

I'm checking this in. This adds some new 1.5 constructors in javax.net.ssl. It also adds a missing serialVersionUID. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * javax/net/ssl/SSLException.java (SSLException): New constructors. (serialVersionUID): New field. Index: javax/n

[cp-patches] Patch: FYI: more java.security exception constructors

I'm checking this in. This adds some more new 1.5 constructors in java.security. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * java/security/spec/InvalidKeySpecException.java (InvalidKeySpecException): New constructors. * java/security/cert/CertificateParsingExceptio

[cp-patches] Patch: FYI: missing java.security constructors

I'm checking this in. This adds a bunch of constructors to java.security which are new with 1.5. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * java/security/SignatureException.java (SignatureException): New constructors. * java/security/ProviderException.java (Provid

[cp-patches] FYI: javax.swing.event.* - reformatting and API doc warning fixes

I committed this patch to fix some API doc warnings and do some reformatting: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/event/CaretEvent.java: Reformatting and fixed API doc warnings, * javax/swing/event/DocumentEvent.java: Likewise, * javax/swi

[cp-patches] Patch: FYI: add method to Insets

I'm checking this in. This adds a trivial new 1.5 method to java.awt.Insets. It also adds a missing @since. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * java/awt/Insets.java (set): New method. (equals): Added @since. Index: java/awt/Insets.java

[cp-patches] FYI: (was: RFC/RFT: HTTP header handling rewrite.)

David Daney wrote: PR libgcj/26487 shows problems with our existing header handling. I hacked up the attached patch, which needs more testing (please test it!) The basic problem is that the headers were being held in a map which scrambled them up if there were more than one header of the same

[cp-patches] Patch: FYI: javax.naming warnings

I'm checking this in. This fixes a bunch of javax.naming warnings. One is a javadoc buglet, the rest are missing serialVersionUIDs. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * javax/naming/NamingException.java (getExplanation): Javadoc fix. * javax/naming/spi/ResolveResul

[cp-patches] FYI: TableColumnModelEvent - reformatted

I committed this patch: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/event/TableColumnModelEvent.java: Reformatted. Regards, Dave Index: javax/swing/event/TableColumnModelEvent.java === RCS file: /sources/

[cp-patches] FYI: TableModelListener API docs

I added some API docs to this interface: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/event/TableModelListener.java: Updated API docs. Regards, Dave Index: javax/swing/event/TableModelListener.java === RCS

[cp-patches] [generics] Patch: FYI: genericize in AWT

I'm checking this in on the generics branch. This genericizes a method in AWT. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * java/awt/MenuBar.java (shortcuts): Genericized. Index: java/awt/MenuBar.java === RCS file: /c

[cp-patches] [generics] Patch: FYI: genericize java.beans

I'm checking this in on the generics branch. I've had this patch for a while but forgot to check it in. This genericizes some things in java.beans. Tom 2006-03-03 Tom Tromey <[EMAIL PROTECTED]> * java/beans/EventSetDescriptor.java (EventSetDescriptor): Genericized. (ge

[cp-patches] FYI: JInternalFrame fixlet

This patch makes the JInternalFrame set itself invisible in the constructor rather then in the UI. This makes the SwingSet InternalFrame demo work! 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JInternalFrame.java (JInternalFrame): Set frame invisible. (show)

[cp-patches] FYI: Toolkit fixlet

This adds a default implementation for Toolkit.getScreenInsets(). This enables newer versions of the SwingSet2 demo to start up. Try the JDK1.4 version for example. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * java/awt/Toolkit.java (getScreenInsets): Return (0,0,0,0) here. /Ro

[cp-patches] FYI: FlowView fixlet

Here comes a fixlet for FlowView which adds a check for a bordercase. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/FlowView.java (FlowStrategy.layoutRow): Added check for rowCount == 0. (FlowStrategy.getLogicalView): Made method protected. /Roman Index

Re: [cp-patches] Patch: RFC: generate collections.jar

Hi, On Fri, 2006-03-03 at 10:20 +0100, Mark Wielaard wrote: > Nice. I am actually surprised the mkcollections.pl script still works > with so little modification since it hasn't been used much in the past. Yes, I did the minimum changes required for the script to run. I didn't carefully compare

[cp-patches] FYI: SpringLayout - fix API doc warnings

I fixed a couple of API doc warnings for this class: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/SpringLayout.java: Fixed API doc warnings. Regards, Dave Index: javax/swing/SpringLayout.java === RCS file:

[cp-patches] FYI: ListSelectionEvent.toString() implemented

I implemented the ListSelectionEvent.toString() method and updated the API docs for this class: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/event/ListSelectionEvent.java (toString): Implemented, plus updated API docs all over. Regards, Dave Index: java

Re: [cp-patches] FYI:Formatting (autoformatting) and commenting the RMI distribute garbage collector classes.

Hi Audrius, On Fri, 2006-03-03 at 16:50 +0100, Audrius Meskauskas wrote: > These classes are undocumented in our project. Before working with the > code I wrote some comments and applied Eclipse formatter. Thanks, but we need to teach the eclipse formatter to not indent the boilerplate: > --- g

Re: [cp-patches] RFC/RFT: HTTP header handling rewrite.

Chris Burdess wrote: Wolfgang Baer wrote: In general you are right. However SUN clearly uses the key name in the Map returned by getHeaderFields() as it is and not lowercased. And there is nothing in the javadoc which would make a programmer assume that he must query with a lowercased na

Re: [cp-patches] RFC/RFT: HTTP header handling rewrite.

Wolfgang Baer wrote: David Daney wrote: Wolfgang Baer wrote: [...] Not correct. These Maps are only modified internally to classpath. The RFC requires header name comparisons to be case insensitive. The only way to make the Map work with String keys is to ensure that the keys get transfo

[cp-patches] FYI: ListSelectionEvent/ListSelectionListener.java - reformatting and API doc updates

I committed this patch: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/event/ListSelectionEvent.java: Reformatted and fixed API doc warnings, * javax/swing/event/ListSelectionListener.java: Updated API docs. Regards, Dave Index: javax/swing/event/ListSelec

Re: [cp-patches] RFC: gnu.regexp.* rewritten

Hi, From: Mark Wielaard <[EMAIL PROTECTED]> Date: Fri, 03 Mar 2006 12:20:18 +0100 > On Thu, 2006-03-02 at 00:35 +0900, Ito Kazumitsu wrote: > > (3) New methods REToken#returnsFixedLengthMatches and > > REToken#findFixedLengthMatches. These will fasten the > > search for repeated ma

[cp-patches] FYI: NEWS update

I forgot to mention Roberts highlighting work in NEWS. This is now also added. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * NEWS: Added comment about text highlighting and copy+paste in Swing. /Roman Index: NEWS =

[cp-patches] FYI:Formatting (autoformatting) and commenting the RMI distribute garbage collector classes.

These classes are undocumented in our project. Before working with the code I wrote some comments and applied Eclipse formatter. 2006-03-03 Audrius Meskauskas <[EMAIL PROTECTED]> * gnu/java/rmi/dgc/DGCImpl.java, java/rmi/dgc/DGC.java, java/rmi/dgc/Lease.java: Formatted and commented.

[cp-patches] FYI: JTabbedPane fixlet

This patch avoids a stack overflow when calling JTabbedPane.remove(int). 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java (remove(int)): Call super.remove(int) instead of remove(Component). Avoids a stack overflow. /Roman Index: javax/swing/JTa

[cp-patches] FYI: JTable fixlet

I added a little division by zero check to JTable. That one caused problems in some corner cases (when the layout is not yet computed and someting == 0). 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTable.java (distributeSpillResizing): Avoid ArithmeticException by

[cp-patches] FYI: javax.swing.text.* package description

I added a description to the package.html file for javax.swing.text.*: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/text/package.html: Added package description. Regards, Dave Index: javax/swing/text/package.html =

[cp-patches] FYI: javax.swing.* API doc updates

This patch (committed) updates/fixes a few API doc comments in javax.swing.*: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/CellRendererPane.java: Minor API doc fix, * javax/swing/ComboBoxModel.java: Updated API docs. Regards, Dave Index: javax/swing/CellRenderer

[cp-patches] FYI: CellEditor/DefaultCellEditor API doc updates

I committed this patch to fix some API doc warnings: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/CellEditor.java: API doc updates, * javax/swing/DefaultCellEditor.java: Likewise. Regards, Dave Index: javax/swing/CellEditor.java =

[cp-patches] FYI: AbstractListModel - API docs

I committed this patch to fix a couple of minor API doc problems: 006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/AbstractListModel.java: (AbstractListModel): Added API docs, (fireContentsChanged): Minor API doc correction, (fireIntervalAdded): Likewis

[cp-patches] FYI: NEWS entry for Swing

I added a paragraph about Swing to the NEWS file. I have copied in the JTable entry, I hope this is ok for you, Audrius? 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * NEWS: Added paragraph about Swing improvements. /Roman Index: NEWS

Re: [cp-patches] RFC: gnu.regexp.* rewritten

Hi Ito, On Thu, 2006-03-02 at 00:35 +0900, Ito Kazumitsu wrote: > The imortant points of this change are: > > (1) A new method REToken#matchThis. This method tries to match > the input string against the REToken itself and does not > try to match the next RETokens chained to it. The

[cp-patches] FYI: javax.swing.* API doc fixes

I committed this patch to add/fix some API docs in javax.swing: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/AbstractAction.java: Updated API docs all over, * javax/swing/AbstractCellRenderer.java: Minor reformatting, plus (stopCellEditing): Minor API doc

[cp-patches] FYI: MetalUtils vs. Graphics2D

I added a switch in MetalUtils which can turn off the use of Graphics2D methods, even if the supplied Graphics object is an instance of Graphics2D. The idea is that it should be possible to turn this off when the Graphics2D impl is there, but certain features a still not implemented. In such case y

[cp-patches] FYI: Basic PLAF fixes

Here comes some Basic LAF fixes, some of which I did on my way back from FOSDEM and which have been lying around here since then. This are mostly some optimizations to avoid unnecessary Rectangle creations. Also included here is some _very_ basic support for HTML on Labels, based on my previous wo

Re: [cp-patches] FYI: Improved HTML support

Roman Kennke wrote: I improved our HTML support a little, so that we now can render primitive tables: http://kennke.org/~roman/htmltable.png Also, this fixes some minor bugs in the javax.swing.text package. Hi Roman, It's really nice to see this progress... Dave.

[cp-patches] FYI: Improved HTML support

I improved our HTML support a little, so that we now can render primitive tables: http://kennke.org/~roman/htmltable.png Also, this fixes some minor bugs in the javax.swing.text package. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/DefaultStyledDocument.java

[cp-patches] FYI: UnsupportedLookAndFeelException - added API docs

I added API docs for the UnsupportedLookAndFeelException class: 2006-03-03 David Gilbert <[EMAIL PROTECTED]> * javax/swing/UnsupportedLookAndFeelException.java (UnsupportedLookAndFeelException): Changed argument name, updated API docs. Regards, Dave Index: javax/swing

[cp-patches] FYI: BasicHTML fixlet

I fixed the BasicHTML to embed the create HTML View inside a HTMLRootView which is similar in purpose and implementation like the BasicTextUI.RootView. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicHTML.java (HTMLRootView): New inner class. (c

[cp-patches] FYI: RepaintManager NPE check

According to the specs, Graphics.getClip(Bounds) may return null when no clip is set. I added appropriate checks to the RepaintManager to avoid NPEs in such situations. 2006-03-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicHTML.java (HTMLRootView): New inner

Re: [cp-patches] RFC: Fixlet for gnu/java/net/protocol/jar/Connection.java

Mark Wielaard wrote: > Hi Wolfgang, > > On Thu, 2006-03-02 at 19:59 +0100, Wolfgang Baer wrote: > >>2006-03-02 Wolfgang Baer <[EMAIL PROTECTED]> >> >> * gnu/java/net/protocol/jar/Connection.java: >> (connect): Throw FileNotFoundException. >> (getInputStream): Remove duplicated co

Re: [cp-patches] Patch: RFC: generate collections.jar

Hi Tom, On Thu, 2006-03-02 at 22:16 -0500, Thomas Fitzsimmons wrote: > produces /build/path/lib/collections.jar, which provides a drop-in > replacement for the collections.jar that MegaMek currently bundles. I > bundle the source code so that our collections.jar is easily > distinguishable from S

Re: [cp-patches] RFC/RFT: HTTP header handling rewrite.

Wolfgang Baer wrote: ! ! /** !* Get a new Map containing all the headers. The keys of the Map !* are Strings (the header names). The values of the Map are !* unmodifiable Lists containing Strings (the header values). !* !* !* !* The returned map is modifiable.

Re: [cp-patches] RFC/RFT: HTTP header handling rewrite.

David Daney wrote: > Wolfgang Baer wrote: [...] >>> >>> Not correct. >>> >>> These Maps are only modified internally to classpath. The RFC requires >>> header name comparisons to be case insensitive. The only way to make >>> the Map work with String keys is to ensure that the keys get transformed

Re: [cp-patches] RFC: Fixlet for gnu/java/net/protocol/jar/Connection.java

Hi Wolfgang, On Thu, 2006-03-02 at 19:59 +0100, Wolfgang Baer wrote: > 2006-03-02 Wolfgang Baer <[EMAIL PROTECTED]> > > * gnu/java/net/protocol/jar/Connection.java: > (connect): Throw FileNotFoundException. > (getInputStream): Remove duplicated code. > > OK to commit ? Yes t