Re: [cp-patches] RFC: fixlet for URLClassLoader.addURLImpl

2006-03-05 Thread Dalibor Topic
On Sun, 2006-02-12 at 21:52 +0100, Dalibor Topic wrote: Hi all, the attached patch is part of the fallout of work on Kaffe's bug #16. It turns out that addURLImpl can occasionally get confused whether an URL points to a directory or not, based on the string check alone, for example when the

Re: [cp-patches] NIO Scatter/Gather patch

2006-03-05 Thread Michael Barker
I have addressed the issues raised by Roman and Jeoren and attached an updated patch.Cheers,Mike. Index: gnu/java/nio/PipeImpl.java === RCS file: /cvsroot/classpath/classpath/gnu/java/nio/PipeImpl.java,v retrieving revision 1.11 diff

[Fwd: Re: [cp-patches] RFC: file resources can be directory too]

2006-03-05 Thread Olivier Jolly
Hi, since no one objected on the fact that we should consider directories as valid resources, I committed the attached trivial patch with this changelog 2006-03-05 Olivier Jolly [EMAIL PROTECTED] Fixes PR 22813 * java/net/URLClassLoader.java (FileURLLoader.getResource): Allows

[cp-patches] Patch: FYI: fix Constructor.toString and Field.toString

2006-03-05 Thread Tom Tromey
I'm checking this in. This fixes a bug I noticed in Constructor.toString and Field.toString. I added a Mauve test for this and tested it by pulling the modified code into the jamvm in my workspace. VM implementors will probably have to copy this code into their VM, as generally Constructor and

[cp-patches] FYI: javax.swing.filechooser.* API doc tag fixes

2006-03-05 Thread David Gilbert
This patch (committed) fixes a couple of bad API doc tags in javax.swing.filechooser.*: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/filechooser/FileFilter.java: (accept): Fixed API doc tag, (getDescription): Likewise, *

[cp-patches] FYI: ColorSelectionModel.java - added API docs

2006-03-05 Thread David Gilbert
This patch (committed) adds API doc comments to the ColorSelectionModel interface: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/colorchooser/ColorSelectionModel.java: Reformatted and added API docs all over. Regards, Dave Index:

[cp-patches] FYI: ComboBoxUI.java - API doc fixes

2006-03-05 Thread David Gilbert
This patch (committed) fixes a couple of minor API doc issues in the ComboBoxUI class: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/ComboBoxUI.java: Fixed typo in class description, and corrected a bad API doc tag. Regards, Dave Index:

[cp-patches] FYI: javax.swing.undo.* API doc fixes

2006-03-05 Thread David Gilbert
This patch (committed) adds some API docs and fixes a few minor issues in javax.swing.undo.*: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/undo/StateEditable.java (restoreState): Fixed bad API doc tag, * javax/swing/undo/UndoableEdit.java: Copied API doc

[cp-patches] FYI: FocusManager/DefaultFocusManager.java - API tag fixes

2006-03-05 Thread David Gilbert
This patch (committed) fixes some bad API doc tags: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/DefaultFocusManager.java: Fixed bad API doc tags, * javax/swing/FocusManager.java: Likewise. Regards, Dave Index: javax/swing/DefaultFocusManager.java

[cp-patches] FYI: javax.swing.plaf.metal.* - API doc tag fixes

2006-03-05 Thread David Gilbert
This patch (committed) fixes a couple of API doc warnings in javax.swing.plaf.metal.*: 2006-03-05 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalComboBoxButton.java (MetalComboBoxButton(JComboBox, Icon, boolean, CellRendererPane, JList)): Fixed API doc

[cp-patches] FYI: GapContent.insertString fix

2006-03-05 Thread Robert Schuster
Hi, Sun's GapContent.insertString does not like it when the where argument is below zero and throws a BadLocationException. That exception should be visible when an instance of that class is used by PlainDocument. There is already a mauve test which relies on that. This small patch fixes that and

[cp-patches] FYI: PlainDocument.insertUpdate

2006-03-05 Thread Robert Schuster
Hi, this patch fixes PR 26194 which made it impossible to enter newlines into JTextAreas. There is a new mauve test which backs this work up. Along with my other small fix to GapContent we now pass every PlainDocument.insertString test. @Mark: Please add this patch to the release branch.

[cp-patches] FYI: Fixed URI quoting of unicode characters outside the basic plane

2006-03-05 Thread Dalibor Topic
Hi all, I've checked in the following fix to URI unicode quoting issues. See gnu/testlet/java/net/URI/UnicodeURI.java in mauve for an example. cheers, dalibor topic 2006-03-06 Dalibor Topic [EMAIL PROTECTED] * libraries/javalib/external/classpath/java/net/URI.java(quote):

[cp-patches] FYI: DefaultCaret - selection with shift + double triple-click behavior

2006-03-05 Thread Robert Schuster
Hi, this patch fixes the missing shift-click behavior of the caret (PR 26416). And while I was at this class I saw that we are missing word (double-click) and line (triple-click) behavior and implemented that. In case of the double click the RI will select the gap between two if you click on it.

[cp-patches] RFC: DefaultHighlighter.DefaultHighlighterPainter.paint rewritten

2006-03-05 Thread Robert Schuster
Hi, this is the patch which should make the DefaultHighlighter.DefaultHighlighterPainter able to paint lines with different font sizes. However I cannot really test this because JTextPane cannot display such documents correctly atm and I do not know whether my approach works for these documents.

[cp-patches] FYI: BasicTextUI.damageRange fix

2006-03-05 Thread Robert Schuster
Hi, while working on the new paint algorithm for the DefaultHighlighter.DefaultHighlighterPainter (which is mostly copy and pasted code from BasicTextUI.damageRange) I saw some thinkos in my first implementation. This fixes that. 2006-03-06 Robert Schuster [EMAIL PROTECTED] *

[cp-patches] FYI: Fixed a bug in file connection unicode character decoding

2006-03-05 Thread Dalibor Topic
Hi all, I've added a small path to fix a bug with file connection's handling of unquoting unicode characters outside of basic plane. I forgot to update the position in the buffer in my first patch, so the attached patch fixes that. cheers, dalibor topic 2006-03-06 Dalibor Topic [EMAIL

[cp-patches] Re: FYI: Fixed a bug in file connection unicode character decoding

2006-03-05 Thread Dalibor Topic
On Mon, 2006-03-06 at 04:44 +0100, Dalibor Topic wrote: Hi all, I've added a small path to fix a bug with file connection's handling of unquoting unicode characters outside of basic plane. I forgot to update the position in the buffer in my first patch, so the attached patch fixes that.