Re: [cp-patches] [RFA/JDWP] VMMethod

> "Keith" == Keith Seitz <[EMAIL PROTECTED]> writes: Keith> If someone could double-check the coding style/standard, I would Keith> appreciate it. I have not yet had any luck with running efj. Looks fine to me. Tom

[cp-patches] Patch: FYI: merge in System.clearProperty

I'm checking this in. I noticed in japi that we were missing System.clearProperty on the trunk, but we had it on the generics branch. This patch merges it in (with a minor change) and also merges in a couple other bug fixes in System. Tom 2006-03-07 Tom Tromey <[EMAIL PROTECTED]> * j

[cp-patches] RFC: Checking file resource validity by walking path components

Hi, the current implementation which retrieves a File resource allows to retrieve Files which are located "above" the root dir (imagine ClassLoader.getResource("../../../etc/passwd")) while it shouldn't (hence the current regression in gnu.testlet.java.net.URLClassLoader.getResource about '..').

Re: [cp-patches] FYI: MetalLookAndFeel.initComponentDefaults() minor fix

Tom Tromey wrote: "David" == David Gilbert <[EMAIL PROTECTED]> writes: David> This was pointed out by running FindBugs David> (http://findbugs.sourceforge.net/). How are you running FindBugs? I think it would be great if we were running it on the auto-builder and reporting FindB

[cp-patches] FYI: Replacing java/rmi/server/UID.java by the new implementation

Replacing this file by the newly written file (// don't ask me why). 2006-03-07 Audrius Meskauskas <[EMAIL PROTECTED]> * java/rmi/server/UID.java: New file (replacing). Index: UID.java === RCS file: /sources/classpath/classpat

[cp-patches] [RFA/JDWP] VMMethod

Hi, Well, it's time to start cleaning up my mess and checking in patches to get something working. So let me start by straightening out the mess that is virtual machine method representation in JDWP. The attached patch adds the new VMMethod class, which represents a method in a virtual machi

[cp-patches] FYI: patch committed. was: Manifest patch for review

hello Tom, On Wednesday 08 March 2006 02:49, Tom Tromey wrote: > > "Raif" == Raif S Naffah <[EMAIL PROTECTED]> writes: > > Raif> the JAR specs explicitly state that Name headers must not > exceed 70 Raif> bytes. the updated patch ensure this is the case. > > FWIW I think this patch looks reas

Re: [cp-patches] RFC: Headers fixlet

David Daney wrote: > Wolfgang Baer wrote: [...] >>> If you have test cases that show that the current putAll() is broken, >>> then the change should be made. But change just for change's sake I am >>> not so sure. >> >> >> >> No, I have no testcases for putAll() - only for put(). As you said its >

Re: [cp-patches] RFC: Headers fixlet

Wolfgang Baer wrote: Hi David, David Daney wrote: Wolfgang Baer wrote: Hi, I wrote mauve tests for the various HttpURLConnection request properties methods and notices some minor bugs in the new Headers implementation. The patch fixes these and adds documentation to this class in more det

Re: [cp-patches] FYI: MetalLookAndFeel.initComponentDefaults() minor fix

> "David" == David Gilbert <[EMAIL PROTECTED]> writes: David> This was pointed out by running FindBugs David> (http://findbugs.sourceforge.net/). How are you running FindBugs? I think it would be great if we were running it on the auto-builder and reporting FindBugs regressions. Maybe we co

Re: [cp-patches] Manifest patch for review

> "Raif" == Raif S Naffah <[EMAIL PROTECTED]> writes: Raif> the JAR specs explicitly state that Name headers must not exceed 70 Raif> bytes. the updated patch ensure this is the case. FWIW I think this patch looks reasonable. Tom

[cp-patches] FYI: DefaultMutableTreeNode fixes

This patch (committed) implements two stubbed methods (getNextLeaf() and getPreviousLeaf()), fixes a minor bug in isNodeSibling(), and adds API docs to some other methods in DefaultMutableTreeNode. The code changes are backed up by Mauve tests that I committed earlier today. Sorry for mixing c

[cp-patches] Patch: FYI: warnings in AWT

I'm checking this in. This adds a couple missing serialVersionUIDs to AWT, and also fixes a couple javadoc problems. Tom 2006-03-07 Tom Tromey <[EMAIL PROTECTED]> * java/awt/image/ColorModel.java (getComponents): Javadoc fix. * java/awt/datatransfer/FlavorEvent.java: Added mis

[cp-patches] [Patch] java.net.Proxy and friends

Hello all, I implemented some proxy stuff from Java 1.5. It needs enums and generics. Cheers, Michael 2006-03-07 Michael Koch <[EMAIL PROTECTED]> * gnu/java/net/DefaultProxySelector.java, java/net/Proxy.java, java/net/ProxySelector.java: New files. Index: gnu/java/

[cp-patches] FYI: DefaultMutableTreeNode fixes

This patch (committed) fixes the failures in the new Mauve tests I committed earlier today for the DefaultMutableTreeNode class, and adds API docs: 2006-03-07 David Gilbert <[EMAIL PROTECTED]> * javax/swing/tree/DefaultMutableTreeNode.java: API docs all over plus (clone): Reim

[cp-patches] FYI: TreeNode - API docs updated

This patch (committed) reformats the source and adds API docs for the TreeNode class: 2006-03-07 David Gilbert <[EMAIL PROTECTED]> * javax/swing/tree/TreeNode.java: Reformatted and added API docs all over. Regards, Dave Index: javax/swing/tree/TreeNode.java =

Re: [cp-patches] FYI: Swing Demo - show VM infos

On Mon, 2006-03-06 at 16:44 +0100, Robert Schuster wrote: > Hi, > I wanted to be able to know the VM I am running the Swing Demo on. Here is a > small patch that makes that possible. Wanted to try that coool feature :-), but unfortunately: java.lang.IllegalArgumentException: position: 2, begi

Re: [cp-patches] RFC: Headers fixlet

Hi David, David Daney wrote: > Wolfgang Baer wrote: > >> Hi, >> >> I wrote mauve tests for the various HttpURLConnection request properties >> methods and notices some minor bugs in the new Headers implementation. >> >> The patch fixes these and adds documentation to this class in more >> detail.