[cp-patches] FYI: BasicPermission constructor argument fixlet

2006-03-17 Thread Mark Wielaard
Hi, The knopflerfish failure we were seeing was because the testsuite explicitly tried to get a NullPointerException by feeding BasicPermission a null argument to the constructor. We used to throw that, but when cleaning up the code this exception was no longer thrown. This fixes that:

Re: [cp-patches] NIO Scatter/Gather patch

2006-03-17 Thread Michael Barker
Please disregard this patch as I have recently found that is contains a bug. I will resend an updated one in the next couple of days.Regards,Michael Barker.On 3/5/06, Michael Barker [EMAIL PROTECTED] wrote: I have addressed the issues raised by Roman and Jeoren and attached an updated

[cp-patches] FYI: JPopupMenu fix

2006-03-17 Thread Roman Kennke
I noticed that the JPopupMenu should also be handled via the MenuSelectionManager just as the JMenus. I added that to JPopupMenu.setVisible. This also makes the automatic closing of popupmenus simpler (patch for this follows). 2006-03-17 Roman Kennke [EMAIL PROTECTED] *

Re: [cp-patches] FYI: JPopupMenu fix

2006-03-17 Thread Mark Wielaard
Hi Roman, On Fri, 2006-03-17 at 14:52 +0100, Roman Kennke wrote: 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/JPopupMenu.java (setVisible): Handle JPopupMenu opening and closing via the MenuSelectionHandler. You forgot to attached the actual patch. So

[cp-patches] FYI: BasicComboBoxRenderer fix

2006-03-17 Thread Roman Kennke
Hi, I did some work on the ComboBox UIs. (well, I wanted to fix a small bug and turned out to rewrite half of the ComboBox stuff ;-) ) Here comes the BasicComboBoxRenderer. This fixes the initialization of the renderer WRT colors and fonts. 2006-03-17 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: draw selected text

2006-03-17 Thread Robert Schuster
Hi, this patch fixes PR 26675 and some problems which are related to this. At first my code to draw selected and unselected text in the same line did not work. I found out that this is because the return value of Utilities.drawTabbedText did not return the x coordinate after the last drawn char.

[cp-patches] FYI: Reverse japi fixes in org.omg

2006-03-17 Thread Wolfgang Baer
Hi, here are some more obvious fixes making some classes final. 2006-03-17 Wolfgang Baer [EMAIL PROTECTED] * org/omg/DynamicAny/DynAnyPackage/InvalidValue.java: Now final. * org/omg/DynamicAny/DynAnyPackage/TypeMismatch.java: Likewise. *

[cp-patches] FYI: BasicComboPopup fix

2006-03-17 Thread Roman Kennke
Here comes the BasicComboPopup part of my JComboBox work. It's quite a lot. Mostly it fixes how listeners are plugged together and how colors and fonts are installed. 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboPopup.java (BasicComboPopup):

[cp-patches] FYI: demo shutdown on closing main frame

2006-03-17 Thread Robert Schuster
Hi, this small patch changes the demo in a way that the VM is shut down when the main JFrame is closed. 2006-03-17 Robert Schuster [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java: (Demo): Set default closing operation to shutdown the runtime. cya Robert

[cp-patches] FYI: BasicComboBoxUI

2006-03-17 Thread Roman Kennke
Here comes the BasicComboBoxUI fixes. Again, this is mostly setup of the listeners and UI default initialization changes among lots of small adjustments. 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboBoxUI.java (mouseListener): Removed field.

Re: [cp-patches] FYI: Complete Spring and SpringLayout

2006-03-17 Thread Tom Tromey
Tom == Thomas Fitzsimmons [EMAIL PROTECTED] writes: Tom This patch comes from Caolan McNamara. It completes our Spring and Tom SpringLayout implementations. Nice! Tom + // protected abstract String springdebug(); Commented-out code ... gross. In this case it seems to me that the debug

Re: [cp-patches] FYI: Complete Spring and SpringLayout

2006-03-17 Thread Thomas Fitzsimmons
On Fri, 2006-03-17 at 10:12 -0700, Tom Tromey wrote: Tom == Thomas Fitzsimmons [EMAIL PROTECTED] writes: Tom This patch comes from Caolan McNamara. It completes our Spring and Tom SpringLayout implementations. Nice! Tom + // protected abstract String springdebug(); Commented-out

Re: [cp-patches] FYI: Complete Spring and SpringLayout

2006-03-17 Thread Thomas Fitzsimmons
On Fri, 2006-03-17 at 13:15 -0500, Thomas Fitzsimmons wrote: On Fri, 2006-03-17 at 10:12 -0700, Tom Tromey wrote: Tom == Thomas Fitzsimmons [EMAIL PROTECTED] writes: Tom This patch comes from Caolan McNamara. It completes our Spring and Tom SpringLayout implementations. Nice!

[cp-patches] FYI: fix trigger location for right and center aligned jtextfields

2006-03-17 Thread Robert Schuster
Hi, the FieldView.viewToModel() method missed a call to adjust the allocation area. The result was that mouse clicks on text in right and center aligned text fields did not select the right characters (PR 26498). This is now fixed. 2006-03-17 Robert Schuster [EMAIL PROTECTED] *

[cp-patches] FYI: DefaultEditorKit cleanup

2006-03-17 Thread Robert Schuster
Hi, this cleans up DefaultEditorKit and adds 5 simple actions: - move caret to next word - move caret to previous word - expand selection to next word - expand selection to previous word - select all (ctrl a) 2006-03-17 Robert Schuster [EMAIL PROTECTED]

[cp-patches] FYI: fix for selecting text with mouse

2006-03-17 Thread Robert Schuster
Hi, by clicking around in our Free Swing Demo I found out that my patch to implement word and line selection in DefaultCaret.mouseListener was not quite correct: If you double clicked on Hello in Hello World! in the jtextarea or jtextfield with a custom selected text color it would have painted

[cp-patches] FYI: BasicButtonUI fix

2006-03-17 Thread Roman Kennke
This fixes the BasicButtonUI to only touch the margin of a Button when it's a UIResource. This is important for theme and LF switching, especially for buttons that are part of other components etc. 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicButtonUI.java

Re: [cp-patches] RFC: allow only one textcomponent to have a selection

2006-03-17 Thread Roman Kennke
Am Freitag, den 17.03.2006, 21:04 +0100 schrieb Robert Schuster: Hi, this patch enforces that Free Swing paints only one selection for all of the textcomponents it manages within the current runtime. Any objections, ideas, ... ? This very much sounds like the selection should be managed by

[cp-patches] FYI: MetalComboBoxEditor

2006-03-17 Thread Roman Kennke
This fixes the border of the metal combobox editor. 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalComboBoxEditor.java (MetalComboBoxEditorBorder): Made this a subclass of AbstractBorder instead of Flush3DBorder. (paintBorder): Fixed

[cp-patches] FYI: MetalComboBoxUI

2006-03-17 Thread Roman Kennke
This is the last piece of my ComboBox work. There were some layout glitches in the MetalComboBoxUI that are fixed by the attached patch. 2006-03-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalComboBoxUI.java (MetalComboBoxLayoutManager.layoutContainer): Forward

[cp-patches] FYI: JTextComponent opaqueness

2006-03-17 Thread Roman Kennke
Some days ago I checked in a fix that removed the setOpaque() call from the BasicTextUI. It really belongs into the component constructor. However, I forgot to check in the patch for this. Here it comes now: 2006-03-17 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: JComboBox vs OceanTheme

2006-03-17 Thread Roman Kennke
The JComboBox used to look a little strange in the OceanTheme. The editor box didn't seem to fit right with the button. I suspected something strange with the layout, but it turned out that the layout was right, only the painting of the editor border was not suitable for the OceanTheme. This patch