This patch (committed) fixes a few minor problems with the JToolTip class. The
setComponent() and setTipText() methods should fire property change events, and the
AccessibleJToolTip class was a stub:
2006-03-21 David Gilbert <[EMAIL PROTECTED]>
* javax/swing/JComponent.java
I'm checking this in.
I happened to notice some javadoc buglets in java.security.cert, and
I figured I'd just fix them.
Tom
2006-03-20 Tom Tromey <[EMAIL PROTECTED]>
* java/security/cert/PKIXCertPathChecker.java: Javadoc fix.
* java/security/cert/CertStoreSpi.java: Added impor
I'm checking this in.
We need to build gnu.javax.swing.plaf after the latest round of
checkins. This updates the Eclipse builder. I forget why this was
disable original; I think it didn't build last summer.
Tom
2006-03-20 Tom Tromey <[EMAIL PROTECTED]>
* .classpath: Build gnu.javax.
> "Stuart" == Stuart Ballard <[EMAIL PROTECTED]> writes:
Stuart> I believe Classpath already has an unchecked NotImplementedException
Stuart> so that's what I used. Any method marked as "throws
Stuart> NotImplementedException" will be reported by Japi as "not implemented
Stuart> in Classpath",
Here comes the bulk of my today's work. It fixes up the painting of the
TabbedPane, including support for the OceanTheme.
The paint* methods look quite difficult, but 1. after my observations I
couldn't think of a more simple way to perform the painting (while
beeing correct). 2. Once you grok the
I added support for the tabsOpaque UIManager property to the
BasicTabbedPane. This property causes the tab background (note: not the
whole JTabbedPane!) to be painted or not, depending on the value.
2006-03-20 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTabbedPaneUI.
In JTabbedPane, in the subclass Pane, we should return the JTabbedPane's
background when no background has been explicitly set on the tab, so
that the UI paints the tab correctly.
2006-03-20 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/JTabbedPane.java
(Pane.getBackground): Wh
On Mar 20, 2006, at 2:54 PM, Chris Burdess wrote:
During development of the XML parser I prevented U+fffd from being
classified as an XML Char. Since the introduction of the UnicodeReader
class this hack is no longer required. I committed this patch to
re-classify U+fffd as a Char and permit
During development of the XML parser I prevented U+fffd from being
classified as an XML Char. Since the introduction of the
UnicodeReader class this hack is no longer required. I committed this
patch to re-classify U+fffd as a Char and permit the parsing of
documents containing this charact
> "Stuart" == Stuart Ballard <[EMAIL PROTECTED]> writes:
>> I like David's idea of a STUB comment.
Stuart> Does anyone know if eclipse allows plugging in custom rules to produce
Stuart> warnings, and where (if anywhere) there's documentation on how to
Stuart> produce such rules?
I don't know
Re
Mark Wielaard wrote:
I propose to check the validity of a File resource by walking through
all the path components and making sure that all intermediate components
are valid (ie File.isDirectory and File.exists are true) and that we
never try to get "out" the root directory.
I only consid
In my last patch I made a slight mistake. I used the next index
directly, instead of looking up the next tab run in the tabRuns array.
This caused most tabs to be not drawn.
2006-03-20 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTabbedPaneUI.java
(paintTabArea
On 20 Mar 2006 11:45:27 -0700, Tom Tromey <[EMAIL PROTECTED]> wrote:
> Having a list of stubs would be a good start. The ones I fixed this
> weekend I ran across by chance; I had no idea we had stubs in AWT at
> all.
>
> I like David's idea of a STUB comment.
Does anyone know if eclipse allows pl
Tom Tromey writes:
> > "Andrew" == Andrew John Hughes <[EMAIL PROTECTED]> writes:
>
> Tom> We need to declare war on stubs. They improperly inflate our japi
> Tom> scores and blind us to the real state of Classpath. Also I seem to
> Tom> keep running into them as I dig around :-(
>
>
> "Stuart" == Stuart Ballard <[EMAIL PROTECTED]> writes:
Stuart> What's the status on the whole ecj-as-gcc-frontend thing?
It is still being discussed by the GCC Steering Committee. I'm
hopeful that we'll get the go-ahead and be able to have this in GCC
4.2.
Stuart> Since gcj
Stuart> and ec
> "Andrew" == Andrew John Hughes <[EMAIL PROTECTED]> writes:
Tom> We need to declare war on stubs. They improperly inflate our japi
Tom> scores and blind us to the real state of Classpath. Also I seem to
Tom> keep running into them as I dig around :-(
Andrew> My gut instinct would be to rem
Hi Audrius,
> >>The patch seems bringing no regressions, as far as I was able to test.
> >>
> >>
> >
> >Thanks for fixing this. Do you think you could write a testcase for the
> >problem you originally had?
> >
> >/Roman
> >
> >
> >
> I only used visual tests at the moment. However the table
On Mon, 2006-03-20 at 19:20 +0100, Mark Wielaard wrote:
> Hi Rob,
>
> On Mon, 2006-03-20 at 15:37 +, Robert Lougher wrote:
> > On 3/20/06, Mark Wielaard <[EMAIL PROTECTED]> wrote:
> > > Done. If you have a scroll mouse please try out WW2D with Cacao (I
> > > didn't get it working with jamvm ye
Hi Rob,
On Mon, 2006-03-20 at 15:37 +, Robert Lougher wrote:
> On 3/20/06, Mark Wielaard <[EMAIL PROTECTED]> wrote:
> > Done. If you have a scroll mouse please try out WW2D with Cacao (I
> > didn't get it working with jamvm yet, which seems to crash after loading
> > jawt).
>
> What version of
On Mon, 20 Mar 2006 09:15:41 -0500
"Stuart Ballard" <[EMAIL PROTECTED]> wrote:
> On 3/19/06, Stuart Ballard <[EMAIL PROTECTED]> wrote:
> > As far as I can figure out, an annotation is pretty much the only way
> > to get these kinds of methods to get flagged by Japi.
>
> Actually, I figured out (a
I took a deep look at how the painting of the TabbedPane work. I
determined which methods call which under which circumstances and with
which parameters and tried to recreate the paining behaviour as close as
possible in the BasicTabbedPaneUI. The according Metal fixes follow
soon.
2006-03-20 Rom
On 3/20/06, Andrew John Hughes <[EMAIL PROTECTED]> wrote:
> It sounds like a bad hack on the JAPI side, but it's up to you if you're
> maintaining this.
True enough, but I think the problem of stub-inflated japi reports is
important enough to try to find some way of tackling it. Obviously an
annot
Hi Mark,
On 3/20/06, Mark Wielaard <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Done. If you have a scroll mouse please try out WW2D with Cacao (I
> didn't get it working with jamvm yet, which seems to crash after loading
> jawt).
>
What version of JamVM are you using (i.e. is it CVS or a released
versio
Hi,
On Mon, 2006-03-20 at 09:28 -0500, Thomas Fitzsimmons wrote:
> On Sun, 2006-03-19 at 11:54 +0100, Mark Wielaard wrote:
> Yes, this patch looks good. The danger in introducing another lock is
> mutual-embrace deadlocks but I looked through the code and there aren't
> any cases where the locks
Hi Michael,
On Sun, 2006-03-19 at 22:40 +, Michael Koch wrote:
> I just commited another update for the locale data update to CLDR 1.3.
> The only things still missing is the update of the currency formats and
> the new locales.
Could you take a quick look at the following regressions (and on
Hi,
On Sun, 2006-03-19 at 11:54 +0100, Mark Wielaard wrote:
> Only for those functions that manipulate Graphics state also
> the main gdk lock is acquired.
Yes, this patch looks good. The danger in introducing another lock is
mutual-embrace deadlocks but I looked through the code and there aren
On 3/19/06, Stuart Ballard <[EMAIL PROTECTED]> wrote:
> As far as I can figure out, an annotation is pretty much the only way
> to get these kinds of methods to get flagged by Japi.
Actually, I figured out (and implemented in Japi) a place where we can
carry a flag on any method without requiring
And on we go with fixing the BasicTabbedPaneUI. This patch fixes the
layout of the tabs a little more:
2006-03-20 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTabbedPaneUI.java
(calculateTabHeight): Not need to use SwingUtilities here.
(getTabInsets): D
My last patch seems to have broken TabbedPane painting slightly. This
was because the order in which the tabs are stored internally has
changed. I fixed this and made the painting code slighly more
straightforward.
2006-03-20 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/Bas
I have reworked parts of the BasicTabbedPaneUI.TabbedPaneLayout layout
manager. This makes the layout and switching-between-tabs more efficient
and correct (I hope).
This also includes some JDK1.5 additions wrt rollover tabs which wrote
some time ago and which I originally wanted to complete first
As Roman noticed, in the previous patch the number of rows per whell
click is multiplied to the magic number 3 in the JTree and JTable. This
forces always to scroll by 3 lines, when clicking on the arrow button of
the scroll bar should only scroll by one.
I move the magic 3 constant to the Bas
Hi Audrius,
Am Montag, den 20.03.2006, 10:53 +0100 schrieb Audrius Meskauskas:
> This is not so trivial, because, following the API,
> getScrollableUnitIncrement should also perform the rounding operation,
> completely exposing the subsequent item. I will think how to do this better.
maybe do a
This is not so trivial, because, following the API,
getScrollableUnitIncrement should also perform the rounding operation,
completely exposing the subsequent item. I will think how to do this better.
Audrius.
Roman Kennke wrote:
Hi Audrius,
Am Montag, den 20.03.2006, 01:06 +0100 schrieb Aud
Andrew John Hughes wrote:
> I'm committing the attached patch which adds some features required by
> the new concurrency tree prepared by Tom Tromey and documented by
> myself.
+public class Unsafe
Unsafe should be final, otherwise you can create an instance by
subclassing and capturing the this
On Mon, 2006-03-20 at 10:20 +0100, Roman Kennke wrote:
> The units must stay the same (like one row for a JTable, one
> line of text in JTextComponent and so on). This is because a single
> click on a scollbar button scrolls the thing for exactly one unit. Only
> the MouseWheelListener should multi
Hi Olivier,
On Tue, 2006-03-07 at 22:57 +0100, Olivier Jolly wrote:
> the current implementation which retrieves a File resource allows to
> retrieve Files which are located "above" the root dir (imagine
> ClassLoader.getResource("../../../etc/passwd")) while it shouldn't
> (hence the current re
Hi Audrius,
Am Montag, den 20.03.2006, 01:06 +0100 schrieb Audrius Meskauskas:
> Surely, we can make via BasicScrollPaneUI and then have the JTrees
> scrolling with the wheel as well!
Wow, very nice!
However, I would not recommend to change the getScrollableUnitIncrement
methods. The units must
2006-03-20 Audrius Meskauskas <[EMAIL PROTECTED]>
* javax/swing/JTable.java (getScrollableUnitIncrement): Rewritten.
* javax/swing/JTree.java (getScrollableUnitIncrement): Rewritten.
(getScrollableUnitIncrement
* javax/swing/Scrollable.java: Documented.
* javax/swing/plaf/basic/B
I'm committing the attached patch which adds some features required by
the new concurrency tree prepared by Tom Tromey and documented by
myself.
Changelog:
2006-03-20 Andrew John Hughes <[EMAIL PROTECTED]>
* java/lang/System.java:
(nanoTime()): Documented.
* java/lang/T
39 matches
Mail list logo
