Re: [cp-patches] Path: Proposed fix of the endless loop in WrappedPlainView.java (WrappedLine.modelToView

2006-05-04 Thread Audrius Meskauskas
2006-05-03 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/WrappedPlainView.java (WrappedLine.modelToView): Do not care about pos currLineEnd if currLineStart == currLineEnd. Index: WrappedPlainView.java === RCS file:

Re: [cp-patches] FYI: fix for PR 27393

2006-05-04 Thread Audrius Meskauskas
Robert Schuster wrote: + + // Throwing a BadLocationException is an observed behavior of the RI. + if (rect.isEmpty()) +throw new BadLocationException(Unable to calculate view coordinates + + when allocation area is empty., 5);

Re: [cp-patches] Path: Proposed fix of the endless loop in WrappedPlainView.java (WrappedLine.modelToView:Not applied

2006-05-04 Thread Audrius Meskauskas
This is currently not applied, Robert has taken the bug and modified this differently. Audrius Audrius Meskauskas wrote: 2006-05-03 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/WrappedPlainView.java (WrappedLine.modelToView): Do not care about pos currLineEnd if currLineStart ==

[cp-patches] FYI: JTable fixes

2006-05-04 Thread Roman Kennke
The attached patch fixes a couple of issues in JTables: - the border color for selected cells was not correct in the Metal LF - the table was not painted correctly. The grid must be painted to the right and bottom of each cell, we painted it to the top and left - related to the previous, the cells

[cp-patches] FYI: More JTable fixes

2006-05-04 Thread Roman Kennke
I forgot one patch. This one fixes the colors and borders for selected table cells. 2006-05-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/DefaultTableCellModel.java (noFocusBorder): Fixed width of empty border to 1. (getTableCellRendererComponent): Don't change

[cp-patches] FYI: AbstractButton new methods

2006-05-04 Thread Roman Kennke
I noticed that in AbstractButton we have two new methods since 1.5: addImp() and setLayout(). After playing around with them I figured that addImpl() installs an OverlayLayout, but only in the case when the client app hasn't installed a custom layout before (this is detected in setLayout). And

[cp-patches] FYI: JComponent painting fixlet

2006-05-04 Thread Roman Kennke
I added a null check in JComponent.paint() to avoid an NPE when the clip is null. The clip is allowed to be null, but with the GTK peers it seems it never becomes actually null. I came across this while playing with my XAWT peers. 2006-05-04 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: JLabel fixlets

2006-05-04 Thread Roman Kennke
I tagged some methods in JLabel as not implemented, added comments to others and changed paramString() to return super.paramString() which provides more meaningful information than JLabel. 2006-05-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLabel.java

[cp-patches] FYI: AccessibleJOptionPane fixlet

2006-05-04 Thread Roman Kennke
I implemented one stubbed method in AccessibleJOptionPane. 2006-05-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/JOptionPane.java (AccessibleJOptionPane.getAccessibleRole): Implemented method. /Roman Index: javax/swing/JOptionPane.java

[cp-patches] FYI: BasicButtonListener fixlet

2006-05-04 Thread Roman Kennke
When playing with some apps I noticed that our conditions in BasicButtonListener.mouseEntered() where not quite right. Fixed by the attached patch. 2006-05-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicButtonListener.java (mouseEntered): Fixed conditions for

[cp-patches] FYI: Updated java.lang.Thread throwpoint tests

2006-05-04 Thread Gary Benson
Hi all, My previous commit fixes a number of problems with the Thread throwpoint tests. Firstly, they failed big-time on proprietary runtimes: seems that Classpath's default SecurityManager's checkAccess() methods perform permission checks in more cases than is necessary. Secondly, some

[cp-patches] Re: FYI: Updated java.lang.Thread throwpoint tests

2006-05-04 Thread Gary Benson
Balls, wrong list! Gary Benson wrote: Hi all, My previous commit fixes a number of problems with the Thread throwpoint tests. Firstly, they failed big-time on proprietary runtimes: seems that Classpath's default SecurityManager's checkAccess() methods perform permission checks in more

[cp-patches] Re: include security tools in tools.zip and convenience scipts

2006-05-04 Thread Tom Tromey
Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif again, unless others have no corrections or improvements to add, i will Raif check this in during the weekend. Looks good to me. Thanks! Tom

[cp-patches] Patch: JLabel fix

2006-05-04 Thread Lillian Angel
After testing several applets, I noticed that there were NPEs caused by JLabel. Sun passes in an empty string for text in the constructors that do not take text as a parameter. I fixed this. 2006-05-04 Lillian Angel [EMAIL PROTECTED] * javax/swing/JLabel.java (JLabel): Pass in

[cp-patches] Patch: FYI: PR 27375

2006-05-04 Thread Tom Tromey
I'm checking this in. This fixes PR 27375. It more or less follows the patch in the PR, but doesn't change entries to be declared as a Map. Tom 2006-05-04 Tom Tromey [EMAIL PROTECTED] PR classpath/27375: * java/util/zip/ZipFile.java (entries): Now a LinkedHashMap.

[cp-patches] FYI: JScrollBar.paramString() reimplemented

2006-05-04 Thread David Gilbert
This patch (committed) provides a more informative version of paramString(): 2006-05-05 David Gilbert [EMAIL PROTECTED] * javax/swing/JScrollBar.java (paramString): Reimplemented. Regards, Dave Index: javax/swing/JScrollBar.java

[cp-patches] FYI: JToolBar.paramString() reimplemented

2006-05-04 Thread David Gilbert
This patch (committed) provides a more informative paramString() implementation: 2006-05-05 David Gilbert [EMAIL PROTECTED] * javax/swing/JToolBar.java (paramString): Reimplemented. Regards, Dave Index: javax/swing/JToolBar.java

[cp-patches] FYI: JOptionPane API doc updates

2006-05-04 Thread David Gilbert
This patch (committed) updates some API docs in the JOptionPane class: 2006-05-05 David Gilbert [EMAIL PROTECTED] * javax/swing/JOptionPane.java: API doc updates. Regards, Dave Index: javax/swing/JOptionPane.java ===