[cp-patches] FYI: Implement lineBreakMeasurer

2006-06-12 Thread Sven de Marothy
Here's LineBreakMeasurer. The rest of you can't quite use it yet because the CVS TextLayout isn't up to snuff. So you'll just have to take my word for it. :) 2006-06-12 Sven de Marothy <[EMAIL PROTECTED]> * java/awt/font/LineBreakMeasurer.java): Implement. Index: java/awt/font/LineBr

Re: [cp-patches] RFA JDWP SingleStepEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: Fixed it here as well. Excellent. Committed. Keith

[cp-patches] Re: RFA JDWP MethodEntryEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: Fixed that, wow must have been half asleep this morning.. Thanks! I've checked this in. Keith

[cp-patches] Re: RFA JDWP MethodExitEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: This one's fixed as well And checked-in as well. Keith

[cp-patches] Re: RFA JDWP ClassUnloadEvent

2006-06-12 Thread Kyle Galloway
Ok, fixed that, I think this is probably the better way to do it, I hadn't though about when the event would get passed from the VM and this will work both ways. Kyle Keith Seitz wrote: Some questions about this... Kyle Galloway wrote: + /** + * Constructs a new ClassUnloadEvent + * +

[cp-patches] FYI: Graphics2D clipping/translating/painting fix

2006-06-12 Thread Roman Kennke
This patch fixes most remaining issues wrt clipping/translation and painting that can be observed in Swing. (There's one issue left, which is a Swing issue indeed, coming next). 2006-06-12 Roman Kennke <[EMAIL PROTECTED]> * gnu/java/awt/peer/gtk/CairoGraphics2D.java (copy): Use

Re: [cp-patches] RFA JDWP SingleStepEvent

2006-06-12 Thread Kyle Galloway
Fixed it here as well. Kyle Keith Seitz wrote: Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the desired parameter or null + */ + publ

[cp-patches] Re: RFA JDWP MethodExitEvent

2006-06-12 Thread Kyle Galloway
This one's fixed as well Kyle Keith Seitz wrote: Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the desired parameter or null + */ + pu

[cp-patches] Re: RFA JDWP MethodEntryEvent

2006-06-12 Thread Kyle Galloway
Fixed that, wow must have been half asleep this morning.. -Kyle Keith Seitz wrote: Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the d

[cp-patches] Re: RFA JDWP ClassUnloadEvent

2006-06-12 Thread Keith Seitz
Some questions about this... Kyle Galloway wrote: + /** + * Constructs a new ClassUnloadEvent + * + * @param clazz class which was prepared + */ + public ClassUnloadEvent(Class clazz) + { +super(JdwpConstants.EventKind.CLASS_UNLOAD); +_class = clazz; + } Do you intend fo

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java (forCaught): removed useless accessor method (forUncaught): removed useless accessor method (matches): Implemented This is approved with some slight modificat

Re: [cp-patches] RFA JDWP SingleStepEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the desired parameter or null + */ + public Object getParameter(int type) + { +if (typ

[cp-patches] Re: RFA JDWP MethodExitEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the desired parameter or null + */ + public Object getParameter(int type) + { +if (typ

[cp-patches] Re: RFA JDWP MethodEntryEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: + /** + * Returns a specific filtering parameter for this event. Valid types are + * thread and location + * + * @param type the type of parameter desired + * @returns the desired parameter or null + */ + public Object getParameter(int type) + { +if (type

[cp-patches] Re: RFA: JDWP ExceptionEvent

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: Broke my previous patch into smaller patches(more to come) and fixed some minor issues. This patch adds one event(ExceptionEvent). Requesting approval and a commit. Approved and committed. Keith

Re: [cp-patches] RFC: New events for JDWP and small changes to Event internals

2006-06-12 Thread Keith Seitz
Kyle Galloway wrote: I've made changes to fix problems with the patch and the changelog. This patch contains only the changes related to the change in Event. Requesting approval and a commit. Approved and committed. Keith

[cp-patches] RFA JDWP ClassUnloadEvent

2006-06-12 Thread Kyle Galloway
Adds ClassUnloadEvent to JDWP. Requesting approval and commit. ChangeLog: 2006-06-12 Kyle Galloway<[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/ClassUnloadEvent.java: New File. Index: ClassUnloadEvent.java === RCS file: C

[cp-patches] Patch: StandaloneAppletWindow title fix

2006-06-12 Thread Lillian Angel
Small minor fix for the standalone appletviewer. IMO, it should say "GNU Classpath Applet Viewer" instead of "GCJ Applet Viewer". 2006-06-12 Lillian Angel <[EMAIL PROTECTED]> * tools/gnu/classpath/tools/appletviewer/StandaloneAppletWindow.java (StandaloneAppletWindow): Changed t

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-12 Thread Thomas Fitzsimmons
Hi, Francis Kung wrote: Not sure how to write a mauve test, since it must simulate a mouseclick on a specific component's location... You can use java.awt.Robot for this. There are already tests in Mauve that use Robot, for example gnu.testlet.java.awt.Frame.size1. Tom

[cp-patches] RFC: Combo box mouseclick

2006-06-12 Thread Francis Kung
Hi, Please find attached a patch to fix mouseclick actions in the JComboBox. Previously, if you clicked on the combo box button while the popup menu was already open, it would close and immediately re-open the popup; this was caused by two listeners both catching the mouseclick and both toggling

[cp-patches] Re: RFC: java/util/Collections.java fails to compile with ECJ 3.2 RC3

2006-06-12 Thread Tom Tromey
> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes: Jeroen> Since you're the resident JLS expert, could you please have a look at Jeroen> this patch? One drawback of stopping work on your own compiler is that you forget a lot... or, IOW, I've got no clue. I've heard complaints about th

Re: [cp-patches] Patch: BasicTabbedPaneUI fixlet

2006-06-12 Thread Lillian Angel
Made a dumb mistake in the last patch. Thanks fitzsim for catching this. 2006-06-12 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java (layoutContainer): Added missing selectedComponent assignment. On Mon, 2006-06-12 at 12:08 -0400, Lillian Angel

[cp-patches] Patch: BasicTabbedPaneUI fixlet

2006-06-12 Thread Lillian Angel
A small fix for limewire. 2006-06-12 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java (layoutContainer): Added check to prevent exception. Index: javax/swing/plaf/basic/BasicTabbedPaneUI.java =

[cp-patches] RFA JDWP ExceptionOnlyFilter

2006-06-12 Thread Kyle Galloway
Implements the ExceptionOnlyFilter.matches() method in JDWP and removes two useless accessor methods in that class. Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java (forCaught): removed useless

[cp-patches] RFA JDWP SingleStepEvent

2006-06-12 Thread Kyle Galloway
Broke my previous patch into smaller patches(this is the last of them) and fixed some minor issues. This patch adds one event(SingleStepEvent). Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/SingleStepEvent.java: New File Index

[cp-patches] RFA JDWP SingleStepEvent

2006-06-12 Thread Kyle Galloway
Broke my previous patch into smaller patches(this is the last of them) and fixed some minor issues. This patch adds one event(SingleStepEvent). Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/SingleStepEvent.java: New File

[cp-patches] RFA JDWP MethodExitEvent

2006-06-12 Thread Kyle Galloway
Broke my previous patch into smaller patches(more to come) and fixed some minor issues. This patch adds one event(MethodExitEvent). Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/MethodExitEvent.java: New File Index: gnu/class

[cp-patches] RFA JDWP MethodEntryEvent

2006-06-12 Thread Kyle Galloway
Didn't attach file sorry everyone... Kyle Index: gnu/classpath/jdwp/event/MethodEntryEvent.java === RCS file: gnu/classpath/jdwp/event/MethodEntryEvent.java diff -N gnu/classpath/jdwp/event/MethodEntryEvent.java --- /dev/null 1 Jan 1

[cp-patches] RFA JDWP MethodEntry

2006-06-12 Thread Kyle Galloway
Broke my previous patch into smaller patches(more to come) and fixed some minor issues. This patch adds one event(MethodEntryEvent). Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/MethodEntryEvent.java: New File

[cp-patches] RFA: JDWP ExceptionEvent

2006-06-12 Thread Kyle Galloway
Broke my previous patch into smaller patches(more to come) and fixed some minor issues. This patch adds one event(ExceptionEvent). Requesting approval and a commit. Kyle 2006-06-12 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/ExceptionEvent.java: New File Index: gnu/cla

[cp-patches] Patch: FYI: fix warning

2006-06-12 Thread Tom Tromey
I'm checking this in. This fixes a javadoc warning due to a typo. Tom 2006-06-12 Tom Tromey <[EMAIL PROTECTED]> * java/lang/Thread.java (uncaughtException): Javadoc fix. Index: java/lang/Thread.java === RCS file: /cvsroo

Re: [cp-patches] RFC: New events for JDWP and small changes to Event internals

2006-06-12 Thread Kyle Galloway
I've made changes to fix problems with the patch and the changelog. This patch contains only the changes related to the change in Event. Requesting approval and a commit. Kyle ChangeLog: 2006-06-09 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/event/Event.java: Added constan

[cp-patches] FYI: Make ComponentGraphics locks reentrant

2006-06-12 Thread Mark Wielaard
Hi, A couple of drawing operations on CairoGraphics2D are implemented by calling other drawing primitives. This means that a draw() might call fill() later on for example. Since ComponentGraphics needs to acquire the gdk lock before actually doing any drawing (through its super class CairoGraphics

[cp-patches] FYI: Compositing fixes for CairoGraphics2D

2006-06-12 Thread Roman Kennke
This patch fixes (enables really) alpha compositing for text, stroked shapes, CairoSurace-images and normal images. For stroked shapes and text this means that it falls back to filling the outline that is then created using the GlyphVector / Stroke methods. Also note that I build in a hack in dra

Re: [cp-patches] FYI: Resolve GdkPixbufWriter gdk lockup FIXME

2006-06-12 Thread Mark Wielaard
Hi, On Sun, 2006-06-11 at 23:59 +0200, Mark Wielaard wrote: > This solves a gdk lockup in GdkPixbufWriter by implementing the > suggestion in the FIXME. Now we don't drop and re-acquire the gdk-lock > but store the data and push that to the user code from a separate > thread. Here is a small refi

[cp-patches] FYI: Whoops! on Runtime impl. patch

2006-06-12 Thread Andrew John Hughes
The attached patch finishes what I started... forgot to do a cvs add on it... Changelog: 2006-06-12 Andrew John Hughes <[EMAIL PROTECTED]> * java/lang/management/ManagementPermission.java: New file. -- Andrew :-) Please avoid sending me Microsoft Office (e.g. Word, PowerPoin