Seems fine. However do not use new Boolean(true), the singleton instance
Boolean.TRUE can be reused producing less garbage. Also, it is generally
not recommended to include the commented alternative variants of code.
If you are not sure if the simpler, more effective implementation
actually
Sven de Marothy wrote:
On Wed, 14 Jun 2006, David Gilbert wrote:
I'm requesting approval for this patch, just in case I'm missing something
important.
As I understand the getPathIterator(AffineTransform) method defined in the
Shape interface, if you want the path returned without
We can only paint a component without doublebuffering when all of it's
ancestors are also double buffering disabled. Otherwise the screen and
the backbuffer get out of sync and we get massive flickering. See the
bugreport
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28027
for an example and why I
This fixes a thinko of mine.
2006-06-15 Roman Kennke [EMAIL PROTECTED]
PR 28037
* javax/swing/RepaintManager.java
(blitBuffer): Substract coordinates the other way around.
/Roman
--
“Improvement makes straight roads, but the crooked roads, without
Improvement, are
This patch fixes a couple of problems turned up by
reverse JAPI.
Changelog:
2006-06-15 Andrew John Hughes [EMAIL PROTECTED]
* java/lang/management/ManagementFactory.java:
Add private constructor to prevent instance creation.
*
Hey,
In a previous mauve test, I changed 'focusable' to be set to false (and
not true) in AbstractButton.java. However, for the past couple of days
I have been writing mauve tests and it should in fact be set to true and
only set to false by the other classes (JRadioButtonMenuItem,
On Thu, 2006-06-15 at 13:29 -0400, Tania Bento wrote:
Hey,
In a previous mauve test, I changed 'focusable' to be set to false (and
not true) in AbstractButton.java. However, for the past couple of days
I have been writing mauve tests and it should in fact be set to true and
only set to
Sorry, changelog should be:
2006-06-15 Tania Bento [EMAIL PROTECTED]
* javax/swing/AbstractButton.java:
(AbstractButton): 'Focusable' should be set to true and not
false.
On Thu, 2006-06-15 at 13:29 -0400, Tania Bento wrote:
Hey,
In a previous mauve test, I changed
Hi,
I need help for this one.
I had the following problem:
BasicRadioButtonUI.installDefaults sets default values for the icon,
selectedIcon, disabledIcon etc properties. This is wrong, as the RI does not do
this. Minitestcase: assert(new JRadioButton().getIcon() == null)
I changed this and
Small change to this filter to correct a logical bug that would occur
when the Exception didn't match the filter and both caught and uncaught
exceptions were selected. Requesting approval so I can commit.
Thanks,
Kyle
2006-06-15 Kyle Galloway [EMAIL PROTECTED]
*
Hey,
This is one of the classes that sets 'focusable' to false. I will be
committing the mauve test soon. Could someone please approve this for
me so that I can commit it.
Cheers,
Tania
2006-06-15 Tania Bento [EMAIL PROTECTED]
* javax/swing/JCheckBoxMenuItem.java
Kyle Galloway wrote:
Small change to this filter to correct a logical bug that would occur
when the Exception didn't match the filter and both caught and uncaught
exceptions were selected. Requesting approval so I can commit.
Doh! I totally missed that. Yes, please commit.
Keith
Hey,
This is another one of the classes that sets 'focusable' to false. I
will be committing this and its mauve test immediately after posting
this.
Cheers,
Tania
2006-06-15 Tania Bento [EMAIL PROTECTED]
* javax/swing/JRadioButtonMenuItem.java
(JRadioButtonMenuItem): Should
Hi,
On Thu, 2006-06-15 at 02:19 +0200, Sven de Marothy wrote:
On Wed, 14 Jun 2006, David Gilbert wrote:
As I understand the getPathIterator(AffineTransform) method defined in the
Shape interface, if you want the path returned without transformation, you
can
pass in null for the
Hi Kyle,
On Thu, 2006-06-15 at 13:46 -0400, Kyle Galloway wrote:
2006-06-15 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java
(matches): Added explicit brackets to return statement
Super small nitpick about the ChangeLog entry. According
Hi,
Some code seems to close a GeneralPath twice which adds extra SEG_CLOSEs
at the end of a path. This caused some trouble in other code which
wasn't expecting to see multiple SEG_CLOSEs at the end. Other
documentation also implies that if a GeneralPath is closed it just stays
closed when
Hi,
GtkComponentPeer had a empty getGraphicsConfiguration() which meant that
similar methods on Component and ComponentGraphics would always return
null. This prevented some applications from getting a back buffer
graphics object in some cases. I have added code to GtkComponentPeer
that returns
Hey,
This is another one of the classes that sets 'focusable' to false. I
will be committing this and its mauve test immediately after posting
this.
Cheers,
Tania
2006-06-15 Tania Bento [EMAIL PROTECTED]
* javax/swing/plaf/basic/BasicArrowButton.java
Hey,
This is the last of the classes that sets 'focusable' to false. I will
be committing this and its mauve test immediately after posting this.
Cheers,
Tania
2006-06-15 Tania Bento [EMAIL PROTECTED]
* javax/swing/plaf/metal/MetalScrollButton.java
Mark == Mark Wielaard [EMAIL PROTECTED] writes:
This patch imports the jsr166 reference implementation. This is
implements java.util.concurrency.
Mark Nice. I'll write fsf legal to let them know how we are importing this
Mark for the records. Please wait with the actual import till we get an
JAPI pointed out a problem with the field in TextLayout.
2006-06-15 Lillian Angel [EMAIL PROTECTED]
* java/awt/font/TextLayout.java:
DEFAULT_CARET_POLICY changed to be public static final.
Index: java/awt/font/TextLayout.java
This patch finally adds the DynamicMBean class I created on Monday.
In order to compile, it also needs MBeanInfo. Here, I provide a shell
of this, without the main bits (which require yet further classes).
These will come soon.
Changelog:
2006-06-15 Andrew John Hughes [EMAIL PROTECTED]
Hello,
I would like to revisit this topic again. I don't know if anyone
attempting to implement JDWP is having startup problems, but I certainly
am with gij. Basically, we need to know exactly when the entire JDWP
backend is ready to go, otherwise we end up trying to send event
notifications
Hi,
This patch prefixes each tool executable with 'g' to avoid conflicts with other
implementations.
Tom
2006-06-15 Thomas Fitzsimmons [EMAIL PROTECTED]
* configure.ac: Rename appletviewer to gappletviewer, jarsigner to
gjarsigner and keytool to gkeytool.
*
Hi,
I am attaching a patch that follows the behaviour outlined in the JDK
javadoc for javax.crypto.CipherSpi's engineInit methods. I have already
committed a test case
(gnu.testlet.gnu.javax.crypto.jce.TestOfCipherEngineInit) that models
this logic.
Issues related to PR27849 have been
Vivek Lakshmanan wrote:
Hi,
I am attaching a patch that follows the behaviour outlined in the JDK
javadoc for javax.crypto.CipherSpi's engineInit methods. I have
already committed a test case
(gnu.testlet.gnu.javax.crypto.jce.TestOfCipherEngineInit) that models
this logic.
Issues related
I'm checking this in on the generics branch.
This renames Unsafe back to the sun package, and adds a new
Reflection class there as well. It also adds the sanitization script
and the import instructions.
I'll apply the vm/reference changes to the trunk a bit later, to keep
the VM interfaces in
27 matches
Mail list logo
