[cp-patches] FYI: Add Graphics2D security checks

Morning all, No one objected, so I committed this patch that adds security checks to all Graphics2D peers. Cheers, Gary Index: ChangeLog === RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.7888 diff -u

[cp-patches] FYI: GapContent fix

I fixed the GapContent so that it really searches for the first occurance of marks in the marks list. Collections.binarySearch doesn't guarantee to find the first object. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/GapContent.java

[cp-patches] FYI: UIManager fix

While playing with some custom LFs I noticed some flaws in our UIManager impl. It seems like the UIManager should not only manage 1 UIDefaults instance (from the LF), but another one, to which applications can make modifications. The latter one overloads the LF defaults. The lookup has to first

[cp-patches] [generics] FYI: Fixed compile error in java/util/Collections.java

Hi, Now that builder is using a new version of ecj, the generics branch no longer compiled due to a cast bug. I checked in a fix. Regards, Jeroen 2006-06-21 Jeroen Frijters [EMAIL PROTECTED] * java/util/Collections (entrySet): Fixed compile error. Index: java/util/Collections.java

[cp-patches] FYI: AbstractButton fixlet

In AbstractButton.init() we should call setText() instead of text = ..., so that listeners on that property (especially in the UI) get notified correctly. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractButton.java (init): Call setText() instead of setting the

[cp-patches] FYI: JComponent cleanup

This cleans up some cruft in JComponent and adds a small optimization. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (paintChildrenWithOverlap): Determine opaque property by calling the corresponding Component method, without requiring

[cp-patches] FYI: JSplitPane fixlet

In JSplitPane.setDividerLocation() we need to substract the divider location when computing the absolute size. Fixed by the attached patch. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/JSplitPane.java (setDividerLocation): Substract divider size when computing

[cp-patches] FYI: BasicText(Field)UI fixes

A couple of fixes for the TextUI classes. It juggles a little with the initialization. The UI properties only have to be installed if the corresponding current property is null or a UIResource. A document listener has to be installed early(-ier), so that notifications get sent correctly. Also I

[cp-patches] FYI: MetalUtils

I implemented the Swing gradient painting on top of the Graphics2D gradient functions. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalUtils.java (paintHorizontalGradient): Use paintHorizontalGradient2D when Graphics2D is available. Use fillRect

[cp-patches] FYI: TextLayout caching for Button-like Swing components

I implemented caching of TextLayouts for all button-like components (Buttons, CheckBoxes/RadioButtons, Menu(Item)s, etc). Should make things a bit faster. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicButtonListener.java (propertyChange): Create a

Re: [cp-patches] RFA: JMenu Constructor Regressions

Hey, For some reason when I did a CVS diff to create the patch for these changes, the change I made to BasicPopupMenuUI.java wasn't included. I only realized this afterwards. Again, this change was due to the mauve test I created (getPopUPMenu.java) that I have already committed. Below is the

[cp-patches] FYI: UIManager fixlet

In UIManager.MultiplexUIDefaults we must not clear the fallback defaults, thus I removed the clear() method. Most of the harmony swing tests immediately failed (or rather, error'ed) because they call UIManager.getDefaults().clear() right before running the actual tests. 2006-06-21 Roman Kennke

[cp-patches] FYI: FontRenderContext fixlet

The FontRenderContext.equals() method must handle affineTransform beeing null a little more clever. Most of Harmony's Swing tests were breaking down immediately due to NPE beeing thrown in that method. 2006-06-21 Roman Kennke [EMAIL PROTECTED] * java/awt/font/FontRenderContext.java:

Re: [cp-patches] RFA: JMenu Constructor Regressions

I looked over all your patches. They look fine. Go ahead and commit them. Lillian On Wed, 2006-06-21 at 09:32 -0400, Tania Bento wrote: Hey, For some reason when I did a CVS diff to create the patch for these changes, the change I made to BasicPopupMenuUI.java wasn't included. I only

[cp-patches] Patch: DefaultCaret fixlet

Resolved a couple of NPEs. 2006-06-21 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/DefaultCaret.java (install): Added check to prevent NPE. (propertyChange): Added checks to prevent NPEs. Index: javax/swing/text/DefaultCaret.java

Re: [cp-patches] RFC: javax.swing.text.DefaultCaret

Hi Mark, Mark Wielaard wrote: Hi Carsten, On Sat, 2006-03-25 at 16:48 +0100, Carsten Neumann wrote: Mark Wielaard wrote: On Fri, 2006-03-24 at 23:52 +0100, Carsten Neumann wrote: I've implemented the method: public boolean isActive(). Nice. Useful method also. Last time I worked

Re: [cp-patches] [generics] FYI: Fixed compile error in java/util/Collections.java

On Wed, 2006-06-21 at 13:39 +0200, Jeroen Frijters wrote: Hi, Now that builder is using a new version of ecj, the generics branch no longer compiled due to a cast bug. I checked in a fix. Regards, Jeroen 2006-06-21 Jeroen Frijters [EMAIL PROTECTED] * java/util/Collections

[cp-patches] FYI: DefaultListSelectionModel.java fixes

This patch (committed) fixes some failing Mauve tests in the DefaultListSelectionModel class - there's still more to do: 2006-06-21 David Gilbert [EMAIL PROTECTED] * javax/swing/DefaultListSelectionModel.java (getSelectionMode): Updated API docs,