[cp-patches] FYI: JLabel.setDisplayedMnemonicIndex() fixlet

This patch (committed) fixes the failures in the Mauve tests I committed earlier, and updates the API docs a little: 2006-06-22 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JLabel.java (setDisplayedMnemonic): Updated API docs, (getDisplayedMnemonic): Removed unneces

[cp-patches] FYI: JLabel.setDisplayedMnemonic() - another fixlet

This patch (committed) fixes a couple of failing Mauve tests (which I'll commit shortly): 2006-06-22 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JLabel.java (setDisplayedMnemonic(int)): Fire property change event AFTER updating field, (setDisplayedMnemonicI

[cp-patches] FYI: JLabel.setText()

This patch (committed) fixes some failing Mauve tests: 2006-06-22 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JLabel.java (getText): Updated API docs, (setText): Corrected the check for an unchanged value, and the update of the displayedMnemonicIndex. Regar

[cp-patches] FYI: fix NPE in JMenu

Hi, this patch fixes a NullPointerException which happens in JMenu.removeAll. This problem was easily spotable using our Swing demo. The ChangeLog: 2006-06-22 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JMenu.java: (removeAll): Added check for popupMenu not being null.

[cp-patches] FYI: More PlainDocument.insertUpdate() tests

I added 3 more tests for PlainDocument.insertUpdate() that show problems in our impl. 2006-06-22 Roman Kennke <[EMAIL PROTECTED]> * gnu/testlet/javax/swing/text/PlainDocument/insertUpdate.java (test02): New test method. (test03): New test method. (test04): New te

[cp-patches] FYI: BasicLabelUI keyboard mapping implemented

This patch (committed) implements the keyboard to action mapping in the BasicLabelUI class, removing a couple more stubbed methods: 2006-06-22 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicLabelUI.java (installKeyboardActions): Implemented, (uninstall

[cp-patches] FYI: PlainDocument fixes

This fixes an ugly issue in PlainDocument.insertUpdate(). This method didn't handle the special case of inserting text after a newline correctly. I basically rewrote this piece, it has been such a mess before. And luckily, we now pass all Mauve and Harmony tests for that class :-) ! 2006-06-22 Ro

[cp-patches] FYI: AbstractDocument fixlets

This makes some mauve test quiet. It sets a document property that we should make use of one day, and it checks the bounds in removeImpl(). 2006-06-22 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/AbstractDocument.java (AbstractDocument): Set the i18n document property.

[cp-patches] FYI: Insets.toString fix

Hi, this small patch makes Insets.toString() return the information formatted in the same way as on the RI. ChangeLog: 2006-06-22 Robert Schuster <[EMAIL PROTECTED]> * java/awt/Insets.java: Updated copyright year. (toString): Changed string, removed a line from the docu

[cp-patches] FYI: JLabel API doc updates

This patch (committed) updates the API docs for the JLabel class: 2006-06-22 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JLabel.java: Updated API docs. Regards, Dave Index: javax/swing/JLabel.java === RCS file: /sour

[cp-patches] RFA: Container.java

Hey, The applyComponentOrientation method needs to actually set the ComponentOrientation property of the container and it doesn't need to check if the value of the ComponentOrientation passed to it is null as the setComponentOrientation method already does this. This change is based on the result

[cp-patches] RFA: Window.java

Hey, The invalidate() method should be called within the hid() method of Window.java. This now causes Harmony's testDispse(test.java.awt.WindowRTest) to pass on Classpath. Could someone please approve this patch so that I can commit it. Thanks. Here's the Changelog Entry: 2006-06-22 Tania Ben

[cp-patches] FYI: JComponent fixes

3 fixes for JComponent: 1. All PropertyChangeEvent methods have been removed. They are all handled in Component anyway and only called super. However, there was one method addPropertyChangeListener(String,PropertyChangeListener) which did not call super, but instead registered the listener to the l

Re: [cp-patches] RFA: Window.java

Hi Tania, > The invalidate() method should be called within the hid() method of > Window.java. This now causes Harmony's > testDispse(test.java.awt.WindowRTest) to pass on Classpath. Some quick testing shows that invalidate() isn't called from hide() in the RI, at least not directly from the hid

Re: [cp-patches] RFA: Container.java

Hi Tania, > The applyComponentOrientation method needs to actually set the > ComponentOrientation property of the container and it doesn't need to > check if the value of the ComponentOrientation passed to it is null as > the setComponentOrientation method already does this. This change is > base

Re: [cp-patches] RFA: Container.java

Hi Tania, In Sun's API specification for Component.setComponentOrientation() it says: "To set the orientation of a single component, use this method. To set the orientation of an entire component hierarchy, use |applyComponentOrientation|

[cp-patches] RFC: GConf updates

Hi! I've checked this twice, but given the kind of update I suggest to give another look at it, so this is also a RFA. This release contains a couple of fixes, most important it adds explicit tests in the GConf native layer so that an invalid key does not results in a crash. I have added also som