Re: [cp-patches] RFC: Crypto PBEKeySpec password references

2006-06-29 Thread Casey Marshall
On Jun 29, 2006, at 4:33 PM, Matthew Wringe wrote: On Thu, 2006-06-29 at 15:36 -0700, Casey Marshall wrote: On Jun 29, 2006, at 3:24 PM, Matthew Wringe wrote: Hi, I have attached a very small patch that fixes PR28204 : PBEKeySpec incorrectly deletes the originally passed password array (http

Re: [cp-patches] RFC: Crypto PBEKeySpec password references

2006-06-29 Thread Matthew Wringe
On Thu, 2006-06-29 at 15:36 -0700, Casey Marshall wrote: > On Jun 29, 2006, at 3:24 PM, Matthew Wringe wrote: > > > Hi, > > > > I have attached a very small patch that fixes PR28204 : PBEKeySpec > > incorrectly deletes the originally passed password array > > (http://gcc.gnu.org/bugzilla/show_bug.

Re: [cp-patches] RFC: Crypto PBEKeySpec password references

2006-06-29 Thread Casey Marshall
On Jun 29, 2006, at 3:24 PM, Matthew Wringe wrote: Hi, I have attached a very small patch that fixes PR28204 : PBEKeySpec incorrectly deletes the originally passed password array (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28204) Instead of taking a reference to the passed password, it now cr

Re: [cp-patches] X/Escher peers

2006-06-29 Thread Andrew John Hughes
On Thu, 2006-06-29 at 15:09 -0700, Casey Marshall wrote: > On Jun 29, 2006, at 2:35 AM, Roman Kennke wrote: > > > Hi Casey, > > > >> Oh, and also, why can't we include the Escher source in external/? It > >> sounds to me like it needs to be forked anyway (especially if it's > >> going to get Xauth

[cp-patches] RFC: Crypto PBEKeySpec password references

2006-06-29 Thread Matthew Wringe
Hi, I have attached a very small patch that fixes PR28204 : PBEKeySpec incorrectly deletes the originally passed password array (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28204) Instead of taking a reference to the passed password, it now creates a copy of it. Thanks, Matt Wringe Changelog:

Re: [cp-patches] X/Escher peers

2006-06-29 Thread Casey Marshall
On Jun 29, 2006, at 2:35 AM, Roman Kennke wrote: Hi Casey, Oh, and also, why can't we include the Escher source in external/? It sounds to me like it needs to be forked anyway (especially if it's going to get Xauthority handling, which it definitely needs). Is the author even working on it any

RE: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Andrew John Hughes
On Thu, 2006-06-29 at 10:33 +0200, Jeroen Frijters wrote: > Andrew John Hughes wrote: > > This patch puts a bit more into thread state handling. > > I apologize for being blunt, but this patch is unacceptable. It doesn't > cover all cases, it's incorrect and inefficient. > > I really think it's b

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Andrew John Hughes
On Wed, 2006-06-28 at 21:07 +0100, Andrew John Hughes wrote: > This patch puts a bit more into thread state handling. > It adds a variable to hold the state inside the thread > (in much the same way as the name is handled). It also > updates some of the methods so that they also update the > state

Re: [cp-patches] FYI: Implement java.lang.management.ClassLoadingMXBean

2006-06-29 Thread Andrew John Hughes
On Mon, 2006-06-26 at 15:20 -0600, Tom Tromey wrote: > > "Andrew" == Andrew John Hughes <[EMAIL PROTECTED]> writes: > > Andrew> The attached patch adds the class loading management bean > Andrew> interface and an appropriate GNU implementation. This adds > Andrew> four new VM methods to provi

[cp-patches] FYI: X peers

2006-06-29 Thread Roman Kennke
I checked in the Escher-based X peers and added some configury for enabling it. To build the X peers you need the most recent Escher library, to be found here: http://kennke.org/~roman/escher-0.3.0.jar Configure with: --with-escher=/path/to/escher-0.3.0.jar --enable-local-sockets This automatica

[cp-patches] FYI: JComponent default locale fix

2006-06-29 Thread David Gilbert
This patch (committed) fixes a failing test in Intel's test suite: 2006-06-29 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JComponent.java (JComponent()): Initialize the locale here, not the default locale, (getDefaultLocale): If null, return Locale.getDefault(),

[cp-patches] RFA: more TextArea.java fixes

2006-06-29 Thread Tania Bento
Hey, This patch fixes a couple of Harmony's Tests that were failing on Classpath: - In the InsertText and AppendTextMethod, I added the case where peer == null. - In the constructor, if the text specified by the user is null, it should be changed to "". Could someone please approve/comment on th

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Andrew John Hughes
On Thu, 29 Jun 2006 14:16:49 +0200 Christian Thalinger <[EMAIL PROTECTED]> wrote: > On Thu, 2006-06-29 at 10:35 +0100, Andrew John Hughes wrote: > > Based on your comments, it seems you agree with my original intuition > > of making this a native VM call (by default) in the majority of > > cases

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Christian Thalinger
On Thu, 2006-06-29 at 10:35 +0100, Andrew John Hughes wrote: > Based on your comments, it seems you agree with my original intuition > of making this a native VM call (by default) in the majority of > cases, but > efficiency would seem to be fairly VM specific. > > I suppose I was aiming on ligh

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Andrew John Hughes
On 29 Jun 2006, at 11:04, Jeroen Frijters wrote: Andrew John Hughes wrote: Based on your comments, it seems you agree with my original intuition of making this a native VM call (by default) in the majority of cases, but efficiency would seem to be fairly VM specific. Sure, but Thread.getState

Re: [cp-patches] Patch: FYI: add more tools

2006-06-29 Thread Raif S. Naffah
hello Tom, On Wednesday 28 June 2006 04:54, Tom Tromey wrote: > ... > Quick question on the tool wrappers. They all use -Xbootclasspath/p > to add tools.zip to the boot class path. I don't understand this. > Wouldn't it be better to simply use the system class path here? yes it is. the -Xbootc

RE: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Jeroen Frijters
Andrew John Hughes wrote: > Based on your comments, it seems you agree with my original intuition > of making this a native VM call (by default) in the majority of > cases, but efficiency would seem to be fairly VM specific. Sure, but Thread.getState() is unlikely to be used very often and shoul

[cp-patches] FYI: Merge File.listRoots security checks from libgcj

2006-06-29 Thread Gary Benson
Hi again, This commit merges security checks for File.listRoots from libgcj. Cheers, Gary Index: ChangeLog === RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.7966 diff -u -r1.7966 ChangeLog --- ChangeLog 2

Re: [cp-patches] X/Escher peers

2006-06-29 Thread Roman Kennke
Hi Casey, > Oh, and also, why can't we include the Escher source in external/? It > sounds to me like it needs to be forked anyway (especially if it's > going to get Xauthority handling, which it definitely needs). Is the > author even working on it any more? Escher is an external library,

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Andrew John Hughes
Hi Jeroen, On 29 Jun 2006, at 09:33, Jeroen Frijters wrote: Andrew John Hughes wrote: This patch puts a bit more into thread state handling. I apologize for being blunt, but this patch is unacceptable. It doesn't cover all cases, it's incorrect and inefficient. Yes, I acknowledged this

[cp-patches] FYI: Fix FilePermission on root directory

2006-06-29 Thread Gary Benson
Hi all, This commit fixes a bug whereby FilePermission("/") did not imply itself. There was some old (and broken) code for compensating for paths with trailing separators. Nowadays paths are canonicalized; canonical paths never have trailing separators, so I just junked the old code. Cheers, Ga

RE: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Jeroen Frijters
Andrew John Hughes wrote: > This patch puts a bit more into thread state handling. I apologize for being blunt, but this patch is unacceptable. It doesn't cover all cases, it's incorrect and inefficient. I really think it's best to leave determining the thread state up to VMThread, except of cour