[cp-patches] [ssl-nio] fix RSA and stream ciphers; add PSK cipher suites

2006-07-14 Thread Casey Marshall
(wrapBuffer, wrapBuffer): new methods. (WrappedBuffer): new class. * gnu/javax/net/ssl/provider/X509KeyManagerFactory.java (getAliases): add RSA_PSK. 20060714.patch.gz Description: GNU Zip compressed data PGP.sig Description: This is a digitally signed message part

[cp-patches] RFC: Some JFileChooser fixes

2006-07-14 Thread Sven de Marothy
This fixes some bugs: -Default mode is FILES_ONLY. -FILES_ONLY mode doesn't mean "show only files" it means "allow only files to be selected". -Hitting enter or return doesn't cancel renaming of files. -File-name textbox is not set to directory names when in FILES_ONLY, (but you can still traverse

[cp-patches] FYI: Minor awt.font.* fixes

2006-07-14 Thread Sven de Marothy
2006-07-14 Sven de Marothy <[EMAIL PROTECTED]> * java/awt/font/TextLayout.java: (hitTestChar): Stub method. * java/awt/font/TextMeasurer.java: (getLayout): Throw exception on invalid argument. Index: java/awt/font/TextLayout.java

[cp-patches] FYI: Databuffer fixlet

2006-07-14 Thread Sven de Marothy
2006-07-14 Sven de Marothy <[EMAIL PROTECTED]> * java/awt/image/DataBuffer.java (DataBuffer): Call constructors in the correct order, Index: java/awt/image/DataBuffer.java === RCS file: /sources/classpath/c

Re: [cp-patches] FYI: java.awt.GridBagLayout.AdjustForGravity

2006-07-14 Thread Mark Wielaard
Hi Tom, On Thu, 2006-07-13 at 15:30 -0400, Thomas Fitzsimmons wrote: > Darn, I didn't realize this was actually called from within GridBagLayout. > For > now, let's revert to Sven's version of the patch (to the detriment of the > Mauve > results, but to the benefit of JDialog) since I may not

[cp-patches] FYI: XToolkit image loading

2006-07-14 Thread Roman Kennke
This completes the image loading code of XToolkit. All image loading is performed by ImageIO, and the resulting BufferedImage so then transferred to an XImage. In the future I hope we can make the XImage the DataBuffer of the BufferedImage, so that this step can be avoided. 2006-07-14 Roman K

Re: [cp-patches] FYI: MultiPixelPackedSampleModel - more fixes

2006-07-14 Thread Sven de Marothy
On Fri, 2006-07-14 at 13:54 +0100, David Gilbert wrote: > This patch (committed) fixes a couple more problems in the > MultiPixelPackedSampleModel class: You're a brave man for looking into this stuff, David :) Good work. I've got a few fixes myself for some awt.image stuff, I'll make sure to com

Re: [cp-patches] RFA: FlowLayout.java

2006-07-14 Thread Tania Bento
Thanks. Committed. On Fri, 2006-07-14 at 10:22 -0400, Lillian Angel wrote: > On Fri, 2006-07-14 at 10:10 -0400, Tania Bento wrote: > > Hey, > > > > According to Java's API, setHgap and setVgap do not throw an Illegal > > Argument Exception if hgap or vgap are negative values. > > > > Two Inte

[cp-patches] FYI: MultiPixelPackedSampleModel.java - updated API docs

2006-07-14 Thread David Gilbert
This patch (committed) updates the API docs for the MultiPixelPackedSampleModel class: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java: Added API docs all over. Regards, Dave Index: java/awt/image/MultiPixelPackedSampleModel.jav

Re: [cp-patches] RFA: FlowLayout.java

2006-07-14 Thread Lillian Angel
On Fri, 2006-07-14 at 10:10 -0400, Tania Bento wrote: > Hey, > > According to Java's API, setHgap and setVgap do not throw an Illegal > Argument Exception if hgap or vgap are negative values. > > Two Intel tests now pass on Classpath > (test.java.awt.FlowLayoutTest.testGetSetHgap() and > test.j

[cp-patches] RFA: FlowLayout.java

2006-07-14 Thread Tania Bento
Hey, According to Java's API, setHgap and setVgap do not throw an Illegal Argument Exception if hgap or vgap are negative values. Two Intel tests now pass on Classpath (test.java.awt.FlowLayoutTest.testGetSetHgap() and test.java.awt.FlowLayoutTest.testGetSetVgap()). Could someone please commen

Re: [cp-patches] RFA: Crypto CipherAdapter.init parameter check

2006-07-14 Thread Matthew Wringe
On Wed, 2006-07-12 at 11:44 -0700, Casey Marshall wrote: > On Jul 10, 2006, at 6:38 PM, Matthew Wringe wrote: > > > This patch is in relation to bug 28104: Cipher.init(...) does not > > check > > if the passed parameters are valid: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28104 > > > > Th

[cp-patches] FYI: MultiPixelPackedSampleModel.createDataBuffer() fix

2006-07-14 Thread David Gilbert
This patch (committed) fixes a bug in the createDataBuffer() method of the MultiPixelPackedSampleModel class. I also removed the FIXME - it doesn't apply for this class: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java (createDat

Re: [cp-patches] FYI: Component/Container fixes

2006-07-14 Thread Audrius Meskauskas
Roman Kennke wrote: What advantage do you expect from using java.util.concurrent.lock? With this package, it is possible to obtain either write (exclusive) or read (shared) lock on the structure. The read lock can be granted to many threads at once, as long as the write lock is not granted. Th

[cp-patches] FYI: MultiPixelPackedSampleModel - more fixes

2006-07-14 Thread David Gilbert
This patch (committed) fixes a couple more problems in the MultiPixelPackedSampleModel class: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java (getSampleSize()): Return a copy of the array, (getTransferType()): New method o

[cp-patches] FYI: CardLayout fixlet

2006-07-14 Thread Roman Kennke
We need to validate() in CardLayout.show() to make sure that the components have a good layout. This bug showed up in that AWT/Espresso app that I debug atm. 2006-07-14 Roman Kennke <[EMAIL PROTECTED]> * java/awt/CardLayout.java (show): Validate parent to make sure that the l

[cp-patches] FYI: AWT locking

2006-07-14 Thread Roman Kennke
While working on an app that makes use of threading (the app is based on the commercial Espresso toolkit, a Swing-alike toolkit based on AWT), I noticed that we don't tree-lock some methods in Component/Container that must be tree-locked. Generally we must synchronize on: - coode that changes

[cp-patches] FYI: MultiPixelPackedSampleModel.createSubsetSampleModel() - new fix

2006-07-14 Thread David Gilbert
My previous patch for this method was wrong. I amended the Mauve test and committed the following (which fixes the Mauve test and a failure in the Intel test suite): 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java (createSubsetSa

[cp-patches] FYI: MultiPixelPackedSampleModel.createSubsetSampleModel() fix

2006-07-14 Thread David Gilbert
This patch (committed) removes the argument check in the createSubsetSampleModel() method of the MultiPixelPackedSampleModel class, to match the behaviour of the reference implementation: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java

[cp-patches] FYI: Hierarchy(Bounds)Listener support

2006-07-14 Thread Roman Kennke
I noticed that we didn't support Hierarchy(Bounds)Listeners at all in our AWT/Swing. I implemented support for this. One problem with HierarchyEvents is that they get dispatched not only to the source component (like most other events) but must be propagated through all children and their chil

[cp-patches] FYI: MultiPixelPackedSampleModel equals() and hashCode() implemented

2006-07-14 Thread David Gilbert
This patch (committed) implements equals() and hashCode() in MultiPixelPackedSampleModel, making the corresponding Mauve tests pass: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java (equals): New method override, (hashCode)

Re: [cp-patches] FYI: MultiPixelPackedSampleModel fixlet

2006-07-14 Thread David Gilbert
Hi Roman, I just committed a further adjustment to the scanlineStride calculation that fixes a number of failing test cases in Mauve (and also Intel's test suite). Can you check that your GIF decoding still works... Regards, Dave Roman Kennke wrote: The GIF decoding didn't work for some s

[cp-patches] FYI: MultiPixelPackedSampleModel.java fix

2006-07-14 Thread David Gilbert
This patch (committed) fixes a bug in the scanlineStride calculation in the constructor for MultiPixelPackedSampleModel: 2006-07-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/MultiPixelPackedSampleModel.java (MultiPixelPackedSampleModel(int, int, int, int, int, int)):