Re: [cp-patches] RFC: JTree and BasicToolBarUI

2006-08-22 Thread Roman Kennke
Hi Tania, The JTree change looks ok. Only some remark about the BasicToolBarUI one: Index: javax/swing/plaf/basic/BasicToolBarUI.java === RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicToolBarUI.java,v

[cp-patches] FYI: Swing Button/UI optimization

2006-08-22 Thread Roman Kennke
This should improve memory footprint and initialization performance for JButton and derived classes: - The listeners in AbstractButton are combined into one class, thus only one instance needs to be instantiated per button (no sharing possible unfortunately). The protected ButtonChangeListener

[cp-patches] FYI: JComponent fix

2006-08-22 Thread Roman Kennke
In JComponent we handle pref/min/max size specially. However, since JDK1.5, we have the same stuff in Component (setBlahSize(), isBlahSizeSet()). I adjusted the JComponent impl to use the super impl when appropriate. This should improve memory footprint as it avoids the doubled space for the

[cp-patches] RFA: MenuShortcut.java

2006-08-22 Thread Tania Bento
Hey, This patch fixes a failing test in Intel's TestSuite. I have committed a mauve test for this. Could someone kindly comment on and/or approve this patch. Cheers, Tania 2006-08-22 Tania Bento [EMAIL PROTECTED] * java/awt/MenuShortcut.java (MenuShortcut (int, boolean)):