Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Casey Marshall
Casey Marshall wrote: I've updated these again. One of these days I'll take the time to apply these to a clean checkout, and test that. Promise. Or, hey, is this OK to commit yet? I get fewer Mauve

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Christian Thalinger
On Fri, Sep 15, 2006 at 12:20:33AM +0200, Christian Thalinger wrote: > On Thu, Sep 14, 2006 at 11:18:34AM -0700, Casey Marshall wrote: > > Does cacao support GetDirectBufferAddress properly? There may be a bug > > there. > > Hmm, it unlikely, because OpenGL stuff works and that uses directu > buff

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Christian Thalinger
On Thu, Sep 14, 2006 at 11:18:34AM -0700, Casey Marshall wrote: > Does cacao support GetDirectBufferAddress properly? There may be a bug > there. Hmm, it unlikely, because OpenGL stuff works and that uses directu buffers a lot. But I'll try the patch. - twisti

Re: [cp-patches] RFC: Gradient fix for Cairo 1.2

2006-09-14 Thread Francis Kung
And it helps if I attach the patch. Again. I think this means I shouldn't be submitting patches this late in the afternoon =) Francis On Thu, 2006-09-14 at 16:46 -0400, Francis Kung wrote: > On Wed, 2006-09-13 at 13:04 -0400, Francis Kung wrote: > > Hi, > > > > The attached patch fixes gradien

Re: [cp-patches] RFC: Gradient fix for Cairo 1.2

2006-09-14 Thread Francis Kung
On Wed, 2006-09-13 at 13:04 -0400, Francis Kung wrote: > Hi, > > The attached patch fixes gradients in cairo 1.2, but unfortunately it > will break the build if compiled against cairo 1.0. Tom pointed out the CAIRO_VERSION macro which can be used at compile-time, and the attached patch (committed

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Casey Marshall
Mark Wielaard wrote: > On Wed, 2006-09-13 at 18:01 -0400, Thomas Fitzsimmons wrote: >> I'm testing these patches to see if they fix the RMI problem I'm having >> (which >> may be unrelated): >> [...] >> Were you aware of this problem? I think it was introduced by Mark's native >> layer merge.

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Thomas Fitzsimmons
Casey Marshall wrote: Thomas Fitzsimmons wrote: OK, the new patches build for me (though I had to add KqueueSelectorImpl lines to include/Makefile.am) but now running rmiregistry under cacao fails like this: $ gdb --args /notnfs/fitzsim/install/classpath-inst/bin/cacao gnu.java.rmi.registry.Re

Re: [cp-patches] RFC: Cairo interpolation

2006-09-14 Thread Francis Kung
> > > +else if > > > (hints.containsValue(RenderingHints.VALUE_ALPHA_INTERPOLATION_QUALITY)) > > > + return 3; // CAIRO_FILTER_BEST > > > + > > > +else if > > > (hints.containsValue(RenderingHints.VALUE_ALPHA_INTERPOLATION_DEFAULT)) > > > + return 4; // CAIRO_FILTER_GOOD

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Casey Marshall
Thomas Fitzsimmons wrote: > OK, the new patches build for me (though I had to add KqueueSelectorImpl > lines to include/Makefile.am) but now running rmiregistry under cacao > fails like this: > > $ gdb --args /notnfs/fitzsim/install/classpath-inst/bin/cacao > gnu.java.rmi.registry.RegistryImpl >

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Thomas Fitzsimmons
Casey Marshall wrote: Thomas Fitzsimmons wrote: Hi, Casey Marshall wrote: I wasn't aware of that problem, no. Since this patch rewrites accept() pretty much from scratch, then yeah, it may work in my version. Two more errors: 5. ERROR in /home/fitzsim/workspace/classpath/gnu/java/nio/FileCha

[cp-patches] FYI: SocketPermission host checking rewrite

2006-09-14 Thread Gary Benson
Hi again, This commit rewrites the host checking in SocketPermission so it does what the javadoc says it should. (This is the end result of all my InetAddress hacking this past couple of weeks.) We now pass all the SocketPermission mauve tests. Cheers, Gary Index: ChangeLog

[cp-patches] RFC: InetAddress DNS caching

2006-09-14 Thread Gary Benson
Hi all, The documentation for java.net.InetAddress states that it maintains a DNS cache in order to guard against DNS spoofing attacks. This patch adds this, but I wanted to float it for comments before checking it in as this has been an issue before: Classpath _had_ a DNS cache, but it was remov

[cp-patches] FYI: java.awt.Menu - fix for PR28699

2006-09-14 Thread David Gilbert
This patch (committed) fixes a bug (PR28699) in the insert() method of the java.awt.Menu class: 2006-09-14 David Gilbert <[EMAIL PROTECTED]> Fixes PR28699 * java/awt/Menu.java (insert(MenuItem, int)): Fixed loop range, (insert(String, int)): Updated API docs.

Re: [cp-patches] PR22800 fix (arm float parsing)

2006-09-14 Thread Christian Thalinger
On Wed, Sep 13, 2006 at 11:34:16AM +0200, Mark Wielaard wrote: > Hi Christian, > > On Tue, 2006-09-12 at 16:57 +0200, Christian Thalinger wrote: > > I really think we should include that patch and revert my old one. I've > > tested it and it works. Ok to commit? > > > > 2006-10-12 Christian Tha

[cp-patches] FYI: java.awt.Menu.java - source reformatted

2006-09-14 Thread David Gilbert
This patch (committed) reformats the source file to match our coding style more closely: 2006-09-14 David Gilbert <[EMAIL PROTECTED]> * java/awt/Menu.java: Reformatted source file. Regards, Dave Index: java/awt/Menu.java ==

[cp-patches] FYI: Fix for gnu/java/rmi/server/ActivatableRef.java

2006-09-14 Thread Jeroen Frijters
Hi, Committed. This fix isn't perfect, but it's better than the current code. Regards, Jeroen 2006-09-14 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/java/rmi/server/ActivatableRef.java (readExternal, writeExternal): Partial fix for serialization format. Index: gnu/java/rmi/serve

Re: [cp-patches] PATCH: (mprec.c) Fix _Jv_ulp for 64-bit __Long

2006-09-14 Thread Christian Thalinger
On Thu, Sep 14, 2006 at 09:47:37AM +0200, Mark Wielaard wrote: > Hi Andrew and Christian, > > By now you two probably know mprec.c better than others. Could you take > a look at this patch suggestion? Might this be related to the recent > miscompilation observed by Andrew? Do we have testcases for

Re: [cp-patches] Ignore serialVersionUID mismatches for arrays

2006-09-14 Thread Elias Naur
On Tuesday 12 September 2006 21:31, Elias Naur wrote: > Hi, > > I've recently stumbled on a problem with serializing arrays from the Sun > java implementation to the Jikes RVM implementation. I think the problem is > that Classpath doesn't ignore serialVersionUID mismatches for array > classes, and

[cp-patches] FYI: InputStreamReader fix for 28984

2006-09-14 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2006-09-14 Jeroen Frijters <[EMAIL PROTECTED]> PR classpath/28984 * java/io/InputStreamReader.java (read(char[],int,int)): Fixed bug. Index: java/io/InputStreamReader.java ==

Re: [cp-patches] FYI: AttributedString constructor fix (for PR29010)

2006-09-14 Thread David Gilbert
Mark Wielaard wrote: Hi David, On Mon, 2006-09-11 at 11:57 +0100, David Gilbert wrote: Mauve tests will be committed shortly. I've assumed that the fix is small enough not to require FSF paperwork. Yes, you are right. In general things smaller than 10/15 lines, or "obvious" fixes (as

Re: [cp-patches] PATCH: (mprec.c) Fix _Jv_ulp for 64-bit __Long

2006-09-14 Thread Mark Wielaard
Hi Andrew and Christian, By now you two probably know mprec.c better than others. Could you take a look at this patch suggestion? Might this be related to the recent miscompilation observed by Andrew? Do we have testcases for this problem? Thanks, Makr On Sun, 2006-09-10 at 10:37 -0400, Aaron M

Re: [cp-patches] FYI: AttributedString constructor fix (for PR29010)

2006-09-14 Thread Mark Wielaard
Hi David, On Mon, 2006-09-11 at 11:57 +0100, David Gilbert wrote: > I committed this patch attached to PR29010, after testing it: > > 2006-09-11 Cameron McCormack <[EMAIL PROTECTED]> > > Fixes PR29010 > * java/text/AttributedString.java > (AttributedString(AttributedCharacter

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Mark Wielaard
On Wed, 2006-09-13 at 18:01 -0400, Thomas Fitzsimmons wrote: > I'm testing these patches to see if they fix the RMI problem I'm having > (which > may be unrelated): > [...] > Were you aware of this problem? I think it was introduced by Mark's native > layer merge. They were definitely introdu