Re: [cp-patches] HTMLWriter

2006-10-30 Thread Roman Kennke
Hi David, > I have fixed the formatting, added comments and also finished up the > incomplete parts. Hope this passes the muster :) Looks good to me. I have included it in my local tree and finished it up for committing (Some more formatting etc). I'd like to talk back to Mark before anyhow. You

[cp-patches] FYI: DragSourceContext method implemented

2006-10-30 Thread Roman Kennke
This implements the missing updateCurrentCursor() method in DragSourceContext. I couldn't think of an easy Mauve test for this. So I implemented this like it seemed most reasonable. 2006-10-30 Roman Kennke <[EMAIL PROTECTED]> * java/awt/dnd/DragSourceContext.java (dragExit): Use

[cp-patches] FYI: New DragGestureRecognizer test

2006-10-30 Thread Roman Kennke
This adds a test for DragGestureRecognizer.resetRecognizer(). 2006-10-30 Roman Kennke <[EMAIL PROTECTED]> * gnu/testlet/java/awt/dnd/DragGestureRecognizer/resetRecognizer.java: New test. /Roman Index: gnu/testlet/java/awt/dnd/DragGestureRecognizer/resetRecognizer.java =

Re: [cp-patches] HTMLWriter

2006-10-30 Thread fchoong
tElem; while((tempParentElem = tempParentElem.getParentElement()) != null) { if(!htmlFragmentParentHashSet.contains(tempParentElem)) htmlFragmentParentHashSet.add(tempParentElem); } // while((tempParentElem = tempParentElem.getParentElement())

[cp-patches] FYI: DragGestureRecognizer fixlet

2006-10-30 Thread Roman Kennke
This makes DragGestureRecognizer.resetRecognizer() not discard the events object, but rather call clear() on it. This is accompanied by a Mauve test to show correctness. I also removed the not implemented tag, because I believe that this is all that should be done there. At least, this is what the

[cp-patches] FYI: DataFlavor.writeExternal() remove not implemented tag

2006-10-30 Thread Roman Kennke
This removes the not implemented tag from DataFlavor.writeExternal() as this is now implemented. I forgot that in the last patch. 2006-10-30 Roman Kennke <[EMAIL PROTECTED]> * java/awt/datatransfer/DataFlavor.java (writeExternal): Remove not implemented tag. /Roman Index: java/

[cp-patches] FYI: New DataFlavor methods

2006-10-30 Thread Roman Kennke
This implements two missing methods in DataFlavor: readExternal() and writeExternal(). This is accompanied by Mauve tests. These tests showed that the RI serializes an internal class java.awt.datatransfer.MimeType together with the DataFlavor. So, for maximum compatibility, I added a helper class f