Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Raif S. Naffah
On Sunday 26 November 2006 19:58, Casey Marshall wrote: On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: On Tuesday 21 November 2006 08:35, Casey Marshall wrote: ... This patch fixes an issue with JarEntry objects that are created before the entry is verified... ...before your patch

[cp-patches] Re: FYI: few DecimalFormat fixes

2006-11-27 Thread Mark Wielaard
Hi Mario, On Mon, 2006-11-27 at 03:45 +0100, Mario Torre wrote: I've fixed some of them. There are a couple of them difficult to find, though. Nice one! This not only fixed most of the regressions, but according to the autobuilder mauve run on classpath-testresults this (plus some of the other

[cp-patches] FYI: TextLayout new method

2006-11-27 Thread Roman Kennke
This implemented TextLayout.getCaretInfo(). The impl is backed by the tests in the Harmony testsuite. 2006-11-27 Roman Kennke [EMAIL PROTECTED] * java/awt/font/TextLayout.java (Run.font): New field. (Run.location): New field. (Run.Run): Initialize font.

[cp-patches] FYI: More new TextLayout methods

2006-11-27 Thread Roman Kennke
Here comes another bunch of methods for TextLayout. Again, this is based on the specs: http://java.sun.com/j2se/1.4.2/docs/guide/2d/spec/j2d-fonts.html and is backed up by the tests in the Harmony testsuite. /Roman Index: java/awt/font/TextLayout.java

[cp-patches] FYI: More TextLayout

2006-11-27 Thread Roman Kennke
This one implements the last missing piece in TextLayout, the visual highlighting of ranges. I found the Harmony tests here a little difficult as it depends on other stuff beeing working correctly (most notable getBlackBoxBounds()) which obviously isn't good with us. So to show correctness I wrote

[cp-patches] JSR166: sun/reflect/misc/ReflectUtil.java

2006-11-27 Thread Andrew Haley
sun.reflect.misc.ReflectUtil.checkPackageAccess(declaringClass) contains the comment: // FIXME: not sure what to check here. As its name suggests, I think it's intended to call SecurityManager.checkPackageAccess() to make sure the current thread is allowed to access the package of the

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Casey Marshall
On Nov 27, 2006, at 12:08 AM, Raif S. Naffah wrote: On Sunday 26 November 2006 19:58, Casey Marshall wrote: On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: On Tuesday 21 November 2006 08:35, Casey Marshall wrote: ... This patch fixes an issue with JarEntry objects that are created before

Re: [cp-patches] FYI: DecimalFormat

2006-11-27 Thread Tom Tromey
Mario == Mario Torre [EMAIL PROTECTED] writes: Mario I've committed the changes with the following Changelog: Mario 2006-11-25 Mario Torre [EMAIL PROTECTED] Mario * java/text/DecimalFormatSymbols.java (clone): fixed to also clone Mario locale. Do we really need this? As I recall Locale is

[cp-patches] FYI: WritableRaster.createChild implemented

2006-11-27 Thread Francis Kung
Hi, This patch implements the above-mentioned method, which is functionally identical to the Raster.createChild (which it overrides), except that it returns a WritableRaster. The spec does not require this, but a mauve test confirms the behaviour, and some applications seem to rely on it.

Re: [cp-patches] RFA: Eclipse cleanup

2006-11-27 Thread Tom Tromey
Francis == Francis Kung [EMAIL PROTECTED] writes: Francis I'd like to make the following two changes to the Eclipse settings Francis files: I didn't see a response to this. I think it is ok. Tom

[cp-patches] [generics] FYI: Make name and ordinal in Enum final

2006-11-27 Thread Andrew John Hughes
This makes the name and ordinal fields in Enum final so they can be better optimized. Changelog: 2006-11-27 Andrew John Hughes [EMAIL PROTECTED] * java/lang/Enum.java: Make name and ordinal final. -- Andrew :-) Escape the Java Trap with GNU Classpath!

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Casey Marshall
On Nov 27, 2006, at 10:52 AM, Casey Marshall wrote: On Nov 27, 2006, at 12:08 AM, Raif S. Naffah wrote: any reason why you didn't address the synchronization issue in JarEntry#getCertificates()? I wasn't sure if it was needed. It is needed, and JarFile explains that you need to lock on