[cp-patches] PATCH: Fix schema factory discovery

2006-12-06 Thread Chris Burdess
This patch (committed) implements the algorithm for schema factory implementation discovery. 2006-12-056 Chris Burdess [EMAIL PROTECTED] Fixes PR 28816. * javax/xml/validation/SchemaFactory.java: Use correct algorithm to discover schema factory implementation class. patch

[cp-patches] PATCH: fix for XMLStreamWriter.writeDTD

2006-12-06 Thread Chris Burdess
This patch corrects a misunderstanding about XMLStreamWriter.writeDTD. 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29264. * gnu/xml/stream/XMLStreamWriterImpl.java: Allow arbitrary text in writeDTD method. patch Description: Binary data PGP.sig Description: This is a

[cp-patches] PATCH: trivial fixes in XML classes

2006-12-06 Thread Chris Burdess
This patch - corrects Javadoc formatting in DocumentBuilderFactory - plugs a file descriptor leak in the main method of SAXParser (only used for testing) 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29272. * javax/xml/parsers/DocumentBuilderFactory.java: Fix broken

Re: [cp-patches] FYI: AsyncImage observers fix

2006-12-06 Thread Mark Wielaard
Hi Roman, Could you take a look at this new mauve failure that was introduced by the AsyncImage code (afaiks). FAIL: java.beans.SimpleBeanInfo.loadImage Thanks, Mark signature.asc Description: This is a digitally signed message part

Re: [cp-patches] Fix interrupted read/writes

2006-12-06 Thread Andrew Haley
Casey Marshall writes: On Dec 5, 2006, at 2:52 AM, Andrew Haley wrote: The cpnio functions are (should be) trivial and inlined. What more is needed? Now, is VMChannel supposed to be POSIX-specific or not? If it is Yes, it is. supposed to be POSIX-specific, and there seem

[cp-patches] FYI: Proposal for RuleBasedCollator and 1.3 completeness

2006-12-06 Thread Mario Torre
Hi! This patch moves the logic to build a CollationElementIterator from RuleBasedCollator and Collator into the class CollationElementIterator itself. *This is not a fix*. Infact, actually the new Constructor just read a string out of the iterator, without any processing. This way we can

Re: [cp-patches] FYI: Proposal for RuleBasedCollator and 1.3 completeness

2006-12-06 Thread Mario Torre
Ops, sorry, actually the subject is a RFC... Mario -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa

[cp-patches] Re: FYI: Proposal for RuleBasedCollator and 1.3 completeness

2006-12-06 Thread Mark Wielaard
Hi Mario, On Wed, 2006-12-06 at 13:18 +0100, Mario Torre wrote: This patch moves the logic to build a CollationElementIterator from RuleBasedCollator and Collator into the class CollationElementIterator itself. *This is not a fix*. Infact, actually the new Constructor just read a string

[cp-patches] Re: FYI: Proposal for RuleBasedCollator and 1.3 completeness

2006-12-06 Thread Mario Torre
Il giorno mer, 06/12/2006 alle 13.50 +0100, Mark Wielaard ha scritto: Hi Mario, Hi Mark! Thank you for the quick reply! But in the old code the decomposing is done, although not really in the classpath case, only in the case of libgcj. Could you explain the difference between

[cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
Hey, This patch fixes a bug in javax.swing.border.CompoundBorder's isBorderOpaque() method. The reference implementation specifications states that this method only returns true if both the inside and outside borders have a non-null value and both are opaque; false, otherwise. However, the mauve

Re: [cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread David Gilbert
Tania Bento wrote: Hey, This patch fixes a bug in javax.swing.border.CompoundBorder's isBorderOpaque() method. The reference implementation specifications states that this method only returns true if both the inside and outside borders have a non-null value and both are opaque; false,

Re: [cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
Hi David, On Wed, 2006-12-06 at 16:39 +, David Gilbert wrote: Hi Tania, It is a good idea to report such problems (in the specification) to Sun. Although, this one has already been reported: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4778988 Thanks for the info. I actually

Re: [cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
Hey, On Wed, 2006-12-06 at 12:51 -0500, Tania Bento wrote: Hi David, On Wed, 2006-12-06 at 16:39 +, David Gilbert wrote: Hi Tania, It is a good idea to report such problems (in the specification) to Sun. Although, this one has already been reported:

[cp-patches] PATCH: DOM event propagation fix

2006-12-06 Thread Chris Burdess
I'm committing this minor patch from Ben Konrath which appears to resolve some NPE problems in Eclipse. Mark, this is not marked critical in Bugzilla so I don't believe it is release critical. 2006-12-06 Ben Konrath [EMAIL PROTECTED] Fixes PR 29853. *

[cp-patches] FYI: Rectangle2D.getBounds

2006-12-06 Thread Francis Kung
Hi, Currently, when getBounds is called on RectangularShape, it checks whether the current rectangle is empty and returns an empty rectangle at 0,0 if it is. I've just committed a mauve test showing that this is not the expected behaviour; empty rectangles should not be reset. This is

[cp-patches] FYI: HTML fixes

2006-12-06 Thread Roman Kennke
This fixes some minor stability issues with the HTML renderer. Most importantly it makes the renderer handle misplaced td th and tr tags handle more gracefully. Also, this fixes the alignment of blocks. This should be OK to go into the release branch, though not strictly necessary. 2006-12-06

[cp-patches] FYI: More TableView stability

2006-12-06 Thread Roman Kennke
This protects the TableView from borking on some more invalid HTML, like the one on GNU Classpath's website. 2006-12-06 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/TableView.java (RowView.layoutMajorAxis): Check column index for invalid value. (updateGrid):

[cp-patches] FYI: Swing text fixes

2006-12-06 Thread Roman Kennke
This fixes a couple of issues in the Swing text code for better stability. Also this removes the scrollRectToVisible() that causes the view to scroll around when activating a link. 2006-12-06 Roman Kennke [EMAIL PROTECTED] * javax/swing/JEditorPane.java (getStream): Buffer the

[cp-patches] FYI: ScrollPane fix

2006-12-06 Thread Thomas Fitzsimmons
Hi, I committed this patch to trunk and classpath-0_93-branch. It fixes some ScrollPane issues: 1) doLayout should not be called by addImpl 2) a Panel parent should only be added to lightweight children of the ScrollPane 3) GTK assertion failures for Button and Label children of

[cp-patches] FYI: HTML browser

2006-12-06 Thread Roman Kennke
This makes the HTML demo a better webbrowser by adding a back and reload button with history. This also includes some improved testpages. 2006-12-06 Roman Kennke [EMAIL PROTECTED] * examples/gnu/classpath/examples/icons/back.png, *

Re: [cp-patches] Fix interrupted read/writes

2006-12-06 Thread Casey Marshall
On Dec 6, 2006, at 4:01 AM, Andrew Haley wrote: Casey Marshall writes: On Dec 5, 2006, at 2:52 AM, Andrew Haley wrote: The cpnio functions are (should be) trivial and inlined. What more is needed? Now, is VMChannel supposed to be POSIX-specific or not? If it is Yes, it is. supposed to

[cp-patches] FYI: SyncImage vs null Observers

2006-12-06 Thread Mark Wielaard
Hi, Small fixlet for AsyncImage so that it doesn't try to call a method on a null Observer. 2006-12-06 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/AsyncImage.java (addObserver): Never notify null Observer. Committed, Mark diff -u -r1.3 AsyncImage.java ---

[cp-patches] FYI: HtmlDemo fixlets

2006-12-06 Thread Roman Kennke
This fixes a method access in the Demo class and converts URLs to strings. For some reason (a problem in java.net) it does not work with the URL object. 2006-12-06 Roman Kennke [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (getIcon): Made package private.

[cp-patches] FYI: AsyncImage fixes

2006-12-06 Thread Roman Kennke
This fixes some remaining locking issue in AsyncImage. There was still a small chance of tripping into NPEs here. This also fixes the checkImage() issue which showed up in Mauve. 2006-12-06 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/AsyncImage.java (Loader.run):

Re: [cp-patches] [generics] Code-cleanup: remove unused imports

2006-12-06 Thread Tom Tromey
Stefan == Stefan Huehner [EMAIL PROTECTED] writes: Stefan attached patch removes several unused import statement from Stefan generics-branch. Could you write a ChangeLog entry for this? And is your paperwork on file? Stefan Index: external/sax/org/xml/sax/helpers/ParserFactory.java Patches to

Re: [cp-patches] [generics] Code-cleanup: remove unused imports

2006-12-06 Thread Casey Marshall
On Dec 6, 2006, at 2:49 PM, Tom Tromey wrote: Stefan == Stefan Huehner [EMAIL PROTECTED] writes: Stefan attached patch removes several unused import statement from Stefan generics-branch. Could you write a ChangeLog entry for this? And is your paperwork on file? Isn't this patch large but

Re: [cp-patches] [generics] Code-cleanup: remove unused imports

2006-12-06 Thread Tom Tromey
Casey == Casey Marshall [EMAIL PROTECTED] writes: Could you write a ChangeLog entry for this? And is your paperwork on file? Casey Isn't this patch large but trivial? [*] Is copyright assignment Casey really necessary? I never know with these whopping-but-trivial changes. Anyway, hopefully