Re: [cp-patches] FYI: added AC_C_INLINE check

2007-04-13 Thread Mark Wielaard
On Wed, 2007-04-11 at 22:38 +0200, Christian Thalinger wrote: > I added the AC_C_INLINE check in configure.ac, since some compilers > don't understand the inline keyword. > > This one is commited and should go on the release branch. It now is. > 2007-04-11 Christian Thalinger <[EMAIL PROTECTED

[cp-patches] Re: [calendar] Make computeTime() sometimes update fields

2007-04-13 Thread Gary Benson
Doh Gary Benson wrote: > Hi again, > > This commit makes GregorianCalendar.computeTime() sometimes update > the fields. The more weird logic I put in to make us match Sun the > less happy I am, but I'm hoping that something's suddenly going to > click and it's all going to become clear. Til the

[cp-patches] [calendar] Make computeTime() sometimes update fields

2007-04-13 Thread Gary Benson
Hi again, This commit makes GregorianCalendar.computeTime() sometimes update the fields. The more weird logic I put in to make us match Sun the less happy I am, but I'm hoping that something's suddenly going to click and it's all going to become clear. Til then... well, that's why I'm working on

[cp-patches] [calendar] Another GregorianCalendar.setDefaultFields() tweak

2007-04-13 Thread Gary Benson
Hi again, This commit makes GregorianCalendar.setDefaultFields() set only fields that are undefined. Cheers, Gary Index: ChangeLog === RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9239.2.7 diff -u -r1.9239

[cp-patches] [calendar] fix Calendar.clear()

2007-04-13 Thread Gary Benson
Hi again, This commit removes the call to complete() from Calendar.clear(). Cheers, Gary Index: ChangeLog === RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9239.2.6 diff -u -r1.9239.2.6 ChangeLog --- Change

[cp-patches] [calendar] Reorder Calendar.complete()

2007-04-13 Thread Gary Benson
Hi again, This commit reorders Calendar.complete() and moves the setting of isTimeSet in order to match Sun's implementation. Cheers, Gary Index: ChangeLog === RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.

[cp-patches] [calendar] fix Calendar.setTimeZone()

2007-04-13 Thread Gary Benson
Hi again, This commit makes Calendar.setTimeZone() simply invalidate the fields rather than recalculating the entire thing. There seems to be a general thing of setters invalidate, getters calculate going on in Sun's implementation. At the moment in Classpath we have a bit of a mixture, which ma

[cp-patches] [calendar] GregorianCalendar.setDefaultFields() tweak

2007-04-13 Thread Gary Benson
Hi again, This commit changes the default for DAY_OF_WEEK_IN_MONTH to match Sun's implementation, and adds a couple of comments explaining what might otherwise look like odd decisions. Cheers, Gary Index: ChangeLog === RCS file: /cvs

[cp-patches] [calendar] move field defaults into GregorianCalendar

2007-04-13 Thread Gary Benson
Hi again, This commit moves the default values for undefined fields into GregorianCalendar where they belong. It's possible that these need to be a little more fine-grained but this commit is a step closer to what Sun does. Cheers, Gary Index: ChangeLog ==

[cp-patches] [calendar] remove explicitDSTOffset from Calendar

2007-04-13 Thread Gary Benson
Hi all, This patch removes the explicitDSTOffset stuff from Calendar. I'm not sure what the final solution to this is but the present method of locking the DST offset once set is not it. Cheers, Gary Index: ChangeLog === RCS file: /c