Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-04 Thread Tom Tromey
> "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes: Ian> + private static char[] cloneCharArray(char[] src) Ian> + { Ian> +char[] copy = new char[src.length]; Ian> +VMSystem.arraycopy(src, 0, copy, 0, src.length); Ian> +return copy; Ian> + } I think it would be better in these

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-04 Thread Robert Lougher
Hi, On 2/4/08, Ian Rogers <[EMAIL PROTECTED]> wrote: > Hi, > > xalan performs 1.4 million char array clones per iteration of the normal > size DaCapo benchmark. All of the character array clones are coming from > java.lang.String. The attached patch changes the use of char[].clone > (which maps to

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-04 Thread Christian Thalinger
On Mon, 2008-02-04 at 15:48 +, Ian Rogers wrote: > Hi, > > xalan performs 1.4 million char array clones per iteration of the normal > size DaCapo benchmark. All of the character array clones are coming from > java.lang.String. The attached patch changes the use of char[].clone > (which maps

[cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-04 Thread Ian Rogers
Hi, xalan performs 1.4 million char array clones per iteration of the normal size DaCapo benchmark. All of the character array clones are coming from java.lang.String. The attached patch changes the use of char[].clone (which maps to java.lang.Object.clone) to a helper method that allocates t