Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-07 Thread Ian Rogers
Tom Tromey wrote: Ian == Ian Rogers [EMAIL PROTECTED] writes: Ian Please let me know if you think this patch is suitable for Ian inclusion. It looks fine. I do have one nit, which is that we put spaces around operators... this problem is pervasive in the patch, but here's one

Re: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-07 Thread Ian Rogers
Mark Wielaard wrote: On Tue, 2008-02-05 at 06:07 -0700, Tom Tromey wrote: Ian == Ian Rogers [EMAIL PROTECTED] writes: Ian the attached patch stops the lazy initialization of a Calendar object Ian in ZipEntry and instead uses a static final one. I thought this could lead to

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-07 Thread Tom Tromey
Ian + * java/lang/String.java Ian + Only copy live portion of String. Use array copies in preference to clone. The ChangeLog entry should mention method names. See other examples in the file, or the GNU coding standards. Otherwise -- looks good to me, thanks. Tom

[cp-patches] RFC: Double.doubleToLongBits simplified

2008-02-07 Thread Dalibor Topic
Hi all, I've implemented doubleToLongBits without requring a VMDouble method of the same name. It would let us remove one method from the VM interface for the next version, and the corresoponding native code. OK to commit? (I'd do the equivalent patch for Float, too). * java/lang/Double.java